nvme-fc: Add message when creating new association
Subsystems (2)
PATCH v2 1/1 nvme-fc: Add message when creating new association
When looking at console messages to troubleshoot, there are one maybe two messages before creation of the controller is complete. However, a lot of io takes place to reach that point. It's unclear when things have started.
Add a message when the controller is attempting to create a new association. Thus we know what controller, between what host and remote port, and what NQN is being put into place for any subsequent success or failure messages.
--
v2:
Moved message to create association so displayed at initial
creation as well as at each reconnect
Changed message to additionally print host port wwpn and target port
wwpn.
--- drivers/nvme/host/fc.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/nvme/host/fc.c +6 -0
@@ -2607,6 +2607,12 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)if (nvme_fc_ctlr_active_on_rport (ctrl))return -ENOTUNIQ ; +dev_info (ctrl->ctrl.device, +"NVME-FC{%d}: create association : host wwpn 0x%016llx " +" rport wwpn 0x%016llx: NQN \"%s\"\n" , + ctrl->cnum, ctrl->lport->localport.port_name, + ctrl->rport->remoteport.port_name, ctrl->ctrl.opts->subsysnqn); +/* * Create the admin queue */
Signature · 1 line
2.13.7
PATCH v2 1/1 nvme-fc: Add message when creating new association
Looks good.
Quoted 40 lines · James Smart
When looking at console messages to troubleshoot, there are one maybe two messages before creation of the controller is complete. However, a lot of io takes place to reach that point. It's unclear when things have started.
Add a message when the controller is attempting to create a new association. Thus we know what controller, between what host and remote port, and what NQN is being put into place for any subsequent success or failure messages.
Signed-off-by James Smart <jsmart2021 at gmail.com>--
v2:
Moved message to create association so displayed at initial
creation as well as at each reconnect
Changed message to additionally print host port wwpn and target port
wwpn.--- drivers/nvme/host/fc.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/nvme/host/fc.c +6
-0@@ -2607,6 +2607,12 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)if (nvme_fc_ctlr_active_on_rport (ctrl))return -ENOTUNIQ ; +dev_info (ctrl->ctrl.device, +"NVME-FC{%d}: create association : host wwpn 0x%016llx " +" rport wwpn 0x%016llx: NQN \"%s\"\n" , + ctrl->cnum, ctrl->lport->localport.port_name, + ctrl->rport->remoteport.port_name, ctrl->ctrl.opts->subsysnqn); +/* * Create the admin queue */
PATCH v2 1/1 nvme-fc: Add message when creating new association
In reply to James SmartQuoted 30 lines · James Smart
When looking at console messages to troubleshoot, there are one maybe two messages before creation of the controller is complete. However, a lot of io takes place to reach that point. It's unclear when things have started.
Add a message when the controller is attempting to create a new association. Thus we know what controller, between what host and remote port, and what NQN is being put into place for any subsequent success or failure messages.
Signed-off-by James Smart <jsmart2021 at gmail.com>--
v2:
Moved message to create association so displayed at initial
creation as well as at each reconnect
Changed message to additionally print host port wwpn and target port
wwpn.--- drivers/nvme/host/fc.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/nvme/host/fc.c +0
-0@@ -2607,6 +2607,12 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)if (nvme_fc_ctlr_active_on_rport (ctrl))return -ENOTUNIQ ;
drivers/nvme/host/fc.c nvme_fc_create_association(struct nvme_fc_ctrl *ctrl) · line 2618
Quoted 10 lines
drivers/nvme/host/fc.c +6
-0+dev_info (ctrl->ctrl.device, +"NVME-FC{%d}: create association : host wwpn 0x%016llx " +" rport wwpn 0x%016llx: NQN \"%s\"\n" , + ctrl->cnum, ctrl->lport->localport.port_name, + ctrl->rport->remoteport.port_name, ctrl->ctrl.opts->subsysnqn); +/* * Create the admin queue */
Looks good. Thanks!
-- arun
PATCH v2 1/1 nvme-fc: Add message when creating new association
In reply to James SmartLooks good.
?On 5/29/19, 3:25 PM, "Linux-nvme on behalf of James Smart" <[email protected] on behalf of [email protected]> wrote:
When looking at console messages to troubleshoot, there are one
maybe two messages before creation of the controller is complete.
However, a lot of io takes place to reach that point. It's unclear
when things have started.
Add a message when the controller is attempting to create a new
association. Thus we know what controller, between what host and
remote port, and what NQN is being put into place for any
subsequent success or failure messages.
Signed-off-by: James Smart <jsmart2021 at gmail.com>
--
v2:
Moved message to create association so displayed at initial
creation as well as at each reconnect
Changed message to additionally print host port wwpn and target port
wwpn.
---
drivers/nvme/host/fc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index c17c887f2148..bd1be8aa2d65 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2607,6 +2607,12 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
if (nvme_fc_ctlr_active_on_rport(ctrl))
return -ENOTUNIQ;
+ dev_info(ctrl->ctrl.device,
+ "NVME-FC{%d}: create association : host wwpn 0x%016llx "
+ " rport wwpn 0x%016llx: NQN \"%s\"\n",
+ ctrl->cnum, ctrl->lport->localport.port_name,
+ ctrl->rport->remoteport.port_name, ctrl->ctrl.opts->subsysnqn);
+
/*
* Create the admin queue
*/
--
2.13.7
_______________________________________________
Linux-nvme mailing list
Linux-nvme at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvmeSagi Grimberg
maintainerPATCH v2 1/1 nvme-fc: Add message when creating new association
In reply to James Smart