staging: erofs: remove unsupported ->datamode check in fill_inline_data()
PATCH RESEND 1/1 staging: erofs: remove unsupported ->datamode check in fill_inline_data()
From: Yue Hu <[email protected]>
Already check if ->datamode is supported in read_inode(), no need to check again in the next fill_inline_data() only called by fill_inode().
--- drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/erofs/inode.c +0 -2
@@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,struct erofs_sb_info *sbi =EROFS_I_SB (inode);const int mode = vi->datamode; -DBG_BUGON (mode >=EROFS_INODE_LAYOUT_MAX ); -/* should be inode inline C */ if (mode !=EROFS_INODE_LAYOUT_INLINE )return 0 ;
Signature · 1 line
1.9.1
Quoted 6 lines · Yue Hu
From: Yue Hu <huyue2 at yulong.com>
Already check if ->datamode is supported in
read_inode(), no need to check again in the nextfill_inline_data()only called byfill_inode().Signed-off-by Yue Hu <huyue2 at yulong.com>
Thanks,
Hi Yue,
Quoted 6 lines · Yue Hu
From: Yue Hu <huyue2 at yulong.com>
Already check if ->datamode is supported in
read_inode(), no need to check again in the nextfill_inline_data()only called byfill_inode().Signed-off-by Yue Hu <huyue2 at yulong.com>
You should add all the 'Reviewed-by' / 'Acked-by' / ... tags from other guyes to the following versions when you resend your patches.
Thanks,
Gao Xiang
Quoted 18 lines
--- drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-)drivers/staging/erofs/inode.c +0
-2@@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,struct erofs_sb_info *sbi =EROFS_I_SB (inode);const int mode = vi->datamode; -DBG_BUGON (mode >=EROFS_INODE_LAYOUT_MAX ); -/* should be inode inline C */ if (mode !=EROFS_INODE_LAYOUT_INLINE )return 0 ;