staging: erofs: remove unsupported ->datamode check in fill_inline_data()
PATCH RESEND v3 1/1 staging: erofs: remove unsupported ->datamode check in fill_inline_data()
From: Yue Hu <[email protected]>
Already check if ->datamode is supported in read_inode(), no need to check again in the next fill_inline_data() only called by fill_inode().
---
no change
drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/erofs/inode.c +0 -2
@@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,struct erofs_sb_info *sbi =EROFS_I_SB (inode);const int mode = vi->datamode; -DBG_BUGON (mode >=EROFS_INODE_LAYOUT_MAX ); -/* should be inode inline C */ if (mode !=EROFS_INODE_LAYOUT_INLINE )return 0 ;
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 5 lines · Yue Hu
From: Yue Hu <huyue2 at yulong.com>
Already check if ->datamode is supported in
read_inode(), no need to check again in the nextfill_inline_data()only called byfill_inode().
Quoted 8 lines
Signed-off-by Yue Hu <huyue2 at yulong.com>Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>Reviewed-by Chao Yu <yuchao0 at huawei.com>---
no changedrivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-)
This is already in my tree, right?
confused,
greg k-h
Quoted 12 lines · On Wed, 3 Jul 2019 18:20:38 +0200 Greg KH <[email protected]> wrote:
Quoted 11 lines · Yue Hu
From: Yue Hu <huyue2 at yulong.com>
Already check if ->datamode is supported in
read_inode(), no need to check again in the nextfill_inline_data()only called byfill_inode().Signed-off-by Yue Hu <huyue2 at yulong.com>Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>Reviewed-by Chao Yu <yuchao0 at huawei.com>---
no change
Quoted 4 lines
Quoted 2 lines
drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-)This is already in my tree, right?
Seems not, i have received notes about other 2 patches below mergerd:
```note1
This is a note to let you know that I've just added the patch titled
staging: erofs: don't check special inode layout
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-next branch.
``````note2
This is a note to let you know that I've just added the patch titled
staging: erofs: return the error value if fill_inline_data() fails
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-next branch.
```No this patch in below link checked:
Thanks.
Quoted 4 lines
confused,
greg k-h
Greg KH
maintainerQuoted 42 lines · Yue Hu
Quoted 12 lines · On Wed, 3 Jul 2019 18:20:38 +0200 Greg KH <[email protected]> wrote:
Quoted 11 lines · Yue Hu
From: Yue Hu <huyue2 at yulong.com>
Already check if ->datamode is supported in
read_inode(), no need to check again in the nextfill_inline_data()only called byfill_inode().Signed-off-by Yue Hu <huyue2 at yulong.com>Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>Reviewed-by Chao Yu <yuchao0 at huawei.com>---
no changeQuoted 4 lines
Quoted 2 lines
drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-)This is already in my tree, right?
Seems not, i have received notes about other 2 patches below mergerd:
```note1 This is a note to let you know that I've just added the patch titled staging: erofs: don't check special inode layout to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. ``````note2 This is a note to let you know that I've just added the patch titled staging: erofs: return the error value if fill_inline_data() fails to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. ```
Quoted 3 lines
No this patch in below link checked:
Then if it is not present, it needs to be rebased as it does not apply.
Please do so and resend it.
thanks,
greg k-h
Quoted 43 lines · On Thu, 4 Jul 2019 07:26:49 +0200 Greg KH <[email protected]> wrote:
Quoted 42 lines · Yue Hu
Quoted 12 lines · On Wed, 3 Jul 2019 18:20:38 +0200 Greg KH <[email protected]> wrote:
Quoted 11 lines · Yue Hu
From: Yue Hu <huyue2 at yulong.com>
Already check if ->datamode is supported in
read_inode(), no need to check again in the nextfill_inline_data()only called byfill_inode().Signed-off-by Yue Hu <huyue2 at yulong.com>Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>Reviewed-by Chao Yu <yuchao0 at huawei.com>---
no changeQuoted 4 lines
Quoted 2 lines
drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-)This is already in my tree, right?
Seems not, i have received notes about other 2 patches below mergerd:
```note1 This is a note to let you know that I've just added the patch titled staging: erofs: don't check special inode layout to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. ``````note2 This is a note to let you know that I've just added the patch titled staging: erofs: return the error value if fill_inline_data() fails to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. ```
Quoted 7 lines
Quoted 3 lines
No this patch in below link checked:
Then if it is not present, it needs to be rebased as it does not apply.
Please do so and resend it.
Hm, no need to resend since it's included in another patch below.
ec8c244 staging: erofs: add compacted ondisk compression indexes.
Thanks.
Quoted 4 lines
thanks,
greg k-h
Quoted 50 lines · Yue Hu
Quoted 47 lines · On Thu, 4 Jul 2019 07:26:49 +0200 Greg KH <[email protected]> wrote:
Quoted 45 lines · Yue Hu
Quoted 12 lines · On Wed, 3 Jul 2019 18:20:38 +0200 Greg KH <[email protected]> wrote:
Quoted 11 lines · Yue Hu
From: Yue Hu <huyue2 at yulong.com>
Already check if ->datamode is supported in
read_inode(), no need to check again in the nextfill_inline_data()only called byfill_inode().Signed-off-by Yue Hu <huyue2 at yulong.com>Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>Reviewed-by Chao Yu <yuchao0 at huawei.com>---
no changeQuoted 4 lines
Quoted 2 lines
drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-)This is already in my tree, right?
Seems not, i have received notes about other 2 patches below mergerd:
```note1 This is a note to let you know that I've just added the patch titled staging: erofs: don't check special inode layout to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. ``````note2 This is a note to let you know that I've just added the patch titled staging: erofs: return the error value if fill_inline_data() fails to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. ```No this patch in below link checked:
Quoted 7 lines
Quoted 3 lines
Then if it is not present, it needs to be rebased as it does not apply.
Please do so and resend it.
Hm, no need to resend since it's included in another patch below.
ec8c244 staging: erofs: add compacted ondisk compression indexes.
Yes, it seems it was modified by the following patch occasionally months ago.
https://lore.kernel.org/lkml/20190614181619.64905-2-gaoxiang25 at huawei.com/
Anyway, thanks for your patch. :)
Thanks,
Gao Xiang
Quoted 13 lines
Thanks.
Quoted 4 lines
thanks,
greg k-h
_______________________________________________
devel mailing list
devel at linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel