Skip to contentSkip to conversation

ASoC: SOF: add flag for position update ipc

PATCH Superseded Keyon Jie 4 participants 9 messages Jul 3, 2019 – Jul 18, 2019

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Keyon Jie

author
#0 lore raw

PATCH v2 1/2 ASoC: SOF: add flag for position update ipc

From: Marcin Rajwa <[email protected]>

In some cases, FW might need use the host_period_bytes even no position update ipc reqiured from driver, here add another flag for position update, and preserve host_period_bytes for FW to use.

This might require corresponding FW change and ABI alignment.

---
 include/sound/sof/stream.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/sound/sof/stream.h +2 -2
index 643f175cb479..44acfa62fa69 100644
@@ -83,10 +83,10 @@ struct sof_ipc_stream_params {
 	uint16_t sample_valid_bytes;
 	uint16_t sample_container_bytes;
 
-	/* for notifying host period has completed - 0 means no period IRQ */
 	uint32_t host_period_bytes;
+	uint16_t no_period_irq; /* 1 means period IRQ mode OFF */
 
-	uint32_t reserved[2];
+	uint16_t reserved[3];
 	uint16_t chmap[SOF_IPC_MAX_CHANNELS];	/**< channel map - SOF_CHMAP_ */
 } __packed;
 
Signature · 1 line
2.20.1
author
#1 lore raw

PATCH v2 2/2 ASoC: SOF: Intel: fix reset of host_period_bytes

From: Marcin Rajwa <[email protected]>

This patch prevents the reset of host period bytes. The parameter has been used to keep information about completion of period copy. Right now we keep this information in period_irq.

---
 sound/soc/sof/intel/hda-pcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/sof/intel/hda-pcm.c +2 -2
index 9b730f183529..c7022346aba0 100644
@@ -116,9 +116,9 @@ int hda_dsp_pcm_hw_params(struct snd_sof_dev *sdev,
 	/* disable SPIB, to enable buffer wrap for stream */
 	hda_dsp_stream_spib_config(sdev, stream, HDA_DSP_SPIB_DISABLE, 0);
 
-	/* set host_period_bytes to 0 if no IPC position */
+	/* update no_period_irq flag for ipc params */
 	if (hda && hda->no_ipc_position)
-		ipc_params->host_period_bytes = 0;
+		ipc_params->no_period_irq = 1;
 
 	ipc_params->stream_tag = hstream->stream_tag;
 
Signature · 1 line
2.20.1
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] ASoC: SOF: Intel: fix reset of host_period_bytes

Quoted 9 lines · Keyon Jie

From: Marcin Rajwa <[email protected]>

This patch prevents the reset of host period bytes. The parameter has been used to keep information about completion of period copy. Right now we keep this information in period_irq.

Quoted 23 lines
---
 sound/soc/sof/intel/hda-pcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/sof/intel/hda- renamed from sound/soc/sof/intel/hda-pcm.c +0 -0

pcm.c
index 9b730f183529..c7022346aba0 100644

sound/soc/sof/intel/hda-pcm.c +2 -2
@@ -116,9 +116,9 @@ int hda_dsp_pcm_hw_params(struct snd_sof_dev
 *sdev,
 	/* disable SPIB, to enable buffer wrap for stream */
 	hda_dsp_stream_spib_config(sdev, stream, HDA_DSP_SPIB_DISABLE,
 0);
 
-	/* set host_period_bytes to 0 if no IPC position */
+	/* update no_period_irq flag for ipc params */
 	if (hda && hda->no_ipc_position)
-		ipc_params->host_period_bytes = 0;
+		ipc_params->no_period_irq = 1;
 

ipc_params->stream_tag = hstream->stream_tag;

reviewer Reviewed-by on v2 2/2
#3 lore raw

Re: [PATCH v2 2/2] ASoC: SOF: Intel: fix reset of host_period_bytes

In reply to Keyon Jie

Hi,

Quoted 9 lines · Keyon Jie

From: Marcin Rajwa <[email protected]>

This patch prevents the reset of host period bytes. The parameter has been used to keep information about completion of period copy. Right now we keep this information in period_irq.

looks good, for this patch:

reviewer
#4 lore raw
In reply to Keyon Jie

Hi,

patch looks good, but commit message could be improved.

Quoted 3 lines · Keyon Jie

In some cases, FW might need use the host_period_bytes even no position update ipc reqiured from driver, here add another flag for position update, and preserve host_period_bytes for FW to use.

Speculation on what FW might do is not really needed. The host_period_bytes field has been overloaded with multiple semantics and this patch clears that, right. How about:

""
Remove the special case semantics of 'host_period_bytes==0'. Add a new field 'no_period_irq' to signal whether period elapsed IPC should be sent and use 'host_period_bytes' only for period size.
""

Quoted 1 line

This might require corresponding FW change and ABI alignment.

This is not helpful -- we know this _is_ a minor ABI change and needs to be aligned with FW.

Br, Kai

author
#5 lore raw
Quoted 6 lines · Kai Vehmanen

Hi,

patch looks good, but commit message could be improved.

On Wed, 3 Jul 2019, Keyon Jie wrote:

Quoted 7 lines
Quoted 3 lines

In some cases, FW might need use the host_period_bytes even no position update ipc reqiured from driver, here add another flag for position update, and preserve host_period_bytes for FW to use.

Speculation on what FW might do is not really needed. The host_period_bytes field has been overloaded with multiple semantics and this patch clears that, right. How about:

Well, to me it is flavor choice, Ranjani suggested to illustrate the use case where the FW will use this host_period_bytes, and I agreed this will help people to understand why we need this change.

Quoted 8 lines

""
Remove the special case semantics of 'host_period_bytes==0'. Add a new field 'no_period_irq' to signal whether period elapsed IPC should be sent and use 'host_period_bytes' only for period size.
""

Quoted 4 lines
Quoted 1 line

This might require corresponding FW change and ABI alignment.

This is not helpful -- we know this _is_ a minor ABI change and needs to be aligned with FW.

It is minor change, but the FW change is still required, otherwise, we will get extra position update IPCs which may confuse the driver, please refer to here:
https://github.com/thesofproject/sof/pull/1592

Thanks,
~Keyon

Quoted 8 lines

Br, Kai

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

reviewer
#6 lore raw

Hi,

Quoted 3 lines · Keyon Jie

Well, to me it is flavor choice, Ranjani suggested to illustrate the use case where the FW will use this host_period_bytes, and I agreed this will help people to understand why we need this change.

hmm, ok. So maybe add "Allows FW to use 'host_period_bytes' field for its original purpose" to my proposed wording..?

Quoted 4 lines
Quoted 2 lines

This is not helpful -- we know this _is_ a minor ABI change and needs to be aligned with FW.

It is minor change, but the FW change is still required, otherwise, we will get extra position update IPCs which may confuse the driver, please

[...]

Quoted 1 line

https://github.com/thesofproject/sof/pull/1592

Ack, but we know this already so best to put the accurate description in the commit message. The "might require FW change" is a bit scary statement in a patch touching ABI structs. ;)

#7 lore raw
In reply to Keyon Jie
Quoted 5 lines · Keyon Jie

From: Marcin Rajwa <[email protected]>

In some cases, FW might need use the host_period_bytes even no position update ipc reqiured from driver, here add another flag for position update, and preserve host_period_bytes for FW to use.

please fix the commit message, e.g. with the suggested edit below

In some cases, FW might need to use the host_period_bytes field to fetch data over DMA but the driver does not need any position information returned over the IPC channel by the firmware. The current IPC definition prevents this capability, so add new field.

Quoted 2 lines

This might require corresponding FW change and ABI alignment.

remove this statement, this is already handled in backwards compatible mode.

Quoted 12 lines
---
  include/sound/sof/stream.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
include/sound/sof/stream.h +0 -0
index 643f175cb479..44acfa62fa69 100644

include/sound/sof/stream.h struct sof_ipc_stream_params { · line 87

Quoted 6 lines
include/sound/sof/stream.h +1 -1
@@ -83,10 +83,10 @@ struct sof_ipc_stream_params {
  	uint16_t sample_valid_bytes;
  	uint16_t sample_container_bytes;
 
-	/* for notifying host period has completed - 0 means no period IRQ */
  	uint32_t host_period_bytes;
+	uint16_t no_period_irq; /* 1 means period IRQ mode OFF */

I'd like this field to be renamed as 'no_position_update'. This really has nothing to do with no period_irq in general, even when you do use the no_irq mode you can still retrieve the position information from the HDaudio DMA registers.

Quoted 6 lines
include/sound/sof/stream.h +1 -1
-	uint32_t reserved[2];
+	uint16_t reserved[3];
  	uint16_t chmap[SOF_IPC_MAX_CHANNELS];	/**< channel map - SOF_CHMAP_ */
  } __packed;
 
 
author
#8 lore raw
Quoted 5 lines · Pierre-Louis Bossart
Quoted 2 lines · Keyon Jie

From: Marcin Rajwa <[email protected]>

Quoted 7 lines
Quoted 3 lines

In some cases, FW might need use the host_period_bytes even no position update ipc reqiured from driver, here add another flag for position update, and preserve host_period_bytes for FW to use.

please fix the commit message, e.g. with the suggested edit below

In some cases, FW might need to use the host_period_bytes field to fetch data over DMA but the driver does not need any position information returned over the IPC channel by the firmware. The current IPC definition prevents this capability, so add new field.

Good, thanks for the detail suggestion.

Quoted 5 lines
Quoted 3 lines

This might require corresponding FW change and ABI alignment.

remove this statement, this is already handled in backwards compatible mode.

OK.

Quoted 8 lines
Quoted 8 lines

---
  include/sound/sof/stream.h | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines
Quoted 11 lines
include/sound/sof/stream.h +0 -1
index 643f175cb479..44acfa62fa69 100644
@@ -83,10 +83,10 @@ struct sof_ipc_stream_params {
       uint16_t sample_valid_bytes;
       uint16_t sample_container_bytes;
-    /* for notifying host period has completed - 0 means no period 

IRQ */
      uint32_t host_period_bytes;
+    uint16_t no_period_irq; /* 1 means period IRQ mode OFF */

I'd like this field to be renamed as 'no_position_update'. This really has nothing to do with no period_irq in general, even when you do use the no_irq mode you can still retrieve the position information from the HDaudio DMA registers.

Agree, that's actually my original version, will change in next version, thanks.

Thanks,
~Keyon

Quoted 11 lines
Quoted 6 lines

-    uint32_t reserved[2];
+    uint16_t reserved[3];
      uint16_t chmap[SOF_IPC_MAX_CHANNELS];    /**< channel map - SOF_CHMAP_ */ } __packed;

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel