Skip to contentSkip to conversation

dt-bindings: reset: imx7: Add support for i.MX8MM

PATCH Superseded [email protected] 2 participants 5 messages Jul 4, 2019

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: reset: imx7: Add support for i.MX8MM

From: Anson Huang <[email protected]>

i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible property and related info to support i.MX8MM.

---
New patch.

---
 Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/reset/fsl,imx7-src.txt +2 -2
index 13e0951..bc24c45 100644
@@ -7,7 +7,7 @@ controller binding usage.
 Required properties:
 - compatible:
 	- For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
-	- For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
+	- For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"
 - reg: should be register base and length as documented in the
   datasheet
 - interrupts: Should contain SRC interrupt
@@ -47,4 +47,4 @@ Example:
 
 For list of all valid reset indices see
 <dt-bindings/reset/imx7-reset.h> for i.MX7 and
-<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ
+<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ/i.MX8MM
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 2/2 arm64: dts: imx8mm: Add "fsl,imx8mq-src" as src's fallback compatible

From: Anson Huang <[email protected]>

i.MX8MM can reuse i.MX8MQ's src driver, add "fsl,imx8mq-src" as src's fallback compatible to enable it.

---
No changes.

---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -1
index 172bb6f..1870c89 100644
@@ -520,7 +520,7 @@
 			};
 
 			src: reset-controller@30390000 {
-				compatible = "fsl,imx8mm-src", "syscon";
+				compatible = "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon";
 				reg = <0x30390000 0x10000>;
 				interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
 				#reset-cells = <1>;
Signature · 1 line
2.7.4
maintainer
#2 lore raw
In reply to [email protected]
Quoted 17 lines · On Thu, 2019-07-04 at 17:25 +0800, [email protected] wrote:

From: Anson Huang <[email protected]>

i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible property and related info to support i.MX8MM.

---
New patch.

---
 Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/reset/fsl,imx7-src.txt +0 -0
index 13e0951..bc24c45 100644

Documentation/devicetree/bindings/reset/fsl,imx7-src.txt controller binding usage. · line 10

Quoted 5 lines
Documentation/devicetree/bindings/reset/fsl,imx7-src.txt +1 -1
@@ -7,7 +7,7 @@ controller binding usage.
 Required properties:
 - compatible:
 	- For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
-	- For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
+	- For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"

Please still add the "fsl,imx8mm-src" for i.MX8MM, just in case a significant difference is discovered later.

regards
Philipp

#3 lore raw

Hi, Philipp

Quoted 13 lines · On Thu, 2019-07-04 at 17:25 +0800, [email protected] wrote:
Quoted 12 lines

From: Anson Huang <[email protected]>

i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible property and related info to support i.MX8MM.

---
New patch.

---
 Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 14 lines

Documentation/devicetree/bindings/reset/fsl,imx7-src.txt controller binding usage. · line 10

Quoted 11 lines
Documentation/devicetree/bindings/reset/fsl,imx7-src.txt +1 -1
index 13e0951..bc24c45 100644
@@ -7,7 +7,7 @@ controller binding usage.
 Required properties:
 - compatible:
 	- For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
-	- For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
+	- For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"

Please still add the "fsl,imx8mm-src" for i.MX8MM, just in case a significant difference is discovered later.

OK, then I will add a new line as below:

For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon"

Anson.

Quoted 3 lines

regards
Philipp

maintainer
#4 lore raw
Quoted 30 lines · Anson Huang

Hi, Philipp

Quoted 13 lines · On Thu, 2019-07-04 at 17:25 +0800, [email protected] wrote:
Quoted 12 lines

From: Anson Huang <[email protected]>

i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible property and related info to support i.MX8MM.

---
New patch.

---
 Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 14 lines

Documentation/devicetree/bindings/reset/fsl,imx7-src.txt controller binding usage. · line 10

Quoted 11 lines
Documentation/devicetree/bindings/reset/fsl,imx7-src.txt +1 -1
index 13e0951..bc24c45 100644
@@ -7,7 +7,7 @@ controller binding usage.
 Required properties:
 - compatible:
 	- For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
-	- For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
+	- For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"

Please still add the "fsl,imx8mm-src" for i.MX8MM, just in case a significant difference is discovered later.

Quoted 3 lines

OK, then I will add a new line as below:

For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon"

Yes, that looks good, thanks.

regards
Philipp