Skip to contentSkip to conversation

raw/ioat: fix issue with icc build

PATCH Applied Bruce Richardson 4 participants 4 messages Jul 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 raw/ioat: fix issue with icc build

When using _mm_set_epi64() rather than _mm_set_epi64x() intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes.

error #13203: No EMMS instruction before call to function

Fix this by using the set64x() intrinsic.

Fixes 0a92e63fc4cd ("raw/ioat: add local API to perform copies")
---
 drivers/raw/ioat/rte_ioat_rawdev.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/raw/ioat/rte_ioat_rawdev.h +1 -2
index 3babb822d..7a89632e7 100644
@@ -124,8 +124,7 @@ rte_ioat_enqueue_copy(int dev_id, phys_addr_t src, phys_addr_t dst,
 	desc->src_addr = src;
 	desc->dest_addr = dst;
 
-	ioat->hdls[write] = _mm_set_epi64((__m64)((uint64_t)dst_hdl),
-			(__m64)((uint64_t)src_hdl));
+	ioat->hdls[write] = _mm_set_epi64x((int64_t)dst_hdl, (int64_t)src_hdl);
 	rte_prefetch0(&ioat->desc_ring[ioat->next_write & mask]);
 
 	ioat->enqueued++;
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Bruce Richardson
Sent: Friday, July 5, 2019 12:54 PM
To: [email protected]
Cc: Richardson, Bruce <[email protected]>
Subject: [dpdk-dev] [PATCH] raw/ioat: fix issue with icc build

When using _mm_set_epi64() rather than _mm_set_epi64x() intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes.

Quoted 7 lines

error #13203: No EMMS instruction before call to function

Fix this by using the set64x() intrinsic.

Fixes 0a92e63fc4cd ("raw/ioat: add local API to perform copies")

New code compiles fine here with Gcc and Clang;

Tested-by on v1 1/1
#2 lore raw
In reply to Bruce Richardson
Quoted 4 lines · Bruce Richardson

When using _mm_set_epi64() rather than _mm_set_epi64x() intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes.

Quoted 8 lines

error #13203: No EMMS instruction before call to function

Fix this by using the set64x() intrinsic.

Fixes 0a92e63fc4cd ("raw/ioat: add local API to perform copies")

---

Signature · 2 lines
Thanks,
Anatoly
#3 lore raw

05/07/2019 14:33, Burakov, Anatoly:

Quoted 7 lines · Bruce Richardson
Quoted 6 lines

When using _mm_set_epi64() rather than _mm_set_epi64x() intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes.

error #13203: No EMMS instruction before call to function

Quoted 7 lines
Quoted 5 lines

Fix this by using the set64x() intrinsic.

Fixes 0a92e63fc4cd ("raw/ioat: add local API to perform copies")

Applied, thanks