raw/ioat: fix issue with icc build
PATCH 1/1 raw/ioat: fix issue with icc build
When using _mm_set_epi64() rather than _mm_set_epi64x() intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes.
error #13203: No EMMS instruction before call to function
Fix this by using the set64x() intrinsic.
--- drivers/raw/ioat/rte_ioat_rawdev.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/raw/ioat/rte_ioat_rawdev.h +1 -2
@@ -124,8 +124,7 @@ rte_ioat_enqueue_copy(int dev_id, phys_addr_t src, phys_addr_t dst, desc->src_addr = src; desc->dest_addr = dst; - ioat->hdls[write] =_mm_set_epi64 ((__m64)((uint64_t )dst_hdl), - (__m64)((uint64_t )src_hdl)); + ioat->hdls[write] =_mm_set_epi64x ((int64_t )dst_hdl, (int64_t )src_hdl);rte_prefetch0 (&ioat->desc_ring[ioat->next_write & mask]); ioat->enqueued++;
Signature · 1 line
2.21.0
Quoted 11 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Bruce Richardson
Sent: Friday, July 5, 2019 12:54 PM
To: [email protected]
Cc: Richardson, Bruce <[email protected]>
Subject: [dpdk-dev] [PATCH] raw/ioat: fix issue with icc buildWhen using
_mm_set_epi64()rather than_mm_set_epi64x()intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes.
Quoted 7 lines
error #13203: No EMMS instruction before call to function
Fix this by using the
set64x()intrinsic.Fixes 0a92e63fc4cd ("raw/ioat: add local API to perform copies")Signed-off-by Bruce Richardson <[email protected]>
New code compiles fine here with Gcc and Clang;
Quoted 4 lines · Bruce Richardson
When using
_mm_set_epi64()rather than_mm_set_epi64x()intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes.
Quoted 8 lines
error #13203: No EMMS instruction before call to function
Fix this by using the
set64x()intrinsic.Fixes 0a92e63fc4cd ("raw/ioat: add local API to perform copies")Signed-off-by Bruce Richardson <[email protected]>---
Signature · 2 lines
Thanks, Anatoly
Thomas Monjalon
Applied05/07/2019 14:33, Burakov, Anatoly:
Quoted 7 lines · Bruce Richardson
Quoted 6 lines
When using
_mm_set_epi64()rather than_mm_set_epi64x()intrinsic, ICC tries to use the x87 floating point registers, leading to warnings about not properly clearing value when switching between x87 and SSE/AVX modes.error #13203: No EMMS instruction before call to function
Quoted 7 lines
Quoted 5 lines
Fix this by using the
set64x()intrinsic.Fixes 0a92e63fc4cd ("raw/ioat: add local API to perform copies")Signed-off-by Bruce Richardson <[email protected]>Tested-by Anatoly Burakov <[email protected]>
Applied, thanks