Skip to contentSkip to conversation

s390/zcrypt: remove the exporting of ap_query_configuration

PATCH Applied Denis Efremov 3 participants 3 messages Jul 9, 2019 – Jul 11, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390/zcrypt: remove the exporting of ap_query_configuration

The function ap_query_configuration is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/s390/crypto/ap_bus.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.

Fixes f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")
Fixes 050349b5b71d ("s390/zcrypt: externalize AP config info query")
---
 drivers/s390/crypto/ap_bus.c | 1 -
 1 file changed, 1 deletion(-)
drivers/s390/crypto/ap_bus.c +0 -1
index b9fc502c58c2..379e43b79006 100644
@@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)
 		return -EINVAL;
 	return ap_qci(info);
 }
-EXPORT_SYMBOL(ap_query_configuration);
 
 /**
  * ap_init_configuration(): Allocate and query configuration array.
Signature · 1 line
2.21.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Denis Efremov

The function ap_query_configuration is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/s390/crypto/ap_bus.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.

Fixes f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")
Fixes 050349b5b71d ("s390/zcrypt: externalize AP config info query")
---
 drivers/s390/crypto/ap_bus.c | 1 -
 1 file changed, 1 deletion(-)
drivers/s390/crypto/ap_bus.c +0 -0
index b9fc502c58c2..379e43b79006 100644

drivers/s390/crypto/ap_bus.c static inline int ap_query_configuration(struct ap_config_info *info) · line 213

Quoted 7 lines
drivers/s390/crypto/ap_bus.c +0 -1
@@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)
 		return -EINVAL;
 	return ap_qci(info);
 }
-EXPORT_SYMBOL(ap_query_configuration);
 
 /**
  * ap_init_configuration(): Allocate and query configuration array.

This function was exported a while ago for KVM code. However, never used. So removing the export is the right thing. Thanks Denis

Heiko/Vasily will you pick this patch please?

maintainer Applied
#2 lore raw
Quoted 23 lines · Harald Freudenberger
Quoted 22 lines · Denis Efremov

The function ap_query_configuration is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/s390/crypto/ap_bus.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.

Fixes f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")
Fixes 050349b5b71d ("s390/zcrypt: externalize AP config info query")
---
 drivers/s390/crypto/ap_bus.c | 1 -
 1 file changed, 1 deletion(-)
drivers/s390/crypto/ap_bus.c +0 -1
index b9fc502c58c2..379e43b79006 100644
@@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)
 		return -EINVAL;
 	return ap_qci(info);
 }
-EXPORT_SYMBOL(ap_query_configuration);
 
Quoted 9 lines

drivers/s390/crypto/ap_bus.c static inline int ap_query_configuration(struct ap_config_info *info) · line 213

Quoted 2 lines
drivers/s390/crypto/ap_bus.c +0 -0
 /**
  * ap_init_configuration(): Allocate and query configuration array.

This function was exported a while ago for KVM code. However, never used. So removing the export is the right thing. Thanks Denis

Heiko/Vasily will you pick this patch please?

Applied, thanks.