s390/zcrypt: remove the exporting of ap_query_configuration
Subsystems (2)
PATCH 1/1 s390/zcrypt: remove the exporting of ap_query_configuration
The function ap_query_configuration is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/s390/crypto/ap_bus.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
--- drivers/s390/crypto/ap_bus.c | 1 - 1 file changed, 1 deletion(-)
drivers/s390/crypto/ap_bus.c +0 -1
@@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)return -EINVAL ;return ap_qci (info); } -EXPORT_SYMBOL (ap_query_configuration);/** * ap_init_configuration(): Allocate and query configuration array.
Signature · 1 line
2.21.0
Quoted 17 lines · Denis Efremov
The function
ap_query_configurationis declared static and markedEXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of thedrivers/s390/crypto/ap_bus.cfile it is defined in, this commit removes theEXPORT_SYMBOL()marking.Fixes f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")Fixes 050349b5b71d ("s390/zcrypt: externalize AP config info query")Signed-off-by Denis Efremov <[email protected]>--- drivers/s390/crypto/ap_bus.c | 1 - 1 file changed, 1 deletion(-)drivers/s390/crypto/ap_bus.c +0
-0
drivers/s390/crypto/ap_bus.c static inline int ap_query_configuration(struct ap_config_info *info) · line 213
Quoted 7 lines
drivers/s390/crypto/ap_bus.c +0
-1@@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)return -EINVAL ;return ap_qci (info); } -EXPORT_SYMBOL (ap_query_configuration);/** * ap_init_configuration(): Allocate and query configuration array.
This function was exported a while ago for KVM code. However, never used. So removing the export is the right thing. Thanks Denis
Heiko/Vasily will you pick this patch please?
Quoted 23 lines · Harald Freudenberger
Quoted 22 lines · Denis Efremov
The function
ap_query_configurationis declared static and markedEXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of thedrivers/s390/crypto/ap_bus.cfile it is defined in, this commit removes theEXPORT_SYMBOL()marking.Fixes f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")Fixes 050349b5b71d ("s390/zcrypt: externalize AP config info query")Signed-off-by Denis Efremov <[email protected]>--- drivers/s390/crypto/ap_bus.c | 1 - 1 file changed, 1 deletion(-)drivers/s390/crypto/ap_bus.c +0
-1@@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)return -EINVAL ;return ap_qci (info); } -EXPORT_SYMBOL (ap_query_configuration);
Quoted 9 lines
drivers/s390/crypto/ap_bus.c static inline int ap_query_configuration(struct ap_config_info *info) · line 213
Quoted 2 lines
drivers/s390/crypto/ap_bus.c +0
-0/** * ap_init_configuration(): Allocate and query configuration array. This function was exported a while ago for KVM code. However, never used. So removing the export is the right thing. Thanks Denis
Heiko/Vasily will you pick this patch please?
Reviewed-by Harald Freudenberger <[email protected]>
Applied, thanks.