Skip to contentSkip to conversation

mtd: rawnand: tango: Add of_node_put() before return

PATCH Applied Nishka Dasgupta 3 participants 3 messages Jul 9, 2019 – Jul 25, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: rawnand: tango: Add of_node_put() before return

Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle.

---
 drivers/mtd/nand/raw/tango_nand.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/raw/tango_nand.c +1 -0
index b3f2cabcc7c0..9acf2de37ee0 100644
@@ -659,6 +659,7 @@ static int tango_nand_probe(struct platform_device *pdev)
 		err = chip_init(&pdev->dev, np);
 		if (err) {
 			tango_nand_remove(pdev);
+			of_node_put(np);
 			return err;
 		}
 	}
Signature · 6 lines
2.19.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Nishka Dasgupta

Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle.

---
 drivers/mtd/nand/raw/tango_nand.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/raw/tango_nand.c +0 -0
index b3f2cabcc7c0..9acf2de37ee0 100644

drivers/mtd/nand/raw/tango_nand.c static int tango_nand_probe(struct platform_device *pdev) · line 665

Quoted 7 lines
drivers/mtd/nand/raw/tango_nand.c +1 -0
@@ -659,6 +659,7 @@ static int tango_nand_probe(struct platform_device *pdev)
 		err = chip_init(&pdev->dev, np);
 		if (err) {
 			tango_nand_remove(pdev);
+			of_node_put(np);
 			return err;
 		}
 	}
Signature · 5 lines
Måns Rullgård

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
maintainer Applied
#2 lore raw
In reply to Nishka Dasgupta
Quoted 7 lines · Nishka Dasgupta

Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle.

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/