mtd: rawnand: tango: Add of_node_put() before return
Subsystems (2)
PATCH 1/1 mtd: rawnand: tango: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle.
--- drivers/mtd/nand/raw/tango_nand.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/nand/raw/tango_nand.c +1 -0
@@ -659,6 +659,7 @@ static int tango_nand_probe(struct platform_device *pdev) err =chip_init (&pdev->dev, np);if (err) {tango_nand_remove (pdev); +of_node_put (np);return err; } }
Signature · 6 lines
2.19.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 16 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return. Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/mtd/nand/raw/tango_nand.c | 1 + 1 file changed, 1 insertion(+)drivers/mtd/nand/raw/tango_nand.c +0
-0
drivers/mtd/nand/raw/tango_nand.c static int tango_nand_probe(struct platform_device *pdev) · line 665
Quoted 7 lines
drivers/mtd/nand/raw/tango_nand.c +1
-0@@ -659,6 +659,7 @@ static int tango_nand_probe(struct platform_device *pdev) err =chip_init (&pdev->dev, np);if (err) {tango_nand_remove (pdev); +of_node_put (np);return err; } }
Signature · 5 lines
Måns Rullgård ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 7 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return. Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>Acked-by Mans Rullgard <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/