Skip to contentSkip to conversation

Improve whitelist selftest for read-only registers

PATCH In review [email protected] 4 participants 10 messages Jul 12, 2019 – Jul 15, 2019 3 messages not in the archive

lore
Share & tools
lore
#0 lore raw

v2 cover Improve whitelist selftest for read-only registers

From: John Harrison <[email protected]>

Follow up patch to earlier whitelist updates. This series adds some extra sanity checking to the driver and improves the self-test.

v2: Resolved abiguity over meaning of 'rsvd' in read-only mode by removing it. Rebased to newer tree.

John Harrison (3):
drm/i915: Add test for invalid flag bits in whitelist entries drm/i915: Implement read-only support in whitelist selftest drm/i915: Add engine name to workaround debug print

 drivers/gpu/drm/i915/gt/intel_workarounds.c   | 44 +++++++---
 .../gpu/drm/i915/gt/intel_workarounds_types.h |  1 +
 .../gpu/drm/i915/gt/selftest_workarounds.c    | 80 ++++++++++++-------
 drivers/gpu/drm/i915/i915_reg.h               | 12 ++-
 4 files changed, 91 insertions(+), 46 deletions(-)
Signature · 6 lines
2.21.0.5.gaeb582a983

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for Improve whitelist selftest for read-only registers (rev2)

== Series Details ==

== Series Details ==

Series: Improve whitelist selftest for read-only registers (rev2)
URL : https://patchwork.freedesktop.org/series/63102/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6469 -> Patchwork_13634
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/

Known issues
------------

Here are the changes found in Patchwork_13634 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_mmap_gtt@basic-small-bo:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-icl-u3/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][3] ([fdo#107718]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-skl-iommu: [INCOMPLETE][5] ([fdo#111050]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-skl-iommu/igt@i915_selftest@live_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-skl-iommu/igt@i915_selftest@live_contexts.html

* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [DMESG-FAIL][7] ([fdo#111108]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html

* igt@i915_selftest@live_hangcheck:
- fi-icl-u2: [INCOMPLETE][9] ([fdo#107713] / [fdo#108569]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-icl-u2/igt@i915_selftest@live_hangcheck.html

* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-glk-dsi: [DMESG-WARN][11] ([fdo#107732]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-glk-dsi/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-glk-dsi/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-glk-dsi: [TIMEOUT][13] -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-glk-dsi/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-glk-dsi/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108

Participating hosts (53 -> 46)
------------------------------

Missing (7): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-y fi-icl-dsi fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_6469 -> Patchwork_13634

CI_DRM_6469: 67d3a40ce7fe61793ce6f2ce555725c13dd01f2f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5094: d7f140b5b02d054183a74842b4579cf7f5533927 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13634: 4701077862e78a95e041ca698ab5c8210e12acc5 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

4701077862e7 drm/i915: Add engine name to workaround debug print 1c23d7d00d89 drm/i915: Implement read-only support in whitelist selftest 2c166060d840 drm/i915: Add test for invalid flag bits in whitelist entries

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Re: ✓ Fi.CI.BAT: success for Improve whitelist selftest for read-only registers (rev2)

Quoted 96 lines · Patchwork

== Series Details ==

Series: Improve whitelist selftest for read-only registers (rev2)
URL : https://patchwork.freedesktop.org/series/63102/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6469 -> Patchwork_13634
====================================================

Summary
-------

   **SUCCESS**

   No regressions found.

   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/

Known issues
------------

Here are the changes found in Patchwork_13634 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_mmap_gtt@basic-small-bo:

     - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-icl-u3/igt@[email protected]
    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-icl-u3/igt@[email protected]

#### Possible fixes ####

   * igt@gem_exec_suspend@basic-s3:
     - fi-blb-e6850:       [INCOMPLETE][3] ([fdo#107718]) -> [PASS][4]
    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-blb-e6850/igt@[email protected]
    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-blb-e6850/igt@[email protected]

   * igt@i915_selftest@live_contexts:
     - fi-skl-iommu:       [INCOMPLETE][5] ([fdo#111050]) -> [PASS][6]
    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-skl-iommu/igt@i915_selftest@live_contexts.html
    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-skl-iommu/igt@i915_selftest@live_contexts.html

   * igt@i915_selftest@live_execlists:
     - fi-skl-gvtdvm:      [DMESG-FAIL][7] ([fdo#111108]) -> [PASS][8]
    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html

   * igt@i915_selftest@live_hangcheck:
     - fi-icl-u2:          [INCOMPLETE][9] ([fdo#107713] / [fdo#108569]) -> [PASS][10]
    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-icl-u2/igt@i915_selftest@live_hangcheck.html

   * igt@kms_pipe_crc_basic@read-crc-pipe-c:
     - fi-glk-dsi:         [DMESG-WARN][11] ([fdo#107732]) -> [PASS][12]
    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-glk-dsi/igt@[email protected]
    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-glk-dsi/igt@[email protected]

   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
     - fi-glk-dsi:         [TIMEOUT][13] -> [PASS][14] +1 similar issue
    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/fi-glk-dsi/igt@[email protected]
    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/fi-glk-dsi/igt@[email protected]

   
   {name}: This element is suppressed. This means it is ignored when computing
           the status of the difference (SUCCESS, WARNING, or FAILURE).

   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
   [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
   [fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732
   [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
   [fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050
   [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108

Participating hosts (53 -> 46)
------------------------------

Missing (7): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-y fi-icl-dsi fi-bdw-samus

Build changes
-------------

   * Linux: CI_DRM_6469 -> Patchwork_13634

   CI_DRM_6469: 67d3a40ce7fe61793ce6f2ce555725c13dd01f2f @ git://anongit.freedesktop.org/gfx-ci/linux
   IGT_5094: d7f140b5b02d054183a74842b4579cf7f5533927 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_13634: 4701077862e78a95e041ca698ab5c8210e12acc5 @ git://anongit.freedesktop.org/gfx-ci/linux
Quoted 5 lines

== Linux commits ==

4701077862e7 drm/i915: Add engine name to workaround debug print 1c23d7d00d89 drm/i915: Implement read-only support in whitelist selftest 2c166060d840 drm/i915: Add test for invalid flag bits in whitelist entries

Pushed, thanks.

Regards,

Tvrtko

Quoted 9 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#4 lore raw

Re: [PATCH v2 1/3] drm/i915: Add test for invalid flag bits in whitelist entries

Quoted 10 lines · On 12/07/2019 08:07, [email protected] wrote:

From: John Harrison <[email protected]>

As per review feedback by Tvrtko, added a check that no invalid bits are being set in the whitelist flags fields.

Also updated the read/write access definitions to make it clearer that they are an enum field not a set of single bit flags.

You lost all my r-b's.

Regards,

Tvrtko

Quoted 148 lines
---
  drivers/gpu/drm/i915/gt/intel_workarounds.c   | 29 +++++++++++++++----
  .../gpu/drm/i915/gt/selftest_workarounds.c    | 14 ++++++---
  drivers/gpu/drm/i915/i915_reg.h               | 12 ++++++--
  3 files changed, 42 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +23 -6
index 9e069286d3ce..95be0f108f26 100644
@@ -1011,6 +1011,20 @@ bool intel_gt_verify_workarounds(struct intel_gt *gt, const char *from)
  	return wa_list_verify(gt->uncore, &gt->i915->gt_wa_list, from);
  }
 
+static inline bool is_nonpriv_flags_valid(u32 flags)
+{
+	/* Check only valid flag bits are set */
+	if (flags & ~RING_FORCE_TO_NONPRIV_MASK_VALID)
+		return false;
+
+	/* NB: Only 3 out of 4 enum values are valid for access field */
+	if ((flags & RING_FORCE_TO_NONPRIV_ACCESS_MASK) ==
+	    RING_FORCE_TO_NONPRIV_ACCESS_INVALID)
+		return false;
+
+	return true;
+}
+
  static void
  whitelist_reg_ext(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)
  {
@@ -1021,6 +1035,9 @@ whitelist_reg_ext(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)
  	if (GEM_DEBUG_WARN_ON(wal->count >= RING_MAX_NONPRIV_SLOTS))
  		return;
 
+	if (GEM_DEBUG_WARN_ON(!is_nonpriv_flags_valid(flags)))
+		return;
+
  	wa.reg.reg |= flags;
  	_wa_add(wal, &wa);
  }
@@ -1028,7 +1045,7 @@ whitelist_reg_ext(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)
  static void
  whitelist_reg(struct i915_wa_list *wal, i915_reg_t reg)
  {
-	whitelist_reg_ext(wal, reg, RING_FORCE_TO_NONPRIV_RW);
+	whitelist_reg_ext(wal, reg, RING_FORCE_TO_NONPRIV_ACCESS_RW);
  }
 
  static void gen9_whitelist_build(struct i915_wa_list *w)
@@ -1109,7 +1126,7 @@ static void cfl_whitelist_build(struct intel_engine_cs *engine)
  	 *   - PS_DEPTH_COUNT_UDW
  	 */
  	whitelist_reg_ext(w, PS_INVOCATION_COUNT,
-			  RING_FORCE_TO_NONPRIV_RD |
+			  RING_FORCE_TO_NONPRIV_ACCESS_RD |
  			  RING_FORCE_TO_NONPRIV_RANGE_4);
  }
 
@@ -1149,20 +1166,20 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)
  		 *   - PS_DEPTH_COUNT_UDW
  		 */
  		whitelist_reg_ext(w, PS_INVOCATION_COUNT,
-				  RING_FORCE_TO_NONPRIV_RD |
+				  RING_FORCE_TO_NONPRIV_ACCESS_RD |
  				  RING_FORCE_TO_NONPRIV_RANGE_4);
  		break;
 
  	case VIDEO_DECODE_CLASS:
  		/* hucStatusRegOffset */
  		whitelist_reg_ext(w, _MMIO(0x2000 + engine->mmio_base),
-				  RING_FORCE_TO_NONPRIV_RD);
+				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
  		/* hucUKernelHdrInfoRegOffset */
  		whitelist_reg_ext(w, _MMIO(0x2014 + engine->mmio_base),
-				  RING_FORCE_TO_NONPRIV_RD);
+				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
  		/* hucStatus2RegOffset */
  		whitelist_reg_ext(w, _MMIO(0x23B0 + engine->mmio_base),
-				  RING_FORCE_TO_NONPRIV_RD);
+				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
  		break;
 
  	default:
drivers/gpu/drm/i915/gt/selftest_workarounds.c +10 -4
index fa01ea7855de..466dcc8214c3 100644
@@ -397,6 +397,10 @@ static bool wo_register(struct intel_engine_cs *engine, u32 reg)
  	enum intel_platform platform = INTEL_INFO(engine->i915)->platform;
  	int i;
 
+	if ((reg & RING_FORCE_TO_NONPRIV_ACCESS_MASK) ==
+	     RING_FORCE_TO_NONPRIV_ACCESS_WR)
+		return true;
+
  	for (i = 0; i < ARRAY_SIZE(wo_registers); i++) {
  		if (wo_registers[i].platform == platform &&
  		    wo_registers[i].reg == reg)
@@ -408,7 +412,8 @@ static bool wo_register(struct intel_engine_cs *engine, u32 reg)
 
  static bool ro_register(u32 reg)
  {
-	if (reg & RING_FORCE_TO_NONPRIV_RD)
+	if ((reg & RING_FORCE_TO_NONPRIV_ACCESS_MASK) ==
+	     RING_FORCE_TO_NONPRIV_ACCESS_RD)
  		return true;
 
  	return false;
@@ -760,8 +765,8 @@ static int read_whitelisted_registers(struct i915_gem_context *ctx,
  		u64 offset = results->node.start + sizeof(u32) * i;
  		u32 reg = i915_mmio_reg_offset(engine->whitelist.list[i].reg);
 
-		/* Clear RD only and WR only flags */
-		reg &= ~(RING_FORCE_TO_NONPRIV_RD | RING_FORCE_TO_NONPRIV_WR);
+		/* Clear access permission field */
+		reg &= ~RING_FORCE_TO_NONPRIV_ACCESS_MASK;
 
  		*cs++ = srm;
  		*cs++ = reg;
@@ -931,7 +936,8 @@ check_whitelisted_registers(struct intel_engine_cs *engine,
  	for (i = 0; i < engine->whitelist.count; i++) {
  		const struct i915_wa *wa = &engine->whitelist.list[i];
 
-		if (i915_mmio_reg_offset(wa->reg) & RING_FORCE_TO_NONPRIV_RD)
+		if (i915_mmio_reg_offset(wa->reg) &
+		    RING_FORCE_TO_NONPRIV_ACCESS_RD)
  			continue;
 
  		if (!fn(engine, a[i], b[i], wa->reg))
drivers/gpu/drm/i915/i915_reg.h +5 -3
index 3ff659a180e6..e14c9b76c2d0 100644
@@ -2522,13 +2522,19 @@ enum i915_power_well_id {
  #define   RING_WAIT_SEMAPHORE	(1 << 10) /* gen6+ */
 
  #define RING_FORCE_TO_NONPRIV(base, i) _MMIO(((base) + 0x4D0) + (i) * 4)
-#define   RING_FORCE_TO_NONPRIV_RW		(0 << 28)    /* CFL+ & Gen11+ */
-#define   RING_FORCE_TO_NONPRIV_RD		(1 << 28)
-#define   RING_FORCE_TO_NONPRIV_WR		(2 << 28)
+#define   RING_FORCE_TO_NONPRIV_ACCESS_RW	(0 << 28)    /* CFL+ & Gen11+ */
+#define   RING_FORCE_TO_NONPRIV_ACCESS_RD	(1 << 28)
+#define   RING_FORCE_TO_NONPRIV_ACCESS_WR	(2 << 28)
+#define   RING_FORCE_TO_NONPRIV_ACCESS_INVALID	(3 << 28)
+#define   RING_FORCE_TO_NONPRIV_ACCESS_MASK	(3 << 28)
  #define   RING_FORCE_TO_NONPRIV_RANGE_1		(0 << 0)     /* CFL+ & Gen11+ */

drivers/gpu/drm/i915/i915_reg.h enum i915_power_well_id { · line 2540

Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +4 -0
  #define   RING_FORCE_TO_NONPRIV_RANGE_4		(1 << 0)
  #define   RING_FORCE_TO_NONPRIV_RANGE_16	(2 << 0)
  #define   RING_FORCE_TO_NONPRIV_RANGE_64	(3 << 0)
+#define   RING_FORCE_TO_NONPRIV_RANGE_MASK	(3 << 0)
+#define   RING_FORCE_TO_NONPRIV_MASK_VALID	\
+					(RING_FORCE_TO_NONPRIV_RANGE_MASK \
+					| RING_FORCE_TO_NONPRIV_ACCESS_MASK)
  #define   RING_MAX_NONPRIV_SLOTS  12
 
  #define GEN7_TLB_RD_ADDR	_MMIO(0x4700)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#6 lore raw

Re: [PATCH v2 3/3] drm/i915: Add engine name to workaround debug print

Quoted 8 lines · On 12/07/2019 08:07, [email protected] wrote:

From: John Harrison <[email protected]>

There is a debug message in the workaround initialisation path that reports how many entries were added of each type. However, whitelist workarounds exist for multiple engines but the type name is just 'whitelist'. Tvrtko suggested adding the engine name to make the message more useful.

Quoted 4 lines

v2: Updated the similar message in the workaround reset selftest.

Regards,

Tvrtko

Quoted 128 lines
---
  drivers/gpu/drm/i915/gt/intel_workarounds.c     | 15 ++++++++-------
  .../gpu/drm/i915/gt/intel_workarounds_types.h   |  1 +
  drivers/gpu/drm/i915/gt/selftest_workarounds.c  | 17 +++++------------
  3 files changed, 14 insertions(+), 19 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +8 -7
index 95be0f108f26..3b1fc7c8faa8 100644
@@ -50,9 +50,10 @@
   * - Public functions to init or apply the given workaround type.
   */
 
-static void wa_init_start(struct i915_wa_list *wal, const char *name)
+static void wa_init_start(struct i915_wa_list *wal, const char *name, const char *engine_name)
  {
  	wal->name = name;
+	wal->engine_name = engine_name;
  }
 
  #define WA_LIST_CHUNK (1 << 4)
@@ -74,8 +75,8 @@ static void wa_init_finish(struct i915_wa_list *wal)
  	if (!wal->count)
  		return;
 
-	DRM_DEBUG_DRIVER("Initialized %u %s workarounds\n",
-			 wal->wa_count, wal->name);
+	DRM_DEBUG_DRIVER("Initialized %u %s workarounds on %s\n",
+			 wal->wa_count, wal->name, wal->engine_name);
  }
 
  static void _wa_add(struct i915_wa_list *wal, const struct i915_wa *wa)
@@ -591,7 +592,7 @@ __intel_engine_init_ctx_wa(struct intel_engine_cs *engine,
  	if (engine->class != RENDER_CLASS)
  		return;
 
-	wa_init_start(wal, name);
+	wa_init_start(wal, name, engine->name);
 
  	if (IS_GEN(i915, 11))
  		icl_ctx_workarounds_init(engine, wal);
@@ -921,7 +922,7 @@ void intel_gt_init_workarounds(struct drm_i915_private *i915)
  {
  	struct i915_wa_list *wal = &i915->gt_wa_list;
 
-	wa_init_start(wal, "GT");
+	wa_init_start(wal, "GT", "global");
  	gt_init_workarounds(i915, wal);
  	wa_init_finish(wal);
  }
@@ -1192,7 +1193,7 @@ void intel_engine_init_whitelist(struct intel_engine_cs *engine)
  	struct drm_i915_private *i915 = engine->i915;
  	struct i915_wa_list *w = &engine->whitelist;
 
-	wa_init_start(w, "whitelist");
+	wa_init_start(w, "whitelist", engine->name);
 
  	if (IS_GEN(i915, 11))
  		icl_whitelist_build(engine);
@@ -1384,7 +1385,7 @@ void intel_engine_init_workarounds(struct intel_engine_cs *engine)
  	if (INTEL_GEN(engine->i915) < 8)
  		return;
 
-	wa_init_start(wal, engine->name);
+	wa_init_start(wal, "engine", engine->name);
  	engine_init_workarounds(engine, wal);
  	wa_init_finish(wal);
  }
drivers/gpu/drm/i915/gt/intel_workarounds_types.h +1 -0
index 42ac1fb99572..e27ab1b710b3 100644
@@ -20,6 +20,7 @@ struct i915_wa {
 
  struct i915_wa_list {
  	const char	*name;
+	const char	*engine_name;
  	struct i915_wa	*list;
  	unsigned int	count;
  	unsigned int	wa_count;
drivers/gpu/drm/i915/gt/selftest_workarounds.c +3 -10
index fd1d47ba4b10..a0d8f1bfe0ad 100644
@@ -25,11 +25,9 @@ static const struct wo_register {
  	{ INTEL_GEMINILAKE, 0x731c }
  };
 
-#define REF_NAME_MAX (INTEL_ENGINE_CS_MAX_NAME + 8)
  struct wa_lists {
  	struct i915_wa_list gt_wa_list;
  	struct {
-		char name[REF_NAME_MAX];
  		struct i915_wa_list wa_list;
  		struct i915_wa_list ctx_wa_list;
  	} engine[I915_NUM_ENGINES];
@@ -43,25 +41,20 @@ reference_lists_init(struct drm_i915_private *i915, struct wa_lists *lists)
 
  	memset(lists, 0, sizeof(*lists));
 
-	wa_init_start(&lists->gt_wa_list, "GT_REF");
+	wa_init_start(&lists->gt_wa_list, "GT_REF", "global");
  	gt_init_workarounds(i915, &lists->gt_wa_list);
  	wa_init_finish(&lists->gt_wa_list);
 
  	for_each_engine(engine, i915, id) {
  		struct i915_wa_list *wal = &lists->engine[id].wa_list;
-		char *name = lists->engine[id].name;
 
-		snprintf(name, REF_NAME_MAX, "%s_REF", engine->name);
-
-		wa_init_start(wal, name);
+		wa_init_start(wal, "REF", engine->name);
  		engine_init_workarounds(engine, wal);
  		wa_init_finish(wal);
 
-		snprintf(name, REF_NAME_MAX, "%s_CTX_REF", engine->name);
-
  		__intel_engine_init_ctx_wa(engine,
  					   &lists->engine[id].ctx_wa_list,
-					   name);
+					   "CTX_REF");
  	}
  }
 

drivers/gpu/drm/i915/gt/selftest_workarounds.c static int check_whitelist_across_reset(struct intel_engine_cs *engine, · line 292

Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_workarounds.c +2 -2
@@ -292,8 +285,8 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
  	intel_wakeref_t wakeref;
  	int err;
 
-	pr_info("Checking %d whitelisted registers (RING_NONPRIV) [%s]\n",
-		engine->whitelist.count, name);
+	pr_info("Checking %d whitelisted registers on %s (RING_NONPRIV) [%s]\n",
+		engine->whitelist.count, engine->name, name);
 
  	ctx = kernel_context(i915);
  	if (IS_ERR(ctx))

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#8 lore raw

Re: [PATCH v2 2/3] drm/i915: Implement read-only support in whitelist selftest

Quoted 8 lines · On 12/07/2019 08:07, [email protected] wrote:

From: John Harrison <[email protected]>

Newer hardware supports extra feature in the whitelist registers. This patch updates the selftest to test that entries marked as read only are actually read only.

v2: Removed all use of 'rsvd' for read-only registers to avoid ambiguous code or error messages.

Regards,

Tvrtko

Quoted 98 lines
---
  .../gpu/drm/i915/gt/selftest_workarounds.c    | 49 +++++++++++++------
  1 file changed, 35 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/gt/selftest_workarounds.c +31 -13
index 466dcc8214c3..fd1d47ba4b10 100644
@@ -485,12 +485,12 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,
  		u32 srm, lrm, rsvd;
  		u32 expect;
  		int idx;
+		bool ro_reg;
 
  		if (wo_register(engine, reg))
  			continue;
 
-		if (ro_register(reg))
-			continue;
+		ro_reg = ro_register(reg);
 
  		srm = MI_STORE_REGISTER_MEM;
  		lrm = MI_LOAD_REGISTER_MEM;
@@ -591,24 +591,35 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,
  		}
 
  		GEM_BUG_ON(values[ARRAY_SIZE(values) - 1] != 0xffffffff);
-		rsvd = results[ARRAY_SIZE(values)]; /* detect write masking */
-		if (!rsvd) {
-			pr_err("%s: Unable to write to whitelisted register %x\n",
-			       engine->name, reg);
-			err = -EINVAL;
-			goto out_unpin;
+		if (!ro_reg) {
+			/* detect write masking */
+			rsvd = results[ARRAY_SIZE(values)];
+			if (!rsvd) {
+				pr_err("%s: Unable to write to whitelisted register %x\n",
+				       engine->name, reg);
+				err = -EINVAL;
+				goto out_unpin;
+			}
  		}
 
  		expect = results[0];
  		idx = 1;
  		for (v = 0; v < ARRAY_SIZE(values); v++) {
-			expect = reg_write(expect, values[v], rsvd);
+			if (ro_reg)
+				expect = results[0];
+			else
+				expect = reg_write(expect, values[v], rsvd);
+
  			if (results[idx] != expect)
  				err++;
  			idx++;
  		}
  		for (v = 0; v < ARRAY_SIZE(values); v++) {
-			expect = reg_write(expect, ~values[v], rsvd);
+			if (ro_reg)
+				expect = results[0];
+			else
+				expect = reg_write(expect, ~values[v], rsvd);
+
  			if (results[idx] != expect)
  				err++;
  			idx++;
@@ -617,15 +628,22 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,
  			pr_err("%s: %d mismatch between values written to whitelisted register [%x], and values read back!\n",
  			       engine->name, err, reg);
 
-			pr_info("%s: Whitelisted register: %x, original value %08x, rsvd %08x\n",
-				engine->name, reg, results[0], rsvd);
+			if (ro_reg)
+				pr_info("%s: Whitelisted read-only register: %x, original value %08x\n",
+					engine->name, reg, results[0]);
+			else
+				pr_info("%s: Whitelisted register: %x, original value %08x, rsvd %08x\n",
+					engine->name, reg, results[0], rsvd);
 
  			expect = results[0];
  			idx = 1;
  			for (v = 0; v < ARRAY_SIZE(values); v++) {
  				u32 w = values[v];
 
-				expect = reg_write(expect, w, rsvd);
+				if (ro_reg)
+					expect = results[0];
+				else
+					expect = reg_write(expect, w, rsvd);
  				pr_info("Wrote %08x, read %08x, expect %08x\n",
  					w, results[idx], expect);
  				idx++;
@@ -633,7 +651,10 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,
  			for (v = 0; v < ARRAY_SIZE(values); v++) {

drivers/gpu/drm/i915/gt/selftest_workarounds.c static int check_dirty_whitelist(struct i915_gem_context *ctx, · line 660

Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_workarounds.c +4 -1
  				u32 w = ~values[v];
 
-				expect = reg_write(expect, w, rsvd);
+				if (ro_reg)
+					expect = results[0];
+				else
+					expect = reg_write(expect, w, rsvd);
  				pr_info("Wrote %08x, read %08x, expect %08x\n",
  					w, results[idx], expect);
  				idx++;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

Re: [PATCH v2 2/3] drm/i915: Implement read-only support in whitelist selftest

In reply to a message not in the archive
Quoted 8 lines · On 12/07/2019 08:07, [email protected] wrote:

From: John Harrison <[email protected]>

Newer hardware supports extra feature in the whitelist registers. This patch updates the selftest to test that entries marked as read only are actually read only.

v2: Removed all use of 'rsvd' for read-only registers to avoid ambiguous code or error messages.

Work's never done. :) You can follow up with a patch which adds engine looping to live_reset_whitelist.

I was looking at your test results and wondering why no new whitelists:

<6> [486.665700] i915: Running intel_workarounds_live_selftests/live_reset_whitelist <6> [486.665706] Checking 4 whitelisted registers on rcs0 (RING_NONPRIV) [engine] <7> [486.666281] [drm:intel_power_well_enable [i915]] enabling always-on <5> [486.668777] i915 0000:00:02.0: Resetting rcs0 for live_workarounds <6> [486.669900] Checking 4 whitelisted registers on rcs0 (RING_NONPRIV) [device] <5> [486.671042] i915 0000:00:02.0: Resetting chip for live_workarounds

Regards,

Tvrtko

Quoted 98 lines
---
  .../gpu/drm/i915/gt/selftest_workarounds.c    | 49 +++++++++++++------
  1 file changed, 35 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/gt/selftest_workarounds.c +31 -13
index 466dcc8214c3..fd1d47ba4b10 100644
@@ -485,12 +485,12 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,
  		u32 srm, lrm, rsvd;
  		u32 expect;
  		int idx;
+		bool ro_reg;
 
  		if (wo_register(engine, reg))
  			continue;
 
-		if (ro_register(reg))
-			continue;
+		ro_reg = ro_register(reg);
 
  		srm = MI_STORE_REGISTER_MEM;
  		lrm = MI_LOAD_REGISTER_MEM;
@@ -591,24 +591,35 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,
  		}
 
  		GEM_BUG_ON(values[ARRAY_SIZE(values) - 1] != 0xffffffff);
-		rsvd = results[ARRAY_SIZE(values)]; /* detect write masking */
-		if (!rsvd) {
-			pr_err("%s: Unable to write to whitelisted register %x\n",
-			       engine->name, reg);
-			err = -EINVAL;
-			goto out_unpin;
+		if (!ro_reg) {
+			/* detect write masking */
+			rsvd = results[ARRAY_SIZE(values)];
+			if (!rsvd) {
+				pr_err("%s: Unable to write to whitelisted register %x\n",
+				       engine->name, reg);
+				err = -EINVAL;
+				goto out_unpin;
+			}
  		}
 
  		expect = results[0];
  		idx = 1;
  		for (v = 0; v < ARRAY_SIZE(values); v++) {
-			expect = reg_write(expect, values[v], rsvd);
+			if (ro_reg)
+				expect = results[0];
+			else
+				expect = reg_write(expect, values[v], rsvd);
+
  			if (results[idx] != expect)
  				err++;
  			idx++;
  		}
  		for (v = 0; v < ARRAY_SIZE(values); v++) {
-			expect = reg_write(expect, ~values[v], rsvd);
+			if (ro_reg)
+				expect = results[0];
+			else
+				expect = reg_write(expect, ~values[v], rsvd);
+
  			if (results[idx] != expect)
  				err++;
  			idx++;
@@ -617,15 +628,22 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,
  			pr_err("%s: %d mismatch between values written to whitelisted register [%x], and values read back!\n",
  			       engine->name, err, reg);
 
-			pr_info("%s: Whitelisted register: %x, original value %08x, rsvd %08x\n",
-				engine->name, reg, results[0], rsvd);
+			if (ro_reg)
+				pr_info("%s: Whitelisted read-only register: %x, original value %08x\n",
+					engine->name, reg, results[0]);
+			else
+				pr_info("%s: Whitelisted register: %x, original value %08x, rsvd %08x\n",
+					engine->name, reg, results[0], rsvd);
 
  			expect = results[0];
  			idx = 1;
  			for (v = 0; v < ARRAY_SIZE(values); v++) {
  				u32 w = values[v];
 
-				expect = reg_write(expect, w, rsvd);
+				if (ro_reg)
+					expect = results[0];
+				else
+					expect = reg_write(expect, w, rsvd);
  				pr_info("Wrote %08x, read %08x, expect %08x\n",
  					w, results[idx], expect);
  				idx++;
@@ -633,7 +651,10 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,
  			for (v = 0; v < ARRAY_SIZE(values); v++) {

drivers/gpu/drm/i915/gt/selftest_workarounds.c static int check_dirty_whitelist(struct i915_gem_context *ctx, · line 660

Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_workarounds.c +4 -1
  				u32 w = ~values[v];
 
-				expect = reg_write(expect, w, rsvd);
+				if (ro_reg)
+					expect = results[0];
+				else
+					expect = reg_write(expect, w, rsvd);
  				pr_info("Wrote %08x, read %08x, expect %08x\n",
  					w, results[idx], expect);
  				idx++;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

Re: [PATCH v2 2/3] drm/i915: Implement read-only support in whitelist selftest

Quoted 10 lines · Tvrtko Ursulin
Quoted 8 lines · On 12/07/2019 08:07, [email protected] wrote:

From: John Harrison <[email protected]>

Newer hardware supports extra feature in the whitelist registers. This patch updates the selftest to test that entries marked as read only are actually read only.

v2: Removed all use of 'rsvd' for read-only registers to avoid ambiguous code or error messages.

Work's never done. :) You can follow up with a patch which adds engine looping to live_reset_whitelist.

There is _always_ something more to be done!

I noticed that Lionel added usage of the RANGE field too. There needs to be looping support added for that. At the moment, the self-test simply masks off the range bits and ignores them. It really should be updated to test the entire range.

Lionel, any chance you would have time to pick up these extra changes?

Thanks,
John.

Quoted 10 lines

I was looking at your test results and wondering why no new whitelists:

<6> [486.665700] i915: Running intel_workarounds_live_selftests/live_reset_whitelist <6> [486.665706] Checking 4 whitelisted registers on rcs0 (RING_NONPRIV) [engine] <7> [486.666281] [drm:intel_power_well_enable [i915]] enabling always-on <5> [486.668777] i915 0000:00:02.0: Resetting rcs0 for live_workarounds <6> [486.669900] Checking 4 whitelisted registers on rcs0 (RING_NONPRIV) [device] <5> [486.671042] i915 0000:00:02.0: Resetting chip for live_workarounds

Quoted 4 lines

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

Re: [PATCH v2 2/3] drm/i915: Implement read-only support in whitelist selftest

Quoted 10 lines · John Harrison
Quoted 9 lines · Tvrtko Ursulin
Quoted 8 lines · On 12/07/2019 08:07, [email protected] wrote:

From: John Harrison <[email protected]>

Newer hardware supports extra feature in the whitelist registers. This patch updates the selftest to test that entries marked as read only are actually read only.

v2: Removed all use of 'rsvd' for read-only registers to avoid ambiguous code or error messages.

Quoted 7 lines
Quoted 1 line

Work's never done. :) You can follow up with a patch which adds engine looping to live_reset_whitelist.

There is _always_ something more to be done!

I noticed that Lionel added usage of the RANGE field too. There needs to be looping support added for that. At the moment, the self-test simply masks off the range bits and ignores them. It really should be updated to test the entire range.

Lionel, any chance you would have time to pick up these extra changes?

Unlikely in the next week or 2 :(

-Lionel

Quoted 20 lines

Thanks,
John.

Quoted 14 lines

I was looking at your test results and wondering why no new whitelists:

<6> [486.665700] i915: Running intel_workarounds_live_selftests/live_reset_whitelist <6> [486.665706] Checking 4 whitelisted registers on rcs0 (RING_NONPRIV) [engine] <7> [486.666281] [drm:intel_power_well_enable [i915]] enabling always-on <5> [486.668777] i915 0000:00:02.0: Resetting rcs0 for live_workarounds <6> [486.669900] Checking 4 whitelisted registers on rcs0 (RING_NONPRIV) [device] <5> [486.671042] i915 0000:00:02.0: Resetting chip for live_workarounds

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

✓ Fi.CI.IGT: success for Improve whitelist selftest for read-only registers (rev2)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Improve whitelist selftest for read-only registers (rev2)
URL : https://patchwork.freedesktop.org/series/63102/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6469_full -> Patchwork_13634_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_13634_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@vecs0-s3:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-skl8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-skl9/igt@[email protected]

* igt@gem_tiled_pread_pwrite:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#109100])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-iclb6/igt@gem_tiled_pread_pwrite.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-iclb7/igt@gem_tiled_pread_pwrite.html

* igt@i915_pm_rpm@i2c:
- shard-hsw: [PASS][5] -> [FAIL][6] ([fdo#104097])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-hsw1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-hsw5/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#105363])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-skl1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-skl4/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([fdo#107713] / [fdo#109507])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-iclb1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([fdo#104108] / [fdo#106978])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-skl2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-skl6/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-iclb3/igt@kms_psr@psr2_sprite_blt.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][15] -> [FAIL][16] ([fdo#99912])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-apl4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-apl8/igt@[email protected]

#### Possible fixes ####

* igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen:
- shard-apl: [FAIL][17] ([fdo#103232]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-apl1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-apl8/igt@[email protected]

* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [FAIL][19] ([fdo#100368]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-skl5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-skl5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][21] ([fdo#103167]) -> [PASS][22] +7 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][23] ([fdo#108566]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-apl5/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-apl1/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][25] ([fdo#103166]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-iclb5/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-iclb8/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][27] ([fdo#109441]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-iclb8/igt@kms_psr@psr2_basic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-iclb2/igt@kms_psr@psr2_basic.html

* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-skl: [INCOMPLETE][29] ([fdo#104108]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6469/shard-skl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/shard-skl4/igt@[email protected]

[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_6469 -> Patchwork_13634

CI_DRM_6469: 67d3a40ce7fe61793ce6f2ce555725c13dd01f2f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5094: d7f140b5b02d054183a74842b4579cf7f5533927 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13634: 4701077862e78a95e041ca698ab5c8210e12acc5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13634/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx