Skip to contentSkip to conversation

staging: iio: ad7192: create of_device_id array

PATCH In review Bárbara Fernandes 2 participants 2 messages Jun 28, 2019 – Jul 14, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: iio: ad7192: create of_device_id array

Create list of compatible device ids to be matched with those stated in the device tree.

Co-developed by: Wilson Sales <[email protected]>

---
 drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/staging/iio/adc/ad7192.c +12 -0
index 3d74da9d37e7..70118db98d94 100644
@@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
 	{"ad7195", ID_AD7195},
 	{}
 };
+
 MODULE_DEVICE_TABLE(spi, ad7192_id);
 
+static const struct of_device_id ad7192_of_match[] = {
+	{ .compatible = "adi,ad7190" },
+	{ .compatible = "adi,ad7192" },
+	{ .compatible = "adi,ad7193" },
+	{ .compatible = "adi,ad7195" },
+	{}
+};
+
+MODULE_DEVICE_TABLE(of, ad7192_of_match);
+
 static struct spi_driver ad7192_driver = {
 	.driver = {
 		.name	= "ad7192",
+		.of_match_table = ad7192_of_match,
 	},
 	.probe		= ad7192_probe,
 	.remove		= ad7192_remove,
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 7 lines · On Fri, 28 Jun 2019 16:49:22 -0300 Bárbara Fernandes…

Create list of compatible device ids to be matched with those stated in the device tree.

Co-developed by: Wilson Sales <[email protected]>
---

Patch is fine and applied to the togreg branch of iio.git.

Only thing to note is that reviewers and maintainers often have poor memories (or are jet lagged which is my excuse today!) so it helps to put a change log here under the ---

Thanks,

Jonathan

Quoted 31 lines
 drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/staging/iio/adc/ad7192.c +12 -0
index 3d74da9d37e7..70118db98d94 100644
@@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
 	{"ad7195", ID_AD7195},
 	{}
 };
+
 MODULE_DEVICE_TABLE(spi, ad7192_id);
 
+static const struct of_device_id ad7192_of_match[] = {
+	{ .compatible = "adi,ad7190" },
+	{ .compatible = "adi,ad7192" },
+	{ .compatible = "adi,ad7193" },
+	{ .compatible = "adi,ad7195" },
+	{}
+};
+
+MODULE_DEVICE_TABLE(of, ad7192_of_match);
+
 static struct spi_driver ad7192_driver = {
 	.driver = {
 		.name	= "ad7192",
+		.of_match_table = ad7192_of_match,
 	},
 	.probe		= ad7192_probe,
 	.remove		= ad7192_remove,