webkitgtk: set incomptible with tune mips

PATCH In review [email protected] 2 participants 10 messages Jul 15, 2019 – Jul 17, 2019

lore

Share & tools

lore

[email protected]

author

2019-07-15 10:20 UTC #0 lore raw

PATCH 1/1 webkitgtk: set incomptible with tune mips

From: Kai Kang <[email protected]>

It fails to compile webkit when default tune is 'mips':

| .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
| /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
| error: static assertion failed: CLZ opcode is not available for this ISA

So don't build webkit when default tune is mips.

Signed-off-by Kai Kang <[email protected]>

---
 meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
 1 file changed, 2 insertions(+)

meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +2 -0

index 056334fff5..891266b220 100644
@@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
 	   gettext-native glib-2.0 glib-2.0-native libtasn1 \
           "
 
+COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null', 'mips.*-linux', d)}"
+
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'wayland' ,d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl opengl', '' ,d)} \
                    enchant \

Signature · 1 line

2.20.0

Khem Raj

2019-07-16 07:20 UTC #1 lore raw

Quoted 21 lines · On Mon, Jul 15, 2019 at 3:21 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>
It fails to compile webkit when default tune is 'mips':
| .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
| /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
| error: static assertion failed: CLZ opcode is not available for this ISA
So don't build webkit when default tune is mips.
Signed-off-by Kai Kang <[email protected]>
---
 meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
index 056334fff5..891266b220 100644

meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \ · line 47

Quoted 5 lines

meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +2 -0

@@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
           gettext-native glib-2.0 glib-2.0-native libtasn1 \
           "
 
+COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null', 'mips.*-linux', d)}"
+

this disables is for all kind of mips. I think thats a broad set, it would be best to narrow it to what you saw it failing for e.g. it should work for mips32 and mips64 so maybe mips1 is what you want to disable for

Quoted 11 lines

meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -1
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'wayland' ,d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl opengl', '' ,d)} \
                    enchant \
--
2.20.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Kang Kai

author

2019-07-16 09:33 UTC #2 lore raw

Quoted 24 lines · Khem Raj

Quoted 23 lines · On Mon, Jul 15, 2019 at 3:21 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
It fails to compile webkit when default tune is 'mips':
| .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
| /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
| error: static assertion failed: CLZ opcode is not available for this ISA
So don't build webkit when default tune is mips.
Signed-off-by Kai Kang <[email protected]>
---
  meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
  1 file changed, 2 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
index 056334fff5..891266b220 100644
@@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
            gettext-native glib-2.0 glib-2.0-native libtasn1 \
            "
 

Quoted 6 lines

meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \ · line 47
Quoted 2 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +2 -0
+COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null', 'mips.*-linux', d)}"
+
this disables is for all kind of mips. I think thats a broad set, it would be best to narrow it to what you saw it failing for e.g. it should work for mips32 and mips64 so maybe mips1 is what you want to disable for

I tested with qemumips and qemumips64. When set

DEFAULTTUNE= "mips"

It fails with the error.

Regards,
Kai

Quoted 13 lines

Quoted 13 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -1
  PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'wayland' ,d)} \
                     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl opengl', '' ,d)} \
                     enchant \
--
2.20.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line

Kai Kang

Khem Raj

2019-07-16 15:33 UTC #3 lore raw

Quoted 31 lines · Kang Kai

Quoted 8 lines · Khem Raj
Quoted 7 lines · On Mon, Jul 15, 2019 at 3:21 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
It fails to compile webkit when default tune is 'mips':
| .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
| /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
| error: static assertion failed: CLZ opcode is not available for this
ISA
Quoted 9 lines
Review
Quoted 9 lines
So don't build webkit when default tune is mips.
Signed-off-by Kai Kang <[email protected]>
---
  meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
  1 file changed, 2 insertions(+)
(quoted diff) +0 -0
b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo
Quoted 4 lines
index 056334fff5..891266b220 100644
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
@@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo
libxslt libxt libidn libgcrypt \
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +1 -0
            gettext-native glib-2.0 glib-2.0-native libtasn1 \
            "
 
+COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE',
'mips', 'null', 'mips.*-linux', d)}"
Quoted 1 line
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +1 -0
+

Quoted 8 lines

Quoted 4 lines
this disables is for all kind of mips. I think thats a broad set, it would be best to narrow it to what you saw it failing for e.g. it should work for mips32 and mips64 so maybe mips1 is what you want to disable for
I tested with qemumips and qemumips64. When set
DEFAULTTUNE= "mips"

How about using mips32 and mips64 for default tune and retest

Quoted 28 lines

It fails with the error.
Regards,
Kai
Quoted 3 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo · line 48
Quoted 3 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
  PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
'x11', 'wayland' ,d)} \
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo · line 49
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
                     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
'webgl opengl', '' ,d)} \
Quoted 9 lines
Quoted 9 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -1
                     enchant \
--
2.20.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Kai Kang

Kang Kai

author

2019-07-17 05:42 UTC #4 lore raw

Quoted 55 lines · Khem Raj

On Tue, Jul 16, 2019 at 2:33 AM Kang Kai <[email protected] <mailto:[email protected]>> wrote:

    On 2019/7/16 下午3:19, Khem Raj wrote:
    > On Mon, Jul 15, 2019 at 3:21 AM <[email protected]
    <mailto:[email protected]>> wrote:
    >> From: Kai Kang <[email protected]
    <mailto:[email protected]>>
    >>
    >> It fails to compile webkit when default tune is 'mips':
    >>
    >> |
    .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
    >> | /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
    >> | error: static assertion failed: CLZ opcode is not available
    for this ISA
    >>
    >> So don't build webkit when default tune is mips.
    >>
    >> Signed-off-by: Kai Kang <[email protected]
    <mailto:[email protected]>>
    >> ---
    >>   meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
    <http://webkitgtk_2.24.2.bb> | 2 ++
    >>   1 file changed, 2 insertions(+)
    >>
    >> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
    <http://webkitgtk_2.24.2.bb>
    b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
    <http://webkitgtk_2.24.2.bb>
    >> index 056334fff5..891266b220 100644
    >> --- a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
    <http://webkitgtk_2.24.2.bb>
    >> +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
    <http://webkitgtk_2.24.2.bb>
    >> @@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2
    cairo libxslt libxt libidn libgcrypt \
    >>             gettext-native glib-2.0 glib-2.0-native libtasn1 \
    >>             "
    >>
    >> +COMPATIBLE_HOST_mipsarch =
    "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null',
    'mips.*-linux', d)}"
    >> +
    > this disables is for all kind of mips. I think thats a broad set, it
    > would be best to narrow it to what you saw it failing for
    > e.g. it should work for mips32 and mips64 so maybe mips1 is what you
    > want to disable for

    I tested with qemumips and qemumips64. When set

    DEFAULTTUNE= "mips"

Quoted 1 line

How about using mips32 and mips64 for default tune and retest

It build webkitgtk successfully on qemumips and qemumips64 with default tune mips32 and mips64.

Quoted 28 lines


    It fails with the error.

    Regards,
    Kai

    >
    >
    >>   PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES',
    'x11', 'x11', 'wayland' ,d)} \
    >> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl
    opengl', '' ,d)} \
    >>                      enchant \
    >> --
    >> 2.20.0
    >>
    >> --
    >> _______________________________________________
    >> Openembedded-core mailing list
    >> [email protected]
    <mailto:[email protected]>
    >> http://lists.openembedded.org/mailman/listinfo/openembedded-core


    -- 
    Kai Kang

Signature · 1 line

Kai Kang

Khem Raj

2019-07-17 06:20 UTC #5 lore raw

Right so we should only disable the tunes which don’t have clz and not all mips as this patch is doing

Quoted 88 lines · Kang Kai

On 2019/7/16 下午11:33, Khem Raj wrote:
Quoted 33 lines · Kang Kai
Quoted 6 lines · Khem Raj
Quoted 5 lines · On Mon, Jul 15, 2019 at 3:21 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
It fails to compile webkit when default tune is 'mips':
|
.../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
Quoted 2 lines
Quoted 2 lines
| /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
| error: static assertion failed: CLZ opcode is not available for this
ISA
Quoted 9 lines
Review
Quoted 9 lines
So don't build webkit when default tune is mips.
Signed-off-by Kai Kang <[email protected]>
---
  meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
  1 file changed, 2 insertions(+)
(quoted diff) +0 -0
b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo
Quoted 4 lines
index 056334fff5..891266b220 100644
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
@@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo
libxslt libxt libidn libgcrypt \
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +1 -0
            gettext-native glib-2.0 glib-2.0-native libtasn1 \
            "
 
+COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE',
'mips', 'null', 'mips.*-linux', d)}" <$%[email protected]('DEFAULTTUNE','mips','null','mips.*-linux',d)%7D>
Quoted 1 line
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +1 -0
+
Quoted 8 lines
Quoted 4 lines
this disables is for all kind of mips. I think thats a broad set, it would be best to narrow it to what you saw it failing for e.g. it should work for mips32 and mips64 so maybe mips1 is what you want to disable for
I tested with qemumips and qemumips64. When set
DEFAULTTUNE= "mips"
How about using mips32 and mips64 for default tune and retest
It build webkitgtk successfully on qemumips and qemumips64 with default tune mips32 and mips64.
Quoted 23 lines
It fails with the error.
Regards,
Kai
Quoted 3 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo · line 48
Quoted 3 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
  PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
'x11', 'wayland' ,d)} \
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo · line 49
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
                     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
'webgl opengl', '' ,d)} \
Quoted 9 lines
Quoted 9 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -1
                     enchant \
--
2.20.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 4 lines
--
Kai Kang
--
Kai Kang

Kang Kai

author

2019-07-17 06:51 UTC #6 lore raw

Quoted 1 line · Khem Raj

Right so we should only disable the tunes which don’t have clz and not all mips as this patch is doing

The patch only set COMPATILE_HOST to null only when default tune is 'mips' which causes webkitgtk fails.
And for other conditions, it doesn't block to build that the COMPATILE_HOST is 'mips.*-linux'. <mailto:$%[email protected]('DEFAULTTUNE','mips','null','mips.*-linux',d)%7D>Such as the default bsps qemumips(default tune mips32r2) and qemumips64(mips64r2), it doesn't affect them.

Kai

Quoted 105 lines · On Tue, Jul 16, 2019 at 10:42 PM Kang Kai <[email protected]…

    On 2019/7/16 下午11:33, Khem Raj wrote:

Quoted 53 lines


    On Tue, Jul 16, 2019 at 2:33 AM Kang Kai <[email protected]
    <mailto:[email protected]>> wrote:

        On 2019/7/16 下午3:19, Khem Raj wrote:
        > On Mon, Jul 15, 2019 at 3:21 AM <[email protected]
        <mailto:[email protected]>> wrote:
        >> From: Kai Kang <[email protected]
        <mailto:[email protected]>>
        >>
        >> It fails to compile webkit when default tune is 'mips':
        >>
        >> |
        .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
        >> |
        /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
        >> | error: static assertion failed: CLZ opcode is not
        available for this ISA
        >>
        >> So don't build webkit when default tune is mips.
        >>
        >> Signed-off-by: Kai Kang <[email protected]
        <mailto:[email protected]>>
        >> ---
        >>   meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
        <http://webkitgtk_2.24.2.bb> | 2 ++
        >>   1 file changed, 2 insertions(+)
        >>
        >> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
        <http://webkitgtk_2.24.2.bb>
        b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
        <http://webkitgtk_2.24.2.bb>
        >> index 056334fff5..891266b220 100644
        >> --- a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
        <http://webkitgtk_2.24.2.bb>
        >> +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
        <http://webkitgtk_2.24.2.bb>
        >> @@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2
        cairo libxslt libxt libidn libgcrypt \
        >>             gettext-native glib-2.0 glib-2.0-native libtasn1 \
        >>             "
        >>
        >> +COMPATIBLE_HOST_mipsarch =
        "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null',
        'mips.*-linux', d)}"
        <mailto:$%[email protected]('DEFAULTTUNE','mips','null','mips.*-linux',d)%7D>
        >> +
        > this disables is for all kind of mips. I think thats a
        broad set, it
        > would be best to narrow it to what you saw it failing for
        > e.g. it should work for mips32 and mips64 so maybe mips1 is
        what you

Quoted 8 lines

        > want to disable for

        I tested with qemumips and qemumips64. When set

        DEFAULTTUNE= "mips"


    How about using mips32 and mips64 for default tune and retest

It build webkitgtk successfully on qemumips and qemumips64 with default tune mips32 and mips64.

Quoted 21 lines


        It fails with the error.

        Regards,
        Kai

        >
        >
        >>   PACKAGECONFIG ??=
        "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11',
        'wayland' ,d)} \
        >> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl
        opengl', '' ,d)} \
        >>                      enchant \
        >> --
        >> 2.20.0
        >>
        >> --
        >> _______________________________________________
        >> Openembedded-core mailing list

Quoted 9 lines

        >> [email protected]
        <mailto:[email protected]>
        >>
        http://lists.openembedded.org/mailman/listinfo/openembedded-core


        -- 
        Kai Kang

    -- 
    Kai Kang

Signature · 1 line

Kai Kang

Khem Raj

2019-07-17 08:19 UTC #7 lore raw

oh COMPATIBLE_HOST_mipsarch threw me off. do we need to use the override when the specific check
is done on right hand side?

Quoted 96 lines · Kang Kai

On 2019/7/17 下午2:20, Khem Raj wrote:
Right so we should only disable the tunes which don’t have clz and not all mips as this patch is doing
The patch only set COMPATILE_HOST to null only when default tune is 'mips' which causes webkitgtk fails. And for other conditions, it doesn't block to build that the COMPATILE_HOST is 'mips.*-linux'. Such as the default bsps qemumips(default tune mips32r2) and qemumips64(mips64r2), it doesn't affect them.
Kai
Quoted 72 lines · Kang Kai
On 2019/7/16 下午11:33, Khem Raj wrote:
Quoted 33 lines · Kang Kai
Quoted 24 lines · Khem Raj
Quoted 23 lines · On Mon, Jul 15, 2019 at 3:21 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
It fails to compile webkit when default tune is 'mips':
| .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
| /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
| error: static assertion failed: CLZ opcode is not available for this ISA
So don't build webkit when default tune is mips.
Signed-off-by Kai Kang <[email protected]>
---
  meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
  1 file changed, 2 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
index 056334fff5..891266b220 100644
@@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
            gettext-native glib-2.0 glib-2.0-native libtasn1 \
            "
 
Quoted 6 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \ · line 47
Quoted 2 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +2 -0
+COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null', 'mips.*-linux', d)}"
+
this disables is for all kind of mips. I think thats a broad set, it would be best to narrow it to what you saw it failing for e.g. it should work for mips32 and mips64 so maybe mips1 is what you want to disable for
Quoted 3 lines
I tested with qemumips and qemumips64. When set
DEFAULTTUNE= "mips"
How about using mips32 and mips64 for default tune and retest
It build webkitgtk successfully on qemumips and qemumips64 with default tune mips32 and mips64.
Quoted 22 lines
It fails with the error.
Regards,
Kai
Quoted 13 lines
Quoted 13 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -1
  PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'wayland' ,d)} \
                     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl opengl', '' ,d)} \
                     enchant \
--
2.20.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 6 lines
Quoted 3 lines
--
Kai Kang
--
Kai Kang
--
Kai Kang

Kang Kai

author

2019-07-17 08:25 UTC #8 lore raw

Quoted 3 lines · Khem Raj

oh COMPATIBLE_HOST_mipsarch threw me off. do we need to use the override when the specific check
is done on right hand side?

Regards,
Kai

Quoted 88 lines · Kang Kai

Quoted 86 lines · Khem Raj
Right so we should only disable the tunes which don’t have clz and not all mips as this patch is doing
The patch only set COMPATILE_HOST to null only when default tune is 'mips' which causes webkitgtk fails. And for other conditions, it doesn't block to build that the COMPATILE_HOST is 'mips.*-linux'. Such as the default bsps qemumips(default tune mips32r2) and qemumips64(mips64r2), it doesn't affect them.
Kai
Quoted 65 lines · Kang Kai
On 2019/7/16 下午11:33, Khem Raj wrote:
Quoted 31 lines · Kang Kai
Quoted 24 lines · Khem Raj
Quoted 23 lines · On Mon, Jul 15, 2019 at 3:21 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
It fails to compile webkit when default tune is 'mips':
| .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
| /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
| error: static assertion failed: CLZ opcode is not available for this ISA
So don't build webkit when default tune is mips.
Signed-off-by Kai Kang <[email protected]>
---
   meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
   1 file changed, 2 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
index 056334fff5..891266b220 100644
@@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
             gettext-native glib-2.0 glib-2.0-native libtasn1 \
             "
 
Quoted 6 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \ · line 47
Quoted 2 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +2 -0
+COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null', 'mips.*-linux', d)}"
+
this disables is for all kind of mips. I think thats a broad set, it would be best to narrow it to what you saw it failing for e.g. it should work for mips32 and mips64 so maybe mips1 is what you want to disable for
Quoted 3 lines
I tested with qemumips and qemumips64. When set
DEFAULTTUNE= "mips"
How about using mips32 and mips64 for default tune and retest
It build webkitgtk successfully on qemumips and qemumips64 with default tune mips32 and mips64.
Quoted 19 lines
It fails with the error.
Regards,
Kai
Quoted 12 lines
Quoted 12 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -1
   PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'wayland' ,d)} \
                      ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl opengl', '' ,d)} \
                      enchant \
--
2.20.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 5 lines
Quoted 3 lines
--
Kai Kang
--
Kai Kang
--
Kai Kang

Signature · 1 line

Kai Kang

Khem Raj

2019-07-17 16:30 UTC #9 lore raw

Quoted 10 lines · Kang Kai

Quoted 3 lines · Khem Raj
oh COMPATIBLE_HOST_mipsarch threw me off. do we need to use the override when the specific check
is done on right hand side?
I didn't figure out a better way to reset COMPATIBLE_HOST only for default tune 'mips'. Without override _mipsarch,
I need to list all the COMPATIBLE_HOSTs such as "(i.86|x86_64|arm|aarch64|mips|powerpc|powerpc64).*-linux'" in the *else* part of bb.utils.contains().

You could use (*)

Quoted 115 lines

Regards,
Kai
Quoted 2 lines
On Tue, Jul 16, 2019 at 11:51 PM Kang Kai <[email protected]>
Quoted 3 lines · wrote:
Quoted 3 lines · Khem Raj
Right so we should only disable the tunes which don’t have clz and not
all mips as this patch is doing
Quoted 2 lines
Quoted 2 lines
The patch only set COMPATILE_HOST to null only when default tune is
'mips' which causes webkitgtk fails.
Quoted 1 line
Quoted 1 line
And for other conditions, it doesn't block to build that the
COMPATILE_HOST is 'mips.*-linux'. Such as the
Quoted 1 line
Quoted 1 line
default bsps qemumips(default tune mips32r2) and qemumips64(mips64r2),
it doesn't affect them.
Quoted 6 lines
Quoted 6 lines
Kai
On Tue, Jul 16, 2019 at 10:42 PM Kang Kai <[email protected]>
Quoted 5 lines · wrote:
Quoted 5 lines
Quoted 5 lines · Khem Raj
On Tue, Jul 16, 2019 at 2:33 AM Kang Kai <[email protected]>
Quoted 7 lines · wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines · Khem Raj
Quoted 6 lines · On Mon, Jul 15, 2019 at 3:21 AM <[email protected]> wrote:
Quoted 5 lines
From: Kai Kang <[email protected]>
It fails to compile webkit when default tune is 'mips':
|
.../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
| /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
| error: static assertion failed: CLZ opcode is not available for
this ISA
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Review
Quoted 9 lines
So don't build webkit when default tune is mips.
Signed-off-by Kai Kang <[email protected]>
---
   meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
   1 file changed, 2 insertions(+)
(quoted diff) +0 -0
b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo
Quoted 4 lines
index 056334fff5..891266b220 100644
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
@@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo
libxslt libxt libidn libgcrypt \
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo · line 46
Quoted 4 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +1 -0
             gettext-native glib-2.0 glib-2.0-native libtasn1 \
             "
 
+COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE',
'mips', 'null', 'mips.*-linux', d)}"
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo · line 47
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +1 -0
+
this disables is for all kind of mips. I think thats a broad set, it would be best to narrow it to what you saw it failing for e.g. it should work for mips32 and mips64 so maybe mips1 is what you want to disable for
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
I tested with qemumips and qemumips64. When set
DEFAULTTUNE= "mips"
How about using mips32 and mips64 for default tune and retest
It build webkitgtk successfully on qemumips and qemumips64 with
default tune mips32 and mips64.
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
It fails with the error.
Regards,
Kai
Quoted 2 lines
Quoted 2 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
   PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES',
'x11', 'x11', 'wayland' ,d)} \
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo · line 49
Quoted 1 line
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -0
                      ${@bb.utils.contains('DISTRO_FEATURES',
'opengl', 'webgl opengl', '' ,d)} \
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
Quoted 9 lines
meta/recipes-sato/webkit/webkitgtk_2.24.2.bb +0 -1
                      enchant \
--
2.20.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
--
Kai Kang
--
Kai Kang
--
Kai Kang
--
Kai Kang