ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()
PATCH v2 1/1 ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()
In build_adc_controls(), there is an if statement on line 773 to check whether ak->adc_info is NULL:
if (! ak->adc_info ||
! ak->adc_info[mixer_ch].switch_name)When ak->adc_info is NULL, it is used on line 792:
knew.name = ak->adc_info[mixer_ch].selector_name;
Thus, a possible null-pointer dereference may occur.
To fix this bug, referring to lines 773 and 774, ak->adc_info and ak->adc_info[mixer_ch].selector_name are checked before being used.
This bug is found by a static analysis tool STCheck written by us.
---
v2:
* Fix the errors reported by checkpatch.pl.
Thank Takashi for helpful advice.
--- sound/i2c/other/ak4xxx-adda.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/i2c/other/ak4xxx-adda.c +4 -3
@@ -775,11 +775,12 @@ static int build_adc_controls(struct snd_akm4xxx *ak)return err;memset (&knew,0 ,sizeof (knew)); - knew.name = ak->adc_info[mixer_ch].selector_name; -if (!knew.name) { +if (!ak->adc_info || + !ak->adc_info[mixer_ch].selector_name) { knew.name ="Capture Channel" ; knew.index = mixer_ch + ak->idx_offset *2 ; - } + }else + knew.name = ak->adc_info[mixer_ch].selector_name; knew.iface =SNDRV_CTL_ELEM_IFACE_MIXER ; knew.info = ak4xxx_capture_source_info;
Signature · 1 line
2.17.0
Takashi Iwai
AppliedQuoted 9 lines · Jia-Ju Bai
In
build_adc_controls(), there is an if statement on line 773 to check whetherak->adc_infois NULL:if (! ak->adc_info || ! ak->adc_info[mixer_ch].switch_name)When
ak->adc_infois NULL, it is used on line 792:knew.name = ak->adc_info[mixer_ch].selector_name;
Quoted 8 lines
Thus, a possible null-pointer dereference may occur.
To fix this bug, referring to lines 773 and 774,
ak->adc_infoand ak->adc_info[mixer_ch].selector_name are checked before being used.This bug is found by a static analysis tool STCheck written by us.
Signed-off-by Jia-Ju Bai <[email protected]>
Applied, thanks.
Takashi