Skip to contentSkip to conversation

ARM: signal: Mark expected switch fall-through

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jul 29, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: signal: Mark expected switch fall-through

Mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

arch/arm/kernel/signal.c: In function 'do_signal':
arch/arm/kernel/signal.c:598:12: warning: this statement may fall through [-Wimplicit-fallthrough=]

    restart -= 2;
    ~~~~~~~~^~~~

arch/arm/kernel/signal.c:599:3: note: here
case -ERESTARTNOHAND:
^~~~

---
 arch/arm/kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/kernel/signal.c +1 -0
index 09f6fdd41974..ab2568996ddb 100644
@@ -596,6 +596,7 @@ static int do_signal(struct pt_regs *regs, int syscall)
 		switch (retval) {
 		case -ERESTART_RESTARTBLOCK:
 			restart -= 2;
+			/* Fall through */
 		case -ERESTARTNOHAND:
 		case -ERESTARTSYS:
 		case -ERESTARTNOINTR:
Signature · 7 lines
2.22.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

Mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

arch/arm/kernel/signal.c: In function 'do_signal':
arch/arm/kernel/signal.c:598:12: warning: this statement may fall through [-Wimplicit-fallthrough=]

Quoted 8 lines
    restart -= 2;
    ~~~~~~~~^~~~
arch/arm/kernel/signal.c:599:3: note: here
   case -ERESTARTNOHAND:
   ^~~~

-Kees

Quoted 19 lines
---
 arch/arm/kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/kernel/signal.c +1 -0
index 09f6fdd41974..ab2568996ddb 100644
@@ -596,6 +596,7 @@ static int do_signal(struct pt_regs *regs, int syscall)
 		switch (retval) {
 		case -ERESTART_RESTARTBLOCK:
 			restart -= 2;
+			/* Fall through */
 		case -ERESTARTNOHAND:
 		case -ERESTARTSYS:
 		case -ERESTARTNOINTR:
Signature · 1 line
2.22.0
Signature · 1 line
Kees Cook