ARM: signal: Mark expected switch fall-through
PATCH 1/1 ARM: signal: Mark expected switch fall-through
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
arch/arm/kernel/signal.c: In function 'do_signal':arch/arm/kernel/signal.c:598:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
restart -= 2;
~~~~~~~~^~~~arch/arm/kernel/signal.c:599:3: note: here
case -ERESTARTNOHAND:
^~~~
Reported-by Stephen Rothwell <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- arch/arm/kernel/signal.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/kernel/signal.c +1 -0
@@ -596,6 +596,7 @@ static int do_signal(struct pt_regs *regs, int syscall)switch (retval) {case -ERESTART_RESTARTBLOCK : restart -=2 ; +/* Fall through */ case -ERESTARTNOHAND :case -ERESTARTSYS :case -ERESTARTNOINTR :
Signature · 7 lines
2.22.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 6 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
arch/arm/kernel/signal.c: In function 'do_signal':arch/arm/kernel/signal.c:598:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 8 lines
restart -= 2; ~~~~~~~~^~~~ arch/arm/kernel/signal.c:599:3: note: here case -ERESTARTNOHAND: ^~~~Reported-by Stephen Rothwell <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Kees Cook <[email protected]>
-Kees
Quoted 19 lines
--- arch/arm/kernel/signal.c | 1 + 1 file changed, 1 insertion(+)arch/arm/kernel/signal.c +1
-0@@ -596,6 +596,7 @@ static int do_signal(struct pt_regs *regs, int syscall)switch (retval) {case -ERESTART_RESTARTBLOCK : restart -=2 ; +/* Fall through */ case -ERESTARTNOHAND :case -ERESTARTSYS :case -ERESTARTNOINTR :Signature · 1 line
2.22.0
Signature · 1 line
Kees Cook