watchdog: alim1535: Rewriting of alim1535 driver to use watchdog subsystem
PATCH v4 1/1 watchdog: alim1535: Rewriting of alim1535 driver to use watchdog subsystem
This patch rewrites the alim1535_wdt driver to use the watchdog subsystem. By virtue of this, it also fixes a (theoretical) race condition between the formerly arranged ali_timeout_bits and ali_settimer() interoperation.
--- drivers/watchdog/Kconfig | 1 + drivers/watchdog/alim1535_wdt.c | 294 ++++++-------------------------- 2 files changed, 50 insertions(+), 245 deletions(-)
drivers/watchdog/Kconfig +1 -0
@@ -853,6 +853,7 @@ config ADVANTECH_WDT config ALIM1535_WDT tristate "ALi M1535 PMU Watchdog Timer" + select WATCHDOG_CORE depends on X86 && PCI ---help--- This is the driver for the hardware watchdog on the ALi M1535 PMU.
drivers/watchdog/alim1535_wdt.c +49 -245
390 lines not on this page · raw message
Signature · 1 line
2.17.1
Quoted 3 lines · Mark Balantzyan
This patch rewrites the
alim1535_wdtdriver to use the watchdog subsystem. By virtue of this, it also fixes a (theoretical) race condition between the formerly arrangedali_timeout_bitsandali_settimer()interoperation.
Please don't rewrite drivers you can't test.
Signature · 1 line
Ondrej Zary
Dear Ondrej,
As advised by another kernel maintainer, patches for antiquated drivers like these (this one which I test-built successfully) should hang around until someone with the hardware volunteers to test it. Therefore, I would provide the software and the individual would serve as the hardware tester with the provided software. So far, I've worked with Guenter Roeck to conform it to the watchdog subsystem. And now I'm letting it sit until someone with the hardware is able to test it.
Thank you,
Mark