Add recipe of xfce4-datetime-setter
cover Add recipe of xfce4-datetime-setter
From: Kai Kang <[email protected]>
Hi Andreas,
I add recipe of xfce4-datetime-setter which is from your repo from github. But I found it requires dbus service org.freedesktop.timedate1 which is from systemd. So make xfce4-settings requires it only when init manger is sytemd. Any comment on that please?
Regards,
Kai
Kai Kang (2):
xfce4-datetime-setter: add recipe
xfce4-settings: rrecommends xfce4-datetime-setter
.../xfce4-datetime-setter_3.32.2.bb | 18 ++++++++++++++++++ .../xfce4-settings/xfce4-settings_4.13.7.bb | 1 + 2 files changed, 19 insertions(+) create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
--
2.20.0
PATCH 1/2 xfce4-datetime-setter: add recipe
From: Kai Kang <[email protected]>
Because xfce4-settings turn back to its official upstream, it missing function to set date and time. Add it from Andreas's repo on github.
--- .../xfce4-datetime-setter_3.32.2.bb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +18 -0
@@ -0,0 +1,18 @@ +DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \ +It is based upon GTK3 and embedds into recent xfce4-settings." +HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e" + +DEPENDS = "glib-2.0-native libxfce4ui" + +SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https" +SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f" + +S = "${WORKDIR}/git" + +inherit gettext meson + +FILES_${PN} += "${datadir}/icons/hicolor" + +RDEPENDS_${PN} = "tzdata"
Signature · 1 line
2.20.0
PATCH 2/2 xfce4-settings: rrecommends xfce4-datetime-setter
In reply to [email protected]From: Kai Kang <[email protected]>
xfce4-datetime-setter provides function to set date and time. But it depends on dbus service org.freedesktop.timedate1 which is provided by systemd. Make xfce4-settings rrecommends xfce4-datetime-setter only systemd is set in DISTRO_FEATURES.
--- meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb | 1 + 1 file changed, 1 insertion(+)
meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb +1 -0
@@ -30,3 +30,4 @@ FILES_${PN} += " \ RRECOMMENDS_${PN} += "adwaita-icon-theme" RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','alsa','libcanberra-alsa','',d)}" RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','pulseaudio','libcanberra-pulse','',d)}" +RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','systemd','xfce4-datetime-setter','',d)}"
Signature · 1 line
2.20.0
Quoted 5 lines · On Wed, Aug 7, 2019 at 7:18 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
Hi Andreas,
Quoted 7 lines
I add recipe of xfce4-datetime-setter which is from your repo from github. But I found it requires dbus service org.freedesktop.timedate1 which is from systemd. So make xfce4-settings requires it only when init manger is sytemd. Any comment on that please?
Regards,
Kai
Hi Kai,
* had short glance on your patches: they look good to me. In the 'old-days' when datetime-setter was part of xfce-settings, there was a packageconfig for it. That was enabled if systemd was in distro features - so your suggestion should behave same.
* thanks for taking care for meta-xfce for very long time now
* would anybody complain making you maintainer of meta-xfce?
Regards
Andreas
Quoted 10 lines · Andreas Müller
Quoted 9 lines · On Wed, Aug 7, 2019 at 7:18 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
Hi Andreas,
I add recipe of xfce4-datetime-setter which is from your repo from github. But I found it requires dbus service org.freedesktop.timedate1 which is from systemd. So make xfce4-settings requires it only when init manger is sytemd. Any comment on that please?
Quoted 8 lines
Quoted 2 lines
Regards,
KaiHi Kai,
* had short glance on your patches: they look good to me. In the 'old-days' when datetime-setter was part of xfce-settings, there was a packageconfig for it. That was enabled if systemd was in distro features - so your suggestion should behave same.
It reminds me that it is better to check distro systemd for xfce4-datetime-setter. v2 will be sent.
Quoted 1 line
* thanks for taking care for meta-xfce for very long time now
My pleasure.
Quoted 1 line
* would anybody complain making you maintainer of meta-xfce?
It will be my honor if I have chance to take more responsibility and contribute more to oe community.
Thanks,
Kai
Quoted 6 lines
Regards
Andreas
Signature · 1 line
Kai Kang
Quoted 27 lines · Kang Kai
Quoted 11 lines · Andreas Müller
Quoted 10 lines · On Wed, Aug 7, 2019 at 7:18 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
Hi Andreas,
I add recipe of xfce4-datetime-setter which is from your repo from github. But I found it requires dbus service org.freedesktop.timedate1 which is from systemd. So make xfce4-settings requires it only when init manger
is sytemd. Any comment on that please?Quoted 8 lines
Quoted 2 lines
Regards,
KaiHi Kai,
* had short glance on your patches: they look good to me. In the 'old-days' when datetime-setter was part of xfce-settings, there was a packageconfig for it. That was enabled if systemd was in distro features - so your suggestion should behave same.
It reminds me that it is better to check distro systemd for xfce4-datetime-setter. v2 will be sent.
Quoted 1 line
* thanks for taking care for meta-xfce for very long time now
Quoted 7 lines
My pleasure.
Quoted 1 line
* would anybody complain making you maintainer of meta-xfce?
It will be my honor if I have chance to take more responsibility and contribute more to oe community.
Thanks for stepping up. It would be good if you can start looking at all the meta-xfce patches, review them and send acks on mailing list, I would look out for those, and eventually prepare a pull request for all meta-xfce patches to be merged.
Quoted 11 lines
Thanks,
KaiQuoted 6 lines
Regards
Andreas
Quoted 30 lines · Khem Raj
Quoted 28 lines · Kang Kai
Quoted 11 lines · Andreas Müller
Quoted 10 lines · On Wed, Aug 7, 2019 at 7:18 AM <[email protected]> wrote:
From: Kai Kang <[email protected]>
Hi Andreas,
I add recipe of xfce4-datetime-setter which is from your repo from github. But I found it requires dbus service org.freedesktop.timedate1 which is from systemd. So make xfce4-settings requires it only when init manger
is sytemd. Any comment on that please?Quoted 8 lines
Quoted 2 lines
Regards,
KaiHi Kai,
* had short glance on your patches: they look good to me. In the 'old-days' when datetime-setter was part of xfce-settings, there was a packageconfig for it. That was enabled if systemd was in distro features - so your suggestion should behave same.
It reminds me that it is better to check distro systemd for xfce4-datetime-setter. v2 will be sent.
Quoted 1 line
* thanks for taking care for meta-xfce for very long time now
My pleasure.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
* would anybody complain making you maintainer of meta-xfce?
It will be my honor if I have chance to take more responsibility and contribute more to oe community.
Thanks for stepping up. It would be good if you can start looking at all the meta-xfce patches, review them and send acks on mailing list, I would look out for those, and eventually prepare a pull request for all meta-xfce patches to be merged.
OK. I'll begin to do this work. Thanks.
Kai.
Quoted 9 lines
Quoted 9 lines
Thanks,
KaiQuoted 5 lines
Regards
Andreas
Signature · 1 line
Kai Kang