Skip to contentSkip to conversation

tools/libxl: Add iothread support for COLO

PATCH In review Zhang Chen 2 participants 4 messages Jul 26, 2019 – Aug 8, 2019

lore
Share & tools
lore

Zhang Chen

author
#0 lore raw

PATCH v4 1/1 tools/libxl: Add iothread support for COLO

From: Zhang Chen <[email protected]>

Xen COLO and KVM COLO shared lots of code in Qemu.
The colo-compare object in Qemu now requires an 'iothread' property since QEMU 2.11.

Detail:
https://wiki.qemu.org/Features/COLO

---
 tools/libxl/libxl_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tools/libxl/libxl_dm.c +3 -1
index f4fc96415d..839c5ac2cd 100644
@@ -1634,8 +1634,10 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
                         nics[i].colo_compare_out &&
                         nics[i].colo_compare_notify_dev) {
                         flexarray_append(dm_args, "-object");
+                        flexarray_append(dm_args, "iothread,id=colo-compare-iothread-1");
+                        flexarray_append(dm_args, "-object");
                         flexarray_append(dm_args,
-                           GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s",
+                           GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s,iothread=colo-compare-iothread-1",
                                      nics[i].colo_compare_pri_in,
                                      nics[i].colo_compare_sec_in,
                                      nics[i].colo_compare_out,
Signature · 7 lines
2.17.GIT


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw

Ping...
Any comments?

Thanks
Zhang Chen

Quoted 45 lines

-----Original Message-----
From: Zhang, Chen
Sent: Saturday, July 27, 2019 12:27 AM
To: Ian Jackson <[email protected]>; Wei Liu <[email protected]>; Anthony PERARD <[email protected]>; [email protected]
Cc: Zhang Chen <[email protected]>; Zhang, Chen <[email protected]>
Subject: [PATCH V4] tools/libxl: Add iothread support for COLO

From: Zhang Chen <[email protected]>

Xen COLO and KVM COLO shared lots of code in Qemu.
The colo-compare object in Qemu now requires an 'iothread' property since QEMU 2.11.

Detail:
https://wiki.qemu.org/Features/COLO

---
 tools/libxl/libxl_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tools/libxl/libxl_dm.c index renamed from tools/libxl/libxl_dm.c +0 -0

f4fc96415d..839c5ac2cd 100644

tools/libxl/libxl_dm.c +5 -2
@@ -1634,8 +1634,10 @@ static int
 libxl__build_device_model_args_new(libxl__gc *gc,
                         nics[i].colo_compare_out &&
                         nics[i].colo_compare_notify_dev) {
                         flexarray_append(dm_args, "-object");
+                        flexarray_append(dm_args, "iothread,id=colo-compare-
 iothread-1");
+                        flexarray_append(dm_args, "-object");
                         flexarray_append(dm_args,
-                           GCSPRINTF("colo-
 compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s",
+
+ GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,
+ notify_dev=%s,iothread=colo-compare-iothread-1",
                                      nics[i].colo_compare_pri_in,
                                      nics[i].colo_compare_sec_in,
                                      nics[i].colo_compare_out,
--
Quoted 1 line

2.17.GIT

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
Quoted 2 lines · Chen

Ping...
Any comments?

For your information, that patch have been pushed, see commit 174db28bb823e8c98c319fdbdc6d4cbe1050ba14 ;-)

Cheers,

Signature · 6 lines
Anthony PERARD

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#3 lore raw

Thank you Anthony PERARD.

Thanks
Zhang Chen

Quoted 12 lines

-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: Thursday, August 8, 2019 5:08 PM
To: Zhang, Chen <[email protected]>
Cc: Ian Jackson <[email protected]>; Wei Liu <[email protected]>; xen- [email protected]; Zhang Chen <[email protected]>
Subject: Re: [PATCH V4] tools/libxl: Add iothread support for COLO

Quoted 2 lines · Chen

Ping...
Any comments?

Quoted 7 lines

For your information, that patch have been pushed, see commit 174db28bb823e8c98c319fdbdc6d4cbe1050ba14 ;-)

Cheers,

--
Anthony PERARD

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel