watchdog: Replace strncmp with str_has_prefix
PATCH v4 8/8 watchdog: Replace strncmp with str_has_prefix
strncmp(str, const, len) is error-prone because len is easy to have typo.
The example is the hard-coded len has counting error or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix() to substitute such strncmp to make code better.
Signed-off-by Chuhong Yuan <[email protected]>
--- kernel/watchdog.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
kernel/watchdog.c +4 -4
@@ -70,13 +70,13 @@ void __init hardlockup_detector_disable(void)static int __init hardlockup_panic_setup (char *str) { -if (!strncmp (str,"panic" ,5 )) +if (str_has_prefix (str,"panic" )) hardlockup_panic =1 ; -else if (!strncmp (str,"nopanic" ,7 )) +else if (str_has_prefix (str,"nopanic" )) hardlockup_panic =0 ; -else if (!strncmp (str,"0" ,1 )) +else if (str_has_prefix (str,"0" )) nmi_watchdog_user_enabled =0 ; -else if (!strncmp (str,"1" ,1 )) +else if (str_has_prefix (str,"1" )) nmi_watchdog_user_enabled =1 ;return 1 ; }
Signature · 1 line
2.20.1