Skip to contentSkip to conversation

package/gstreamer1/gst1-plugins-bad: fix opengl dependency

PATCH New James Hilliard 4 participants 8 messages Aug 7, 2019 – Oct 11, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: fix opengl dependency

Fixes:
WPEThreadedView.h:24:10: fatal error: gst/gl/gl.h: No such file or directory

 #include <gst/gl/gl.h>
          ^~~~~~~~~~~~~
---
 package/gstreamer1/gst1-plugins-bad/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/gstreamer1/gst1-plugins-bad/Config.in +2 -2
index f00f3edb7c..79acd83a63 100644
@@ -595,11 +595,11 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WPE
 	bool "wpe"
 	default y
 	depends on BR2_PACKAGE_WPEWEBKIT
-	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
 
 comment "wpe needs the gst1-plugins-base opengl library and wpewebkit"
 	depends on !BR2_PACKAGE_WPEWEBKIT \
-		|| !BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+		|| !BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
 
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_X265
 	bool "x265"
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: fix opengl dependency

Hi,

Quoted 6 lines · James Hilliard

Fixes:
WPEThreadedView.h:24:10: fatal error: gst/gl/gl.h: No such file or directory

 #include <gst/gl/gl.h>
          ^~~~~~~~~~~~~

Thanks for the patch :)
?Adri?n

Quoted 29 lines
---
 package/gstreamer1/gst1-plugins-bad/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/gstreamer1/gst1-plugins-bad/Config.in +2 -2
index f00f3edb7c..79acd83a63 100644
@@ -595,11 +595,11 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WPE
 	bool "wpe"
 	default y
 	depends on BR2_PACKAGE_WPEWEBKIT
-	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
 
 comment "wpe needs the gst1-plugins-base opengl library and wpewebkit"
 	depends on !BR2_PACKAGE_WPEWEBKIT \
-		|| !BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+		|| !BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
 
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_X265
 	bool "x265"
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190808/5c631240/attachment.asc>

#2 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: fix opengl dependency

In reply to James Hilliard

James, Adrian, Adam,

Quoted 9 lines · On Wed, 7 Aug 2019 15:58:04 -0600 James Hilliard <[email protected]>…

Fixes:
WPEThreadedView.h:24:10: fatal error: gst/gl/gl.h: No such file or directory

 #include <gst/gl/gl.h>
          ^~~~~~~~~~~~~
---
 package/gstreamer1/gst1-plugins-bad/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

I must say I'm a bit confused by the GStreamer OpenGL options, and this particular patch. See below.

package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WPE · line 598

Quoted 10 lines
package/gstreamer1/gst1-plugins-bad/Config.in +1 -1
index f00f3edb7c..79acd83a63 100644
@@ -595,11 +595,11 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WPE
 	bool "wpe"
 	default y
 	depends on BR2_PACKAGE_WPEWEBKIT
-	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL

So with this patch in place, it is no longer possible to select the wpe plugin if you have OpenGL ES, you really need full OpenGL, making the WPE plugin unselectable on most embedded platforms, that often only provide OpenGL ES, and not full OpenGL ? Is that really the case ?

Also, I'm confused by the semantic of BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL. With this patch +
http://patchwork.ozlabs.org/patch/1143636/, it's essentially going to be used in only one remaining place:
BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL. And it is exactly equal to BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_WINDOW && BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL.

The naming is very confusing, and there are not many comments to explain what's going on. Can we try to clarify all of this ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: fix opengl dependency

Quoted 19 lines · Thomas Petazzoni

James, Adrian, Adam,

Quoted 9 lines · On Wed, 7 Aug 2019 15:58:04 -0600 James Hilliard <[email protected]>…

Fixes:
WPEThreadedView.h:24:10: fatal error: gst/gl/gl.h: No such file or directory

 #include <gst/gl/gl.h>
          ^~~~~~~~~~~~~
---
 package/gstreamer1/gst1-plugins-bad/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

I must say I'm a bit confused by the GStreamer OpenGL options, and this particular patch. See below.

Quoted 15 lines

package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WPE · line 598

Quoted 10 lines
package/gstreamer1/gst1-plugins-bad/Config.in +1 -1
index f00f3edb7c..79acd83a63 100644
@@ -595,11 +595,11 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WPE
      bool "wpe"
      default y
      depends on BR2_PACKAGE_WPEWEBKIT
-     depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+     depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL

So with this patch in place, it is no longer possible to select the wpe plugin if you have OpenGL ES, you really need full OpenGL, making the WPE plugin unselectable on most embedded platforms, that often only provide OpenGL ES, and not full OpenGL ? Is that really the case ?

From my testing it was required, maybe there's some additional config options I missed however.

Quoted 11 lines

Also, I'm confused by the semantic of BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL. With this patch +
http://patchwork.ozlabs.org/patch/1143636/, it's essentially going to be used in only one remaining place:
BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL. And it is exactly equal to BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_WINDOW && BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL.

The naming is very confusing, and there are not many comments to explain what's going on. Can we try to clarify all of this ?

Yeah, I agree this is very confusing, this patch took me quite a bit of testing to get
something that appears to be correct.
Not really sure myself what's up with the naming but a lot of stuff got moved around here:
https://github.com/buildroot/buildroot/commit/3f2aef56127fbe71378e6a2d55192a0835d962ab

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#4 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: fix opengl dependency

Hello James,

+Peter Seiderer

Quoted 11 lines · On Thu, 15 Aug 2019 16:54:56 -0600 James Hilliard <[email protected]>…
Quoted 9 lines · Thomas Petazzoni

James, Adrian, Adam,

Quoted 3 lines · On Wed, 7 Aug 2019 15:58:04 -0600 James Hilliard <[email protected]>…

Fixes:
WPEThreadedView.h:24:10: fatal error: gst/gl/gl.h: No such file or directory
#include <gst/gl/gl.h>

So, I just did a test with the following defconfig, which only has OpenGL ES (provided by rpi-userland) and not the full OpenGL:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2019.05.1.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_14=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_GSTREAMER1=y
BR2_PACKAGE_GST1_PLUGINS_BASE=y
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT is not set
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE is not set
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME is not set BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL=y
BR2_PACKAGE_RPI_USERLAND=y
# BR2_TARGET_ROOTFS_TAR is not set

And it does provide gst/gl/gl.h:

$ find . -name 'gl.h'
./output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/GLES/gl.h

So, gst/gl/gl.h is provided when OpenGL ES is used, which means your patch is most likely incorrect, and we should allow enabling the wpe plugin when OpenGL ES is available.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: fix opengl dependency

Quoted 45 lines · Thomas Petazzoni

Hello James,

+Peter Seiderer

Quoted 11 lines · On Thu, 15 Aug 2019 16:54:56 -0600 James Hilliard <[email protected]>…
Quoted 9 lines · Thomas Petazzoni

James, Adrian, Adam,

Quoted 3 lines · On Wed, 7 Aug 2019 15:58:04 -0600 James Hilliard <[email protected]>…

Fixes:
WPEThreadedView.h:24:10: fatal error: gst/gl/gl.h: No such file or directory
#include <gst/gl/gl.h>

So, I just did a test with the following defconfig, which only has OpenGL ES (provided by rpi-userland) and not the full OpenGL:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2019.05.1.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_14=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_GSTREAMER1=y
BR2_PACKAGE_GST1_PLUGINS_BASE=y
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT is not set
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE is not set
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME is not set BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL=y
BR2_PACKAGE_RPI_USERLAND=y
# BR2_TARGET_ROOTFS_TAR is not set

Quoted 4 lines

And it does provide gst/gl/gl.h:

$ find . -name 'gl.h'
./output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/GLES/gl.h

That's different from this right?:
https://github.com/GStreamer/gst-plugins-base/blob/1.16.0/gst-libs/gst/gl/gl.h

Quoted 4 lines

So, gst/gl/gl.h is provided when OpenGL ES is used, which means your patch is most likely incorrect, and we should allow enabling the wpe plugin when OpenGL ES is available.

I thought gst/gl/gl.h was provided by gst1-plugins-base not OpenGL ES right? That should get built based on this and not OpenGL ES AFAICT:
BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#6 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: fix opengl dependency

Quoted 54 lines · James Hilliard
Quoted 45 lines · Thomas Petazzoni

Hello James,

+Peter Seiderer

Quoted 11 lines · On Thu, 15 Aug 2019 16:54:56 -0600 James Hilliard <[email protected]>…
Quoted 9 lines · Thomas Petazzoni

James, Adrian, Adam,

Quoted 3 lines · On Wed, 7 Aug 2019 15:58:04 -0600 James Hilliard <[email protected]>…

Fixes:
WPEThreadedView.h:24:10: fatal error: gst/gl/gl.h: No such file or directory
#include <gst/gl/gl.h>

So, I just did a test with the following defconfig, which only has OpenGL ES (provided by rpi-userland) and not the full OpenGL:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2019.05.1.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_14=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_GSTREAMER1=y
BR2_PACKAGE_GST1_PLUGINS_BASE=y
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT is not set
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE is not set
# BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME is not set BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL=y
BR2_PACKAGE_RPI_USERLAND=y
# BR2_TARGET_ROOTFS_TAR is not set

Quoted 4 lines

And it does provide gst/gl/gl.h:

$ find . -name 'gl.h'
./output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/GLES/gl.h

That's different from this right?:
https://github.com/GStreamer/gst-plugins-base/blob/1.16.0/gst-libs/gst/gl/gl.h

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

So, gst/gl/gl.h is provided when OpenGL ES is used, which means your patch is most likely incorrect, and we should allow enabling the wpe plugin when OpenGL ES is available.

I thought gst/gl/gl.h was provided by gst1-plugins-base not OpenGL ES right? That should get built based on this and not OpenGL ES AFAICT:
BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL

I suspect that what is actually needed is that gst1-plugins-base is configured
with -Dgl=enabled. Therefore, after 4164d31e05 which I just applied, I think the condition should actually be on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API.

Could you test with the defconfig that Thomas provided and
BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_GLES2 if the build of WPE succeeds?

Regards,
Arnout

Quoted 13 lines
Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#7 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: fix opengl dependency

On 12/10/2019 00:11, Arnout Vandecappelle wrote:
[snip]

Quoted 6 lines

I suspect that what is actually needed is that gst1-plugins-base is configured
with -Dgl=enabled. Therefore, after 4164d31e05 which I just applied, I think the condition should actually be on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API.

Could you test with the defconfig that Thomas provided and
BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_GLES2 if the build of WPE succeeds?

BTW I've marked this patch as Changes Requested.

Regards,
Arnout