s390x/mmu: Storage key reference and change bit handling
v3 cover s390x/mmu: Storage key reference and change bit handling
The first two patches are modified patches from:
[PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions
This series primarily fixes minor things in the storage key handling code in the MMU and implements fairly reliable reference and change bit handling for TCG. To track the reference and change bit, we have to invalidate TLB entries whenever the storage key is changed by the guest and make sure not TLB entry is writable in case the storage key does not indicate a change already.
With this series, the kvm-unit-test "skey" now passes. \o/
v2 -> v3:
- Reshuffled patches to avoid a temporary uninitialized return value
- Minor updates to patch descriptions
- "s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE" -- Updated comments
- "s390x/mmu: Factor out storage key handling"
-- Reduce indentation
v1 -> v2:
- "s390x/tcg: Rework MMU selection for instruction fetches" -- Cleanup return value handling
- Added RB's
David Hildenbrand (6):
s390x/mmu: Trace the right value if setting/getting the storage key
fails
s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug() s390x/tcg: Rework MMU selection for instruction fetches s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE s390x/mmu: Better storage key reference and change bit handling s390x/mmu: Factor out storage key handling
target/s390x/cpu.h | 7 ++ target/s390x/helper.c | 5 ++ target/s390x/mem_helper.c | 10 +++ target/s390x/mmu_helper.c | 135 ++++++++++++++++++++++++-------------- 4 files changed, 107 insertions(+), 50 deletions(-)
Signature · 1 line
2.21.0
PATCH v3 1/6 s390x/mmu: Trace the right value if setting/getting the storage key fails
We want to trace the actual return value, not "0".
--- target/s390x/mmu_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
target/s390x/mmu_helper.c +4 -2
@@ -422,7 +422,8 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc, *raddr =mmu_real2abs (env, *raddr);if (r ==0 && *raddr < ram_size) { -if (skeyclass->get_skeys (ss, *raddr /TARGET_PAGE_SIZE ,1 , &key)) { + r = skeyclass->get_skeys (ss, *raddr /TARGET_PAGE_SIZE ,1 , &key); +if (r) {trace_get_skeys_nonzero (r);return 0 ; }
@@ -435,7 +436,8 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc, key |=SK_C ; } -if (skeyclass->set_skeys (ss, *raddr /TARGET_PAGE_SIZE ,1 , &key)) { + r = skeyclass->set_skeys (ss, *raddr /TARGET_PAGE_SIZE ,1 , &key); +if (r) {trace_set_skeys_nonzero (r);return 0 ; }
Signature · 1 line
2.21.0
Re: [Qemu-devel] [PATCH v3 1/6] s390x/mmu: Trace the right value if setting/getting the storage key fails
Quoted 3 lines · On Fri, 16 Aug 2019 10:47:03 +0200 David Hildenbrand <[email protected]> wrote:
We want to trace the actual return value, not "0".
Fixes 0f5f669147b5 (s390x: Enable new s390-storage-keys device)
:)
Quoted 6 lines
Reviewed-by Cornelia Huck <[email protected]>Reviewed-by Thomas Huth <[email protected]>Signed-off-by David Hildenbrand <[email protected]>--- target/s390x/mmu_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
PATCH v3 2/6 s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()
In reply to David HildenbrandLet's select the ASC before calling the function. This is a prepararion to remove the ASC magic depending on the access mode from mmu_translate.
There is currently no way to distinguish if we have code or data access. For now, we were using code access, because especially when debugging with the gdbstub, we want to read and disassemble what we single-step.
Note: KVM guest can now no longer be crashed using qmp/hmp/gdbstub if they happen to be in AR mode.
--- target/s390x/helper.c | 5 +++++ 1 file changed, 5 insertions(+)
target/s390x/helper.c +5 -0
@@ -58,6 +58,11 @@ hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr vaddr) vaddr &=0x7fffffff ; } +/* We want to read the code (e.g., see what we are single-stepping).*/ +if (asc !=PSW_ASC_HOME ) { + asc =PSW_ASC_PRIMARY ; + } +if (mmu_translate (env, vaddr,MMU_INST_FETCH , asc, &raddr, &prot, false)) {return -1 ; }
Signature · 1 line
2.21.0
PATCH v3 3/6 s390x/tcg: Rework MMU selection for instruction fetches
In reply to David HildenbrandInstructions are always fetched from primary address space, except when in home address mode. Perform the selection directly in cpu_mmu_index().
get_mem_index() is only used to perform data access, instructions are fetched via cpu_lduw_code(), which translates to cpu_mmu_index(env, true).
We don't care about restricting the access permissions of the TLB entries anymore, as we no longer enter PRIMARY entries into the SECONDARY MMU. Cleanup related code a bit.
--- target/s390x/cpu.h | 7 +++++++ target/s390x/mmu_helper.c | 38 +++++++++++++++----------------------- 2 files changed, 22 insertions(+), 23 deletions(-)
target/s390x/cpu.h +7 -0
@@ -332,6 +332,13 @@ static inline int cpu_mmu_index(CPUS390XState *env, bool ifetch)return MMU_REAL_IDX ; } +if (ifetch) { +if ((env->psw.mask &PSW_MASK_ASC ) ==PSW_ASC_HOME ) { +return MMU_HOME_IDX ; + } +return MMU_PRIMARY_IDX ; + } +switch (env->psw.mask &PSW_MASK_ASC ) {case PSW_ASC_PRIMARY :return MMU_PRIMARY_IDX ;
target/s390x/mmu_helper.c +15 -23
@@ -349,8 +349,9 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc, {static S390SKeysState *ss;static S390SKeysClass *skeyclass; -int r =-1 ; +uint64_t asce;uint8_t key; +int r;if (unlikely (!ss)) { ss =s390_get_skeys_device ();
@@ -380,36 +381,21 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc,if (!(env->psw.mask &PSW_MASK_DAT )) { *raddr = vaddr; - r =0 ; - goto out; + goto nodat; }switch (asc) {case PSW_ASC_PRIMARY :PTE_DPRINTF ("%s: asc=primary\n" , __func__); - r =mmu_translate_asce (env, vaddr, asc, env->cregs[1 ], raddr, flags, - rw, exc); + asce = env->cregs[1 ];break ;case PSW_ASC_HOME :PTE_DPRINTF ("%s: asc=home\n" , __func__); - r =mmu_translate_asce (env, vaddr, asc, env->cregs[13 ], raddr, flags, - rw, exc); + asce = env->cregs[13 ];break ;case PSW_ASC_SECONDARY :PTE_DPRINTF ("%s: asc=secondary\n" , __func__); -/* -* Instruction: Primary -* Data: Secondary -*/ -if (rw ==MMU_INST_FETCH ) { - r =mmu_translate_asce (env, vaddr,PSW_ASC_PRIMARY , env->cregs[1 ], - raddr, flags, rw, exc); - *flags &= ~(PAGE_READ |PAGE_WRITE ); - }else { - r =mmu_translate_asce (env, vaddr,PSW_ASC_SECONDARY , env->cregs[7 ], - raddr, flags, rw, exc); - *flags &= ~(PAGE_EXEC ); - } + asce = env->cregs[7 ];break ;case PSW_ASC_ACCREG :default :
@@ -417,11 +403,17 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc,break ; } - out: +/* perform the DAT translation */ + r =mmu_translate_asce (env, vaddr, asc, asce, raddr, flags, rw, exc); +if (r) { +return r; + } + +nodat:/* Convert real address -> absolute address */ *raddr =mmu_real2abs (env, *raddr); -if (r ==0 && *raddr < ram_size) { +if (*raddr < ram_size) { r = skeyclass->get_skeys (ss, *raddr /TARGET_PAGE_SIZE ,1 , &key);if (r) {trace_get_skeys_nonzero (r);
@@ -443,7 +435,7 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc, } } -return r; +return 0 ; }/**
Signature · 1 line
2.21.0
Re: [Qemu-devel] [PATCH v3 3/6] s390x/tcg: Rework MMU selection for instruction fetches
Quoted 10 lines · On Fri, 16 Aug 2019 10:47:05 +0200 David Hildenbrand <[email protected]> wrote:
Instructions are always fetched from primary address space, except when in home address mode. Perform the selection directly in
cpu_mmu_index().
get_mem_index()is only used to perform data access, instructions are fetched viacpu_lduw_code(), which translates tocpu_mmu_index(env, true).We don't care about restricting the access permissions of the TLB entries anymore, as we no longer enter PRIMARY entries into the SECONDARY MMU. Cleanup related code a bit.
Quoted 6 lines
Reviewed-by Thomas Huth <[email protected]>Signed-off-by David Hildenbrand <[email protected]>--- target/s390x/cpu.h | 7 +++++++ target/s390x/mmu_helper.c | 38 +++++++++++++++----------------------- 2 files changed, 22 insertions(+), 23 deletions(-)
PATCH v3 4/6 s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE
In reply to David HildenbrandWhenever we modify a storage key, we should flush the TLBs of all CPUs, so the MMU fault handling code can properly consider the changed storage key (to e.g., properly set the reference and change bit on the next accesses).
These functions are barely used in modern Linux guests, so the performance implications are neglectable for now.
This is a preparation for better reference and change bit handling for TCG, which will require more MMU changes.
--- target/s390x/mem_helper.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
target/s390x/mem_helper.c +10 -0
@@ -1815,6 +1815,11 @@ void HELPER(sske)(CPUS390XState *env, uint64_t r1, uint64_t r2) key = (uint8_t ) r1; skeyclass->set_skeys (ss, addr /TARGET_PAGE_SIZE ,1 , &key); +/* +* As we can only flush by virtual address and not all the entries +* that point to a physical address we have to flush the whole TLB. +*/ +tlb_flush_all_cpus_synced (env_cpu (env)); }/* reset reference bit extended */
@@ -1843,6 +1848,11 @@ uint32_t HELPER(rrbe)(CPUS390XState *env, uint64_t r2)if (skeyclass->set_skeys (ss, r2 /TARGET_PAGE_SIZE ,1 , &key)) {return 0 ; } +/* +* As we can only flush by virtual address and not all the entries +* that point to a physical address we have to flush the whole TLB. +*/ +tlb_flush_all_cpus_synced (env_cpu (env));/* * cc
Signature · 1 line
2.21.0
Re: [Qemu-devel] [PATCH v3 4/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE
Quoted 5 lines · David Hildenbrand
Whenever we modify a storage key, we should flush the TLBs of all CPUs, so the MMU fault handling code can properly consider the changed storage key (to e.g., properly set the reference and change bit on the next accesses).
Quoted 8 lines
These functions are barely used in modern Linux guests, so the performance implications are neglectable for now.
This is a preparation for better reference and change bit handling for TCG, which will require more MMU changes.
Reviewed-by Cornelia Huck <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 22 lines
--- target/s390x/mem_helper.c | 10 ++++++++++ 1 file changed, 10 insertions(+)target/s390x/mem_helper.c +5
-0@@ -1815,6 +1815,11 @@ void HELPER(sske)(CPUS390XState *env, uint64_t r1, uint64_t r2) key = (uint8_t ) r1; skeyclass->set_skeys (ss, addr /TARGET_PAGE_SIZE ,1 , &key); +/* +* As we can only flush by virtual address and not all the entries +* that point to a physical address we have to flush the whole TLB. +*/ +tlb_flush_all_cpus_synced (env_cpu (env)); }/* reset reference bit extended */ @@ -1843,6 +1848,11 @@ uint32_t HELPER(rrbe)(CPUS390XState *env, uint64_t r2)if (skeyclass->set_skeys (ss, r2 /TARGET_PAGE_SIZE ,1 , &key)) {
target/s390x/mem_helper.c uint32_t HELPER(rrbe)(CPUS390XState *env, uint64_t r2) · line 1858
Quoted 10 lines
target/s390x/mem_helper.c +5
-0return 0 ; } +/* +* As we can only flush by virtual address and not all the entries +* that point to a physical address we have to flush the whole TLB. +*/ +tlb_flush_all_cpus_synced (env_cpu (env));/* * cc
--
Alex Bennée
PATCH v3 5/6 s390x/mmu: Better storage key reference and change bit handling
In reply to David HildenbrandAny access sets the reference bit. In case we have a read-fault, we should not allow writes to the TLB entry if the change bit was not already set.
This is a preparation for proper storage-key reference/change bit handling in TCG and a fix for KVM whereby read accesses would set the change bit (old KVM versions without the ioctl to carry out the translation).
--- target/s390x/mmu_helper.c | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-)
target/s390x/mmu_helper.c +19 -5
@@ -420,14 +420,28 @@ nodat:return 0 ; } -if (*flags &PAGE_READ ) { - key |=SK_R ; - } - -if (*flags &PAGE_WRITE ) { +switch (rw) { +case MMU_DATA_LOAD : +case MMU_INST_FETCH : +/* +* The TLB entry has to remain write-protected on read-faults if +* the storage key does not indicate a change already. Otherwise +* we might miss setting the change bit on write accesses. +*/ +if (!(key &SK_C )) { + *flags &= ~PAGE_WRITE ; + } +break ; +case MMU_DATA_STORE : key |=SK_C ; +break ; +default : +g_assert_not_reached (); } +/* Any store/fetch sets the reference bit */ + key |=SK_R ; + r = skeyclass->set_skeys (ss, *raddr /TARGET_PAGE_SIZE ,1 , &key);if (r) {trace_set_skeys_nonzero (r);
Signature · 1 line
2.21.0
PATCH v3 6/6 s390x/mmu: Factor out storage key handling
In reply to David HildenbrandFactor it out, add a comment how it all works, and also use it in the REAL MMU.
--- target/s390x/mmu_helper.c | 115 +++++++++++++++++++++++--------------- 1 file changed, 71 insertions(+), 44 deletions(-)
target/s390x/mmu_helper.c +71 -44
@@ -334,6 +334,75 @@ static int mmu_translate_asce(CPUS390XState *env, target_ulong vaddr,return r; } +static void mmu_handle_skey (target_ulong addr,int rw,int *flags) +{ +static S390SKeysClass *skeyclass; +static S390SKeysState *ss; +uint8_t key; +int rc; + +if (unlikely (addr >= ram_size)) { +return ; + } + +if (unlikely (!ss)) { + ss =s390_get_skeys_device (); + skeyclass =S390_SKEYS_GET_CLASS (ss); + } + +/* +* Whenever we create a new TLB entry, we set the storage key reference +* bit. In case we allow write accesses, we set the storage key change +* bit. Whenever the guest changes the storage key, we have to flush the +* TLBs of all CPUs (the whole TLB or all affected entries), so that the +* next reference/change will result in an MMU fault and make us properly +* update the storage key here. +* +* Note 1: "record of references ... is not necessarily accurate", +* "change bit may be set in case no storing has occurred". +* -> We can set reference/change bits even on exceptions. +* Note 2: certain accesses seem to ignore storage keys. For example, +* DAT translation does not set reference bits for table accesses. +* +* TODO: key-controlled protection. Only CPU accesses make use of the +* PSW key. CSS accesses are different - we have to pass in the key. +* +* TODO: we have races between getting and setting the key. +*/ + rc = skeyclass->get_skeys (ss, addr /TARGET_PAGE_SIZE ,1 , &key); +if (rc) { +trace_get_skeys_nonzero (rc); +return ; + } + +switch (rw) { +case MMU_DATA_LOAD : +case MMU_INST_FETCH : +/* +* The TLB entry has to remain write-protected on read-faults if +* the storage key does not indicate a change already. Otherwise +* we might miss setting the change bit on write accesses. +*/ +if (!(key &SK_C )) { + *flags &= ~PAGE_WRITE ; + } +break ; +case MMU_DATA_STORE : + key |=SK_C ; +break ; +default : +g_assert_not_reached (); + } + +/* Any store/fetch sets the reference bit */ + key |=SK_R ; + + rc = skeyclass->set_skeys (ss, addr /TARGET_PAGE_SIZE ,1 , &key); +if (rc) { +trace_set_skeys_nonzero (rc); + } +} +/** * Translate a virtual (logical) address into a physical (absolute) address. * @param vaddr the virtual address
@@ -347,16 +416,9 @@ static int mmu_translate_asce(CPUS390XState *env, target_ulong vaddr,int mmu_translate (CPUS390XState *env,target_ulong vaddr,int rw,uint64_t asc,target_ulong *raddr,int *flags,bool exc) { -static S390SKeysState *ss; -static S390SKeysClass *skeyclass;uint64_t asce; -uint8_t key;int r; -if (unlikely (!ss)) { - ss =s390_get_skeys_device (); - skeyclass =S390_SKEYS_GET_CLASS (ss); - } *flags =PAGE_READ |PAGE_WRITE |PAGE_EXEC ;if (is_low_address (vaddr &TARGET_PAGE_MASK ) &&lowprot_enabled (env, asc)) {
@@ -413,42 +475,7 @@ nodat:/* Convert real address -> absolute address */ *raddr =mmu_real2abs (env, *raddr); -if (*raddr < ram_size) { - r = skeyclass->get_skeys (ss, *raddr /TARGET_PAGE_SIZE ,1 , &key); -if (r) { -trace_get_skeys_nonzero (r); -return 0 ; - } - -switch (rw) { -case MMU_DATA_LOAD : -case MMU_INST_FETCH : -/* -* The TLB entry has to remain write-protected on read-faults if -* the storage key does not indicate a change already. Otherwise -* we might miss setting the change bit on write accesses. -*/ -if (!(key &SK_C )) { - *flags &= ~PAGE_WRITE ; - } -break ; -case MMU_DATA_STORE : - key |=SK_C ; -break ; -default : -g_assert_not_reached (); - } - -/* Any store/fetch sets the reference bit */ - key |=SK_R ; - - r = skeyclass->set_skeys (ss, *raddr /TARGET_PAGE_SIZE ,1 , &key); -if (r) { -trace_set_skeys_nonzero (r); -return 0 ; - } - } - +mmu_handle_skey (*raddr, rw, flags);return 0 ; }
@@ -566,6 +593,6 @@ int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw, *addr =mmu_real2abs (env, raddr &TARGET_PAGE_MASK ); -/* TODO: storage key handling */ +mmu_handle_skey (*addr, rw, flags);return 0 ; }
Signature · 1 line
2.21.0
Quoted 36 lines · On Fri, 16 Aug 2019 10:47:02 +0200 David Hildenbrand <[email protected]> wrote:
The first two patches are modified patches from:
[PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensionsThis series primarily fixes minor things in the storage key handling code in the MMU and implements fairly reliable reference and change bit handling for TCG. To track the reference and change bit, we have to invalidate TLB entries whenever the storage key is changed by the guest and make sure not TLB entry is writable in case the storage key does not indicate a change already.
With this series, the kvm-unit-test "skey" now passes. \o/
v2 -> v3:
- Reshuffled patches to avoid a temporary uninitialized return value
- Minor updates to patch descriptions
- "s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE" -- Updated comments
- "s390x/mmu: Factor out storage key handling"
-- Reduce indentationv1 -> v2:
- "s390x/tcg: Rework MMU selection for instruction fetches" -- Cleanup return value handling
- Added RB'sCc Alex Bennée <[email protected]>David Hildenbrand (6):
s390x/mmu: Trace the right value if setting/getting the storage key
fails
s390x/mmu: ASC selection ins390_cpu_get_phys_page_debug()s390x/tcg: Rework MMU selection for instruction fetches s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE s390x/mmu: Better storage key reference and change bit handling s390x/mmu: Factor out storage key handling
Quoted 6 lines
target/s390x/cpu.h | 7 ++ target/s390x/helper.c | 5 ++ target/s390x/mem_helper.c | 10 +++ target/s390x/mmu_helper.c | 135 ++++++++++++++++++++++++-------------- 4 files changed, 107 insertions(+), 50 deletions(-)
Looks good to me now.
I can pick this up directly, or you can send me a pull request (whichever you prefer).
Quoted 46 lines · Cornelia Huck
Quoted 36 lines · On Fri, 16 Aug 2019 10:47:02 +0200 David Hildenbrand <[email protected]> wrote:
The first two patches are modified patches from:
[PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensionsThis series primarily fixes minor things in the storage key handling code in the MMU and implements fairly reliable reference and change bit handling for TCG. To track the reference and change bit, we have to invalidate TLB entries whenever the storage key is changed by the guest and make sure not TLB entry is writable in case the storage key does not indicate a change already.
With this series, the kvm-unit-test "skey" now passes. \o/
v2 -> v3:
- Reshuffled patches to avoid a temporary uninitialized return value
- Minor updates to patch descriptions
- "s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE" -- Updated comments
- "s390x/mmu: Factor out storage key handling"
-- Reduce indentationv1 -> v2:
- "s390x/tcg: Rework MMU selection for instruction fetches" -- Cleanup return value handling
- Added RB'sCc Alex Bennée <[email protected]>David Hildenbrand (6):
s390x/mmu: Trace the right value if setting/getting the storage key
fails
s390x/mmu: ASC selection ins390_cpu_get_phys_page_debug()s390x/tcg: Rework MMU selection for instruction fetches s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE s390x/mmu: Better storage key reference and change bit handling s390x/mmu: Factor out storage key handlingQuoted 6 lines
target/s390x/cpu.h | 7 ++ target/s390x/helper.c | 5 ++ target/s390x/mem_helper.c | 10 +++ target/s390x/mmu_helper.c | 135 ++++++++++++++++++++++++-------------- 4 files changed, 107 insertions(+), 50 deletions(-)
Quoted 5 lines
Looks good to me now.
I can pick this up directly, or you can send me a pull request (whichever you prefer).
If you have some spare cycles, please pick it up :) Whatever you prefer!
Signature · 3 lines
Thanks, David / dhildenb
Cornelia Huck
AppliedQuoted 36 lines · On Fri, 16 Aug 2019 10:47:02 +0200 David Hildenbrand <[email protected]> wrote:
The first two patches are modified patches from:
[PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensionsThis series primarily fixes minor things in the storage key handling code in the MMU and implements fairly reliable reference and change bit handling for TCG. To track the reference and change bit, we have to invalidate TLB entries whenever the storage key is changed by the guest and make sure not TLB entry is writable in case the storage key does not indicate a change already.
With this series, the kvm-unit-test "skey" now passes. \o/
v2 -> v3:
- Reshuffled patches to avoid a temporary uninitialized return value
- Minor updates to patch descriptions
- "s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE" -- Updated comments
- "s390x/mmu: Factor out storage key handling"
-- Reduce indentationv1 -> v2:
- "s390x/tcg: Rework MMU selection for instruction fetches" -- Cleanup return value handling
- Added RB'sCc Alex Bennée <[email protected]>David Hildenbrand (6):
s390x/mmu: Trace the right value if setting/getting the storage key
fails
s390x/mmu: ASC selection ins390_cpu_get_phys_page_debug()s390x/tcg: Rework MMU selection for instruction fetches s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE s390x/mmu: Better storage key reference and change bit handling s390x/mmu: Factor out storage key handling
Quoted 6 lines
target/s390x/cpu.h | 7 ++ target/s390x/helper.c | 5 ++ target/s390x/mem_helper.c | 10 +++ target/s390x/mmu_helper.c | 135 ++++++++++++++++++++++++-------------- 4 files changed, 107 insertions(+), 50 deletions(-)
[Now the correct one...]
Thanks, applied.