dt/bindings: display: Add optional property node define for Mali DP500
Subsystems (4)
PATCH v4 1/2 dt/bindings: display: Add optional property node define for Mali DP500
Add optional property node 'arm,malidp-arqos-value' for the Mali DP500. This property describe the ARQoS levels of DP500's QoS signaling.
--- Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/display/arm,malidp.txt +3 -0
@@ -37,6 +37,8 @@ Optional properties: Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt) to be used for the framebuffer; if not present, the framebuffer may be located anywhere in memory. + - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS + levels of DP500's QoS signaling. Example:
@@ -54,6 +56,7 @@ Example: clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>; clock-names = "pxlclk", "mclk", "aclk", "pclk"; arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; + arm,malidp-arqos-high-level = <0xd000d000>; port { dp0_output: endpoint { remote-endpoint = <&tda998x_2_input>;
Signature · 1 line
2.17.1
PATCH v4 2/2 drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the high resolutions flicker issue on the LS1028A platform.
--- drivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +6 -0
@@ -815,6 +815,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version; + ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ; +/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node, "arm,malidp-output-port-lines",
drivers/gpu/drm/arm/malidp_hw.c +13 -0
@@ -374,6 +374,19 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *malidp_hw_setbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); elsemalidp_hw_clearbits (hwdev ,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); + +/* +* Program the RQoS register to avoid high resolutions flicker +* issue on the LS1028A. +*/ +if (hwdev->arqos_value) { + val = hwdev->arqos_value; + +if (mode->pixelclock >148500000 ) +malidp_hw_setbits (hwdev, val,MALIDP500_RQOS_QUALITY ); +else +malidp_hw_clearbits (hwdev, val,MALIDP500_RQOS_QUALITY ); + } }int malidp_format_get_bpp (u32 fmt)
drivers/gpu/drm/arm/malidp_hw.h +3 -0
@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available */ u32 rotation_memory[2 ]; + +/* priority level of RQOS register used for driven the ARQOS signal */ +u32 arqos_value; };static inline u32 malidp_hw_read (struct malidp_hw_device *hwdev,u32 reg)
drivers/gpu/drm/arm/malidp_regs.h +10 -0
@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS register values +* are driven by the ARQOS signal, using AXI transacations, dependent on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions +* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010
Signature · 1 line
2.17.1
Liviu Dudau
maintainerRe: [v4 2/2] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500
Hi Wen,
Quoted 43 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the high resolutions flicker issue on the LS1028A platform.
Signed-off-by Wen He <[email protected]>--- drivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +6
-0@@ -815,6 +815,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version; + ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ; +/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node, "arm,malidp-output-port-lines",drivers/gpu/drm/arm/malidp_hw.c +3
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *malidp_hw_setbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); elsemalidp_hw_clearbits (hwdev ,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); + +/* +* Program the RQoS register to avoid high resolutions flicker
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 389
Quoted 10 lines
drivers/gpu/drm/arm/malidp_hw.c +10
-0+* issue on the LS1028A. +*/ +if (hwdev->arqos_value) { + val = hwdev->arqos_value; + +if (mode->pixelclock >148500000 ) +malidp_hw_setbits (hwdev, val,MALIDP500_RQOS_QUALITY ); +else +malidp_hw_clearbits (hwdev, val,MALIDP500_RQOS_QUALITY ); + }
This application of the arqos_value based on a pixel clock value bothers me, because it has two problems:
1. Some other user of the Mali DP driver can't apply a system QoS value that they can now specify in the DT, unless the requested pixel clock is bigger than 145MHz. :(
2. (A guess) The flickering issue shows up on a combination of pixelclock and resolution (i.e. it is a bandwidth problem), but you only address one of the variables. Haven't tested on the LS1028A yet, but do you know if (theoretically) it would have a flicker problem doing 640x480@200MHz without the QoS value?
How about this instead?
--8<---------------------------------------------------------------------
drivers/gpu/drm/arm/malidp_hw.c +16 -0
@@ -374,6 +374,22 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *malidp_hw_setbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); elsemalidp_hw_clearbits (hwdev ,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); + +/* +* Program the RQoS register. LS1028A has an issue where screen will +* flicker on pixelclocks higher than 148.5MHz but otherwise doesn't +* want an RQoS value, so special case it for them. +*/ +if (hwdev->arqos_value) { + val = hwdev->arqos_value; + +#ifdef MALIDP_LS1028A +if (mode->pixelclock <=148500000 ) +malidp_hw_clearbits (hwdev, val,MALIDP500_RQOS_QUALITY ); + else +#endif +malidp_hw_setbits (hwdev, val,MALIDP500_RQOS_QUALITY ); + } }int malidp_format_get_bpp (u32 fmt)
--8<---------------------------------------------------------------------
And then you need to define a MALIDP_LS1028A in a vendor patch on top of the kernel source code.
Best regards,
Liviu
Quoted 41 lines
drivers/gpu/drm/arm/malidp_hw.c +0
-0}int malidp_format_get_bpp (u32 fmt)drivers/gpu/drm/arm/malidp_hw.h +3
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available */ u32 rotation_memory[2 ]; + +/* priority level of RQOS register used for driven the ARQOS signal */ +u32 arqos_value; };static inline u32 malidp_hw_read (struct malidp_hw_device *hwdev,u32 reg)drivers/gpu/drm/arm/malidp_regs.h +10
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS register values +* are driven by the ARQOS signal, using AXI transacations, dependent on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions +* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010Signature · 1 line
2.17.1
Signature · 12 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-develRE: [EXT] Re: [v4 2/2] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500
Quoted 129 lines
-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年9月6日 22:18
To: Wen He <[email protected]>
Cc: [email protected]; Brian Starkey <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [v4 2/2] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500Caution: EXT Email
Hi Wen,
drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct
Quoted 39 lines · Wen He
Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.
QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the high resolutions flicker issue on the LS1028A platform.
Signed-off-by Wen He <[email protected]>--- drivers/gpu/drm/arm/malidp_drv.c | 6 ++++++ drivers/gpu/drm/arm/malidp_hw.c | 13 +++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 3 +++ drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++ 4 files changed, 32 insertions(+)drivers/gpu/drm/arm/malidp_drv.c +6
-0@@ -815,6 +815,12 @@ static int malidp_bind(struct device *dev) malidp->core_id = version; + ret =of_property_read_u32 (dev->of_node, +"arm,malidp-arqos-value" , + &hwdev->arqos_value); +if (ret) + hwdev->arqos_value =0x0 ; +/* set the number of lines used for output of RGB data */ ret = of_property_read_u8_array(dev->of_node, "arm,malidp-output-port-lines",(quoted diff) +0
-0
b/drivers/gpu/drm/arm/malidp_hw.cindex380be66d4c6e..f90a367a5bc9100644drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,19 @@ static void malidp500_modeset(struct
malidp_hw_device*hwdev, struct videomode *drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 374
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0
-0malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,
MALIDP_DE_DISPLAY_FUNC);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *
Quoted 13 lines
drivers/gpu/drm/arm/malidp_hw.c +10
-0else malidp_hw_clearbits (hwdev,MALIDP_DISP_FUNC_ILACED ,MALIDP_DE_DISPLAY_FUNC ); + +/* +* Program the RQoS register to avoid high resolutions flicker +* issue on the LS1028A. +*/ +if (hwdev->arqos_value) { + val = hwdev->arqos_value; + +if (mode->pixelclock >148500000 ) + malidp_hw_setbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 389
Quoted 2 lines
drivers/gpu/drm/arm/malidp_hw.c +2
-0+else + malidp_hw_clearbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode * · line 392
Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +1
-0+ }This application of the
arqos_valuebased on a pixel clock value bothers me, because it has two problems:1. Some other user of the Mali DP driver can't apply a system QoS value that they can now specify in the DT, unless the requested pixel clock is bigger than 145MHz. :(
2. (A guess) The flickering issue shows up on a combination of pixelclock and resolution (i.e. it is a bandwidth problem), but you only address one of the variables. Haven't tested on the LS1028A yet, but do you know if (theoretically) it would have a flicker problem doing 640x480@200MHz without the QoS value?
How about this instead?
--8<---------------------------------------------------------------------
(quoted diff) +0
-0
b/drivers/gpu/drm/arm/malidp_hw.cindex380be66d4c6eb..e2f96dce13850100644drivers/gpu/drm/arm/malidp_hw.c +0
-0@@ -374,6 +374,22 @@ static void malidp500_modeset(struct
malidp_hw_device*hwdev, struct videomode *
malidp_hw_setbits(hwdev,MALIDP_DISP_FUNC_ILACED,MALIDP_DE_DISPLAY_FUNC);
else
malidp_hw_clearbits(hwdev,MALIDP_DISP_FUNC_ILACED,MALIDP_DE_DISPLAY_FUNC);drivers/gpu/drm/arm/malidp_hw.c +3
-0+ +/* +* Program the RQoS register. LS1028A has an issue where screen will
drivers/gpu/drm/arm/malidp_hw.c +9
-0+* flicker on pixelclocks higher than 148.5MHz but otherwise doesn't +* want an RQoS value, so special case it for them. +*/ +if (hwdev->arqos_value) { + val = hwdev->arqos_value; + +#ifdef MALIDP_LS1028A +if (mode->pixelclock <=148500000 ) + malidp_hw_clearbits(hwdev, val,
MALIDP500_RQOS_QUALITY);drivers/gpu/drm/arm/malidp_hw.c +3
-0+ else +#endif + malidp_hw_setbits(hwdev, val,
MALIDP500_RQOS_QUALITY);
+ }
}
Quoted 5 lines
int
malidp_format_get_bpp(u32 fmt)
--8<---------------------------------------------------------------------And then you need to define a
MALIDP_LS1028Ain a vendor patch on top of the kernel source code.
That's a good instead, thanks a lot.
After discussed with our team, they think should not put the different on the vendor code, benchmark results can accept the small reduce, so here should always apply this change.
I will send next version that remove the condition of the pixel clock , thanks a lot.
Best Regards,
Wen
Quoted 62 lines
Best regards,
Liviudrivers/gpu/drm/arm/malidp_hw.h struct malidp_hw_device { · line 252
Quoted 11 lines
drivers/gpu/drm/arm/malidp_hw.c +0
-0}int
malidp_format_get_bpp(u32 fmt)(quoted diff) +0
-0
b/drivers/gpu/drm/arm/malidp_hw.hindex968a65eed371..e4c36bc90bda100644drivers/gpu/drm/arm/malidp_hw.h +0
-0@@ -251,6 +251,9 @@ struct malidp_hw_device {/* size of memory used for rotating layers, up to two banks available */
Quoted 14 lines
drivers/gpu/drm/arm/malidp_hw.h +3
-0u32 rotation_memory[2 ]; + +/* priority level of RQOS register used for driven the ARQOS signal */ +u32 arqos_value; }; static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32reg) diff --git
a/drivers/gpu/drm/arm/malidp_regs.hb/drivers/gpu/drm/arm/malidp_regs.h
index993031542fa1..514c50dcb74d100644drivers/gpu/drm/arm/malidp_regs.h +0
-0@@ -210,6 +210,16 @@#define MALIDP500_CONFIG_VALID 0x00f00drivers/gpu/drm/arm/malidp_regs.h line 220
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8
-0#define MALIDP500_CONFIG_ID 0x00fd4 +/* +* The quality of service (QoS) register on the DP500. RQOS register +values +* are driven by the ARQOS signal, using AXI transacations, dependent +on the +* FIFO input level. +* The RQOS register can also set QoS levels for: +* - RED_ARQOS @ A 4-bit signal value for close to underflow conditions
Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +4
-1+* - GREEN_ARQOS @ A 4-bit signal value for normal conditions +*/ +#define MALIDP500_RQOS_QUALITY 0x00500 +/* register offsets and bits specific to DP550/DP650 */ #define MALIDP550_ADDR_SPACE_SIZE 0x10000#define MALIDP550_DE_CONTROL 0x00010 --2.17.1
--
====================| I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
Quoted 8 lines · Wen He
Add optional property node 'arm,malidp-arqos-value' for the Mali DP500. This property describe the ARQoS levels of DP500's QoS signaling.
Signed-off-by Wen He <[email protected]>--- Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++ 1 file changed, 3 insertions(+)