Skip to contentSkip to conversation

dt/bindings: display: Add optional property node define for Mali DP500

PATCH In review Wen He 3 participants 5 messages Sep 10, 2019 – Oct 16, 2019

Subsystems (4)
lore
Share & tools
lore

Wen He

author
#0 lore raw

PATCH v5 1/2 dt/bindings: display: Add optional property node define for Mali DP500

Add optional property node 'arm,malidp-arqos-value' for the Mali DP500. This property describe the ARQoS levels of DP500's QoS signaling.

---
 Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/display/arm,malidp.txt +3 -0
index 2f7870983ef1..7a97a2b48c2a 100644
@@ -37,6 +37,8 @@ Optional properties:
     Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
     to be used for the framebuffer; if not present, the framebuffer may
     be located anywhere in memory.
+  - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
+    levels of DP500's QoS signaling.
 
 
 Example:
@@ -54,6 +56,7 @@ Example:
 		clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
 		clock-names = "pxlclk", "mclk", "aclk", "pclk";
 		arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
+		arm,malidp-arqos-high-level = <0xd000d000>;
 		port {
 			dp0_output: endpoint {
 				remote-endpoint = <&tda998x_2_input>;
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v5 2/2 drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500

Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.

QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the high resolutions flicker issue on the LS1028A platform.

---
 drivers/gpu/drm/arm/malidp_drv.c  |  6 ++++++
 drivers/gpu/drm/arm/malidp_hw.c   |  9 +++++++++
 drivers/gpu/drm/arm/malidp_hw.h   |  3 +++
 drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++
 4 files changed, 28 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +6 -0
index 333b88a5efb0..8a76315aaa0f 100644
@@ -817,6 +817,12 @@ static int malidp_bind(struct device *dev)
 
 	malidp->core_id = version;
 
+	ret = of_property_read_u32(dev->of_node,
+					"arm,malidp-arqos-value",
+					&hwdev->arqos_value);
+	if (ret)
+		hwdev->arqos_value = 0x0;
+
 	/* set the number of lines used for output of RGB data */
 	ret = of_property_read_u8_array(dev->of_node,
 					"arm,malidp-output-port-lines",
drivers/gpu/drm/arm/malidp_hw.c +9 -0
index bd8265f02e0b..ca570b135478 100644
@@ -379,6 +379,15 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *
 		malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED, MALIDP_DE_DISPLAY_FUNC);
 	else
 		malidp_hw_clearbits(hwdev, MALIDP_DISP_FUNC_ILACED, MALIDP_DE_DISPLAY_FUNC);
+
+	/*
+	 * Program the RQoS register to avoid high resolutions flicker
+	 * issue on the LS1028A.
+	 */
+	if (hwdev->arqos_value) {
+		val = hwdev->arqos_value;
+		malidp_hw_setbits(hwdev, val, MALIDP500_RQOS_QUALITY);
+	}
 }
 
 int malidp_format_get_bpp(u32 fmt)
drivers/gpu/drm/arm/malidp_hw.h +3 -0
index 968a65eed371..e4c36bc90bda 100644
@@ -251,6 +251,9 @@ struct malidp_hw_device {
 
 	/* size of memory used for rotating layers, up to two banks available */
 	u32 rotation_memory[2];
+
+	/* priority level of RQOS register used for driven the ARQOS signal */
+	u32 arqos_value;
 };
 
 static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32 reg)
drivers/gpu/drm/arm/malidp_regs.h +10 -0
index 993031542fa1..514c50dcb74d 100644
@@ -210,6 +210,16 @@
 #define MALIDP500_CONFIG_VALID		0x00f00
 #define MALIDP500_CONFIG_ID		0x00fd4
 
+/*
+ * The quality of service (QoS) register on the DP500. RQOS register values
+ * are driven by the ARQOS signal, using AXI transacations, dependent on the
+ * FIFO input level.
+ * The RQOS register can also set QoS levels for:
+ *    - RED_ARQOS   @ A 4-bit signal value for close to underflow conditions
+ *    - GREEN_ARQOS @ A 4-bit signal value for normal conditions
+ */
+#define MALIDP500_RQOS_QUALITY          0x00500
+
 /* register offsets and bits specific to DP550/DP650 */
 #define MALIDP550_ADDR_SPACE_SIZE	0x10000
 #define MALIDP550_DE_CONTROL		0x00010
Signature · 1 line
2.17.1
maintainer Acked-by on v5 2/2
#2 lore raw

Re: [v5 2/2] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500

Quoted 8 lines · Wen He

Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.

QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the high resolutions flicker issue on the LS1028A platform.

Thanks for the patch! I will pull this into the malidp code and push it to drm-misc-next in the following days.

Best regards,
Liviu

Quoted 82 lines
---
 drivers/gpu/drm/arm/malidp_drv.c  |  6 ++++++
 drivers/gpu/drm/arm/malidp_hw.c   |  9 +++++++++
 drivers/gpu/drm/arm/malidp_hw.h   |  3 +++
 drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++
 4 files changed, 28 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +6 -0
index 333b88a5efb0..8a76315aaa0f 100644
@@ -817,6 +817,12 @@ static int malidp_bind(struct device *dev)
 
 	malidp->core_id = version;
 
+	ret = of_property_read_u32(dev->of_node,
+					"arm,malidp-arqos-value",
+					&hwdev->arqos_value);
+	if (ret)
+		hwdev->arqos_value = 0x0;
+
 	/* set the number of lines used for output of RGB data */
 	ret = of_property_read_u8_array(dev->of_node,
 					"arm,malidp-output-port-lines",
drivers/gpu/drm/arm/malidp_hw.c +9 -0
index bd8265f02e0b..ca570b135478 100644
@@ -379,6 +379,15 @@ static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *
 		malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED, MALIDP_DE_DISPLAY_FUNC);
 	else
 		malidp_hw_clearbits(hwdev, MALIDP_DISP_FUNC_ILACED, MALIDP_DE_DISPLAY_FUNC);
+
+	/*
+	 * Program the RQoS register to avoid high resolutions flicker
+	 * issue on the LS1028A.
+	 */
+	if (hwdev->arqos_value) {
+		val = hwdev->arqos_value;
+		malidp_hw_setbits(hwdev, val, MALIDP500_RQOS_QUALITY);
+	}
 }
 
 int malidp_format_get_bpp(u32 fmt)
drivers/gpu/drm/arm/malidp_hw.h +3 -0
index 968a65eed371..e4c36bc90bda 100644
@@ -251,6 +251,9 @@ struct malidp_hw_device {
 
 	/* size of memory used for rotating layers, up to two banks available */
 	u32 rotation_memory[2];
+
+	/* priority level of RQOS register used for driven the ARQOS signal */
+	u32 arqos_value;
 };
 
 static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32 reg)
drivers/gpu/drm/arm/malidp_regs.h +10 -0
index 993031542fa1..514c50dcb74d 100644
@@ -210,6 +210,16 @@
 #define MALIDP500_CONFIG_VALID		0x00f00
 #define MALIDP500_CONFIG_ID		0x00fd4
 
+/*
+ * The quality of service (QoS) register on the DP500. RQOS register values
+ * are driven by the ARQOS signal, using AXI transacations, dependent on the
+ * FIFO input level.
+ * The RQOS register can also set QoS levels for:
+ *    - RED_ARQOS   @ A 4-bit signal value for close to underflow conditions
+ *    - GREEN_ARQOS @ A 4-bit signal value for normal conditions
+ */
+#define MALIDP500_RQOS_QUALITY          0x00500
+
 /* register offsets and bits specific to DP550/DP650 */
 #define MALIDP550_ADDR_SPACE_SIZE	0x10000
 #define MALIDP550_DE_CONTROL		0x00010
Signature · 1 line
2.17.1
Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
author
#3 lore raw

RE: [EXT] Re: [v5 2/2] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500

Quoted 24 lines

-----Original Message-----
From: Liviu Dudau <[email protected]>
Sent: 2019年9月12日 22:47
To: Wen He <[email protected]>
Cc: [email protected]; Brian Starkey <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>
Subject: [EXT] Re: [v5 2/2] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500

Caution: EXT Email

Quoted 7 lines · Wen He

Configure the display Quality of service (QoS) levels priority if the optional property node "arm,malidp-aqros-value" is defined in DTS file.

QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is driven from the "RQOS" register, so needed to program the RQOS register to avoid the high resolutions flicker issue on the LS1028A platform.

Quoted 6 lines
Quoted 1 line

Thanks for the patch! I will pull this into the malidp code and push it to drm-misc-next in the following days.

Thank you, Liviu.

Best Regards,
Wen

Quoted 108 lines

Best regards,
Liviu

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct

Quoted 31 lines
---
 drivers/gpu/drm/arm/malidp_drv.c  |  6 ++++++
 drivers/gpu/drm/arm/malidp_hw.c   |  9 +++++++++
 drivers/gpu/drm/arm/malidp_hw.h   |  3 +++
 drivers/gpu/drm/arm/malidp_regs.h | 10 ++++++++++
 4 files changed, 28 insertions(+)
drivers/gpu/drm/arm/malidp_drv.c +6 -0
index 333b88a5efb0..8a76315aaa0f 100644
@@ -817,6 +817,12 @@ static int malidp_bind(struct device *dev)
 
      malidp->core_id = version;
 
+     ret = of_property_read_u32(dev->of_node,
+                                     "arm,malidp-arqos-value",
+                                     &hwdev->arqos_value);
+     if (ret)
+             hwdev->arqos_value = 0x0;
+
      /* set the number of lines used for output of RGB data */
      ret = of_property_read_u8_array(dev->of_node,
                                      "arm,malidp-output-port-lines",
(quoted diff) +0 -0

b/drivers/gpu/drm/arm/malidp_hw.c index bd8265f02e0b..ca570b135478 100644

drivers/gpu/drm/arm/malidp_hw.c +0 -0
@@ -379,6 +379,15 @@ static void malidp500_modeset(struct

malidp_hw_device *hwdev, struct videomode *

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct · line 379

Quoted 1 line
drivers/gpu/drm/arm/malidp_hw.c +0 -0
              malidp_hw_setbits(hwdev, MALIDP_DISP_FUNC_ILACED,

MALIDP_DE_DISPLAY_FUNC);

drivers/gpu/drm/arm/malidp_hw.c static void malidp500_modeset(struct malidp_hw_device *hwdev, struct videomode *

Quoted 11 lines
drivers/gpu/drm/arm/malidp_hw.c +8 -0
      else
              malidp_hw_clearbits(hwdev, MALIDP_DISP_FUNC_ILACED,
 MALIDP_DE_DISPLAY_FUNC);
+
+     /*
+      * Program the RQoS register to avoid high resolutions flicker
+      * issue on the LS1028A.
+      */
+     if (hwdev->arqos_value) {
+             val = hwdev->arqos_value;
+             malidp_hw_setbits(hwdev, val,

MALIDP500_RQOS_QUALITY);

drivers/gpu/drm/arm/malidp_hw.h struct malidp_hw_device { · line 252

Quoted 12 lines
drivers/gpu/drm/arm/malidp_hw.c +1 -0
+     }
 }
 

int malidp_format_get_bpp(u32 fmt)

(quoted diff) +0 -0

b/drivers/gpu/drm/arm/malidp_hw.h index 968a65eed371..e4c36bc90bda 100644

drivers/gpu/drm/arm/malidp_hw.h +0 -0
@@ -251,6 +251,9 @@ struct malidp_hw_device {
 
      /* size of memory used for rotating layers, up to two banks available

*/

Quoted 14 lines
drivers/gpu/drm/arm/malidp_hw.h +3 -0
      u32 rotation_memory[2];
+
+     /* priority level of RQOS register used for driven the ARQOS signal */
+     u32 arqos_value;
 };
 
 static inline u32 malidp_hw_read(struct malidp_hw_device *hwdev, u32

reg) diff --git a/drivers/gpu/drm/arm/malidp_regs.h b/drivers/gpu/drm/arm/malidp_regs.h
index 993031542fa1..514c50dcb74d 100644

drivers/gpu/drm/arm/malidp_regs.h +0 -0
@@ -210,6 +210,16 @@
 #define MALIDP500_CONFIG_VALID               0x00f00

drivers/gpu/drm/arm/malidp_regs.h line 220

Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +8 -0
 #define MALIDP500_CONFIG_ID          0x00fd4
 
+/*
+ * The quality of service (QoS) register on the DP500. RQOS register
+values
+ * are driven by the ARQOS signal, using AXI transacations, dependent
+on the
+ * FIFO input level.
+ * The RQOS register can also set QoS levels for:
+ *    - RED_ARQOS   @ A 4-bit signal value for close to underflow

conditions

Quoted 10 lines
drivers/gpu/drm/arm/malidp_regs.h +4 -1
+ *    - GREEN_ARQOS @ A 4-bit signal value for normal conditions
+ */
+#define MALIDP500_RQOS_QUALITY          0x00500
+
 /* register offsets and bits specific to DP550/DP650 */
 #define MALIDP550_ADDR_SPACE_SIZE    0x10000
 #define MALIDP550_DE_CONTROL         0x00010
--

2.17.1

--
====================

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
#4 lore raw
In reply to Wen He
Quoted 6 lines · Wen He

Add optional property node 'arm,malidp-arqos-value' for the Mali DP500. This property describe the ARQoS levels of DP500's QoS signaling.

Liviu, I see you applied 2/2, but didn't apply this patch. Any particular reason, or just missed it?

Thanks,

Sean

Quoted 28 lines
---
 Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/display/arm,malidp.txt +3 -1
index 2f7870983ef1..7a97a2b48c2a 100644
@@ -37,6 +37,8 @@ Optional properties:
     Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
     to be used for the framebuffer; if not present, the framebuffer may
     be located anywhere in memory.
+  - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
+    levels of DP500's QoS signaling.
 
 
 Example:
@@ -54,6 +56,7 @@ Example:
                clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
                clock-names = "pxlclk", "mclk", "aclk", "pclk";
                arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
+               arm,malidp-arqos-high-level = <0xd000d000>;
                port {
                        dp0_output: endpoint {
                                remote-endpoint = <&tda998x_2_input>;
--

2.17.1