drm/i915: add port info to debugfs
Subsystems (2)
PATCH 1/1 drm/i915: add port info to debugfs
This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is printed too.
---
Thanks for your comments, Imre and Manasi. Here is v2:
- Use same port formatting as intel_tc_port_init (e.g. "C/TC#1")
- Fix typo in commit message
drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +10 -0
@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,static void intel_connector_info (struct seq_file *m,struct drm_connector *connector) { +struct drm_i915_private *i915 =to_i915 (connector->dev);struct intel_connector *intel_connector =to_intel_connector (connector);struct intel_encoder *intel_encoder = intel_connector->encoder;struct drm_display_mode *mode; +enum tc_port tc_port; seq_printf(m, "connector %d: type %s, status: %s\n", connector->base.id, connector->name,
@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m,if (!intel_encoder)return ; +if (intel_encoder->port !=PORT_NONE ) { +seq_printf (m,"\tport: %c" ,port_name (intel_encoder->port)); + tc_port =intel_port_to_tc (i915, intel_encoder->port); +if (tc_port !=PORT_TC_NONE ) +seq_printf (m,"/TC#%d" , tc_port +1 ); +seq_printf (m,"\n" ); + } +switch (connector->connector_type) {case DRM_MODE_CONNECTOR_DisplayPort:case DRM_MODE_CONNECTOR_eDP:
--
2.22.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Simon Ser
This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is printed too.
Signed-off-by Simon Ser <[email protected]>Cc Imre Deak <[email protected]>Cc Manasi Navare <[email protected]>
Looks ok to me:
Quoted 42 lines
---
Thanks for your comments, Imre and Manasi. Here is v2:
- Use same port formatting as
intel_tc_port_init(e.g. "C/TC#1")
- Fix typo in commit messagedrivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/gpu/drm/i915/i915_debugfs.c +10
-1@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,static void intel_connector_info (struct seq_file *m,struct drm_connector *connector) { +struct drm_i915_private *i915 =to_i915 (connector->dev);struct intel_connector *intel_connector =to_intel_connector (connector);struct intel_encoder *intel_encoder = intel_connector->encoder;struct drm_display_mode *mode; +enum tc_port tc_port; seq_printf(m, "connector %d: type %s, status: %s\n", connector->base.id, connector->name,@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m,if (!intel_encoder)return ; +if (intel_encoder->port !=PORT_NONE ) { +seq_printf (m,"\tport: %c" ,port_name (intel_encoder->port)); + tc_port =intel_port_to_tc (i915, intel_encoder->port); +if (tc_port !=PORT_TC_NONE ) +seq_printf (m,"/TC#%d" , tc_port +1 ); +seq_printf (m,"\n" ); + } +switch (connector->connector_type) {case DRM_MODE_CONNECTOR_DisplayPort:case DRM_MODE_CONNECTOR_eDP: --
Quoted 2 lines
2.22.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Jani Nikula
maintainerQuoted 7 lines · Simon Ser
This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is printed too.
Signed-off-by Simon Ser <[email protected]>Cc Imre Deak <[email protected]>Cc Manasi Navare <[email protected]>
Quoted 6 lines
---
Thanks for your comments, Imre and Manasi. Here is v2:
- Use same port formatting as
intel_tc_port_init(e.g. "C/TC#1")
- Fix typo in commit message
Usually in drm we put the patch changelog as part of the commit message.
Please resend the patch to intel-gfx@, and you'll get our CI results too.
BR,
Jani.
Quoted 42 lines
drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/gpu/drm/i915/i915_debugfs.c +10
-1@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,static void intel_connector_info (struct seq_file *m,struct drm_connector *connector) { +struct drm_i915_private *i915 =to_i915 (connector->dev);struct intel_connector *intel_connector =to_intel_connector (connector);struct intel_encoder *intel_encoder = intel_connector->encoder;struct drm_display_mode *mode; +enum tc_port tc_port; seq_printf(m, "connector %d: type %s, status: %s\n", connector->base.id, connector->name,@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m,if (!intel_encoder)return ; +if (intel_encoder->port !=PORT_NONE ) { +seq_printf (m,"\tport: %c" ,port_name (intel_encoder->port)); + tc_port =intel_port_to_tc (i915, intel_encoder->port); +if (tc_port !=PORT_TC_NONE ) +seq_printf (m,"/TC#%d" , tc_port +1 ); +seq_printf (m,"\n" ); + } +switch (connector->connector_type) {case DRM_MODE_CONNECTOR_DisplayPort:case DRM_MODE_CONNECTOR_eDP: --2.22.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 11 lines · Jani Nikula
Quoted 10 lines · Simon Ser
This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is
printed too.Signed-off-by Simon Ser <[email protected]>Cc Imre Deak <[email protected]>Cc Manasi Navare <[email protected]>---
Quoted 7 lines
Quoted 4 lines
Thanks for your comments, Imre and Manasi. Here is v2:
- Use same port formatting as
intel_tc_port_init(e.g. "C/TC#1")
- Fix typo in commit messageUsually in drm we put the patch changelog as part of the commit message.
Err, ack.
Quoted 2 lines
Please resend the patch to intel-gfx@, and you'll get our CI results too.
Yes, sorry about that. I've re-submitted the series here:
https://patchwork.freedesktop.org/series/65695/
Quoted 48 lines
BR,
Jani.Quoted 42 lines
drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/gpu/drm/i915/i915_debugfs.c +2
-0@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m, static void intel_connector_info(struct seq_file *m,struct drm_connector *connector) { +struct drm_i915_private *i915 =to_i915 (connector->dev);struct intel_connector *intel_connector =to_intel_connector (connector);struct intel_encoder *intel_encoder = intel_connector->encoder;struct drm_display_mode *mode; +enum tc_port tc_port;drivers/gpu/drm/i915/i915_debugfs.c +8
-0seq_printf(m, "connector %d: type %s, status: %s\n", connector->base.id, connector->name,@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m, if (!intel_encoder) return; +if (intel_encoder->port !=PORT_NONE ) { +seq_printf (m,"\tport: %c" ,port_name (intel_encoder- >port)); + tc_port =intel_port_to_tc (i915, intel_encoder->port); +if (tc_port !=PORT_TC_NONE ) +seq_printf (m,"/TC#%d" , tc_port +1 ); +seq_printf (m,"\n" ); + } +switch (connector->connector_type) {drivers/gpu/drm/i915/i915_debugfs.c +0
-1case DRM_MODE_CONNECTOR_DisplayPort:case DRM_MODE_CONNECTOR_eDP: --2.22.1
Quoted 4 lines
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel