Skip to contentSkip to conversation

drm/i915: add port info to debugfs

PATCH Superseded Simon Ser 3 participants 4 messages Aug 22, 2019 – Aug 26, 2019

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Simon Ser

author
#0 lore raw

PATCH 1/1 drm/i915: add port info to debugfs

This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is printed too.

Cc Imre Deak <[email protected]>
Cc Manasi Navare <[email protected]>

---

Thanks for your comments, Imre and Manasi. Here is v2:

- Use same port formatting as intel_tc_port_init (e.g. "C/TC#1")
- Fix typo in commit message

 drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +10 -0
index b39226d7f8d2..4ba508c954f8 100644
@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,
 static void intel_connector_info(struct seq_file *m,
 				 struct drm_connector *connector)
 {
+	struct drm_i915_private *i915 = to_i915(connector->dev);
 	struct intel_connector *intel_connector = to_intel_connector(connector);
 	struct intel_encoder *intel_encoder = intel_connector->encoder;
 	struct drm_display_mode *mode;
+	enum tc_port tc_port;
 
 	seq_printf(m, "connector %d: type %s, status: %s\n",
 		   connector->base.id, connector->name,
@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m,
 	if (!intel_encoder)
 		return;
 
+	if (intel_encoder->port != PORT_NONE) {
+		seq_printf(m, "\tport: %c", port_name(intel_encoder->port));
+		tc_port = intel_port_to_tc(i915, intel_encoder->port);
+		if (tc_port != PORT_TC_NONE)
+			seq_printf(m, "/TC#%d", tc_port + 1);
+		seq_printf(m, "\n");
+	}
+
 	switch (connector->connector_type) {
 	case DRM_MODE_CONNECTOR_DisplayPort:
 	case DRM_MODE_CONNECTOR_eDP:

--
2.22.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Simon Ser

This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is printed too.

Cc Imre Deak <[email protected]>
Cc Manasi Navare <[email protected]>

Looks ok to me:

Quoted 42 lines

---

Thanks for your comments, Imre and Manasi. Here is v2:

- Use same port formatting as intel_tc_port_init (e.g. "C/TC#1")
- Fix typo in commit message

 drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +10 -1
index b39226d7f8d2..4ba508c954f8 100644
@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,
 static void intel_connector_info(struct seq_file *m,
 				 struct drm_connector *connector)
 {
+	struct drm_i915_private *i915 = to_i915(connector->dev);
 	struct intel_connector *intel_connector = to_intel_connector(connector);
 	struct intel_encoder *intel_encoder = intel_connector->encoder;
 	struct drm_display_mode *mode;
+	enum tc_port tc_port;
 
 	seq_printf(m, "connector %d: type %s, status: %s\n",
 		   connector->base.id, connector->name,
@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m,
 	if (!intel_encoder)
 		return;
 
+	if (intel_encoder->port != PORT_NONE) {
+		seq_printf(m, "\tport: %c", port_name(intel_encoder->port));
+		tc_port = intel_port_to_tc(i915, intel_encoder->port);
+		if (tc_port != PORT_TC_NONE)
+			seq_printf(m, "/TC#%d", tc_port + 1);
+		seq_printf(m, "\n");
+	}
+
 	switch (connector->connector_type) {
 	case DRM_MODE_CONNECTOR_DisplayPort:
 	case DRM_MODE_CONNECTOR_eDP:
--
Quoted 2 lines

2.22.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#2 lore raw
In reply to Simon Ser
Quoted 7 lines · Simon Ser

This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is printed too.

Cc Imre Deak <[email protected]>
Cc Manasi Navare <[email protected]>
Quoted 6 lines

---

Thanks for your comments, Imre and Manasi. Here is v2:

- Use same port formatting as intel_tc_port_init (e.g. "C/TC#1")
- Fix typo in commit message

Usually in drm we put the patch changelog as part of the commit message.

Please resend the patch to intel-gfx@, and you'll get our CI results too.

BR,
Jani.

Quoted 42 lines
 drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +10 -1
index b39226d7f8d2..4ba508c954f8 100644
@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,
 static void intel_connector_info(struct seq_file *m,
 				 struct drm_connector *connector)
 {
+	struct drm_i915_private *i915 = to_i915(connector->dev);
 	struct intel_connector *intel_connector = to_intel_connector(connector);
 	struct intel_encoder *intel_encoder = intel_connector->encoder;
 	struct drm_display_mode *mode;
+	enum tc_port tc_port;
 
 	seq_printf(m, "connector %d: type %s, status: %s\n",
 		   connector->base.id, connector->name,
@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m,
 	if (!intel_encoder)
 		return;
 
+	if (intel_encoder->port != PORT_NONE) {
+		seq_printf(m, "\tport: %c", port_name(intel_encoder->port));
+		tc_port = intel_port_to_tc(i915, intel_encoder->port);
+		if (tc_port != PORT_TC_NONE)
+			seq_printf(m, "/TC#%d", tc_port + 1);
+		seq_printf(m, "\n");
+	}
+
 	switch (connector->connector_type) {
 	case DRM_MODE_CONNECTOR_DisplayPort:
 	case DRM_MODE_CONNECTOR_eDP:
--

2.22.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author
#3 lore raw
Quoted 11 lines · Jani Nikula
Quoted 10 lines · Simon Ser

This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is
printed too.

Cc Imre Deak <[email protected]>
Cc Manasi Navare <[email protected]>

---

Quoted 7 lines
Quoted 4 lines

Thanks for your comments, Imre and Manasi. Here is v2:

- Use same port formatting as intel_tc_port_init (e.g. "C/TC#1")
- Fix typo in commit message

Usually in drm we put the patch changelog as part of the commit message.

Err, ack.

Quoted 2 lines

Please resend the patch to intel-gfx@, and you'll get our CI results too.

Yes, sorry about that. I've re-submitted the series here:
https://patchwork.freedesktop.org/series/65695/

Quoted 48 lines

BR,
Jani.

Quoted 42 lines
 drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +2 -0
index b39226d7f8d2..4ba508c954f8 100644
@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file
 *m,
 static void intel_connector_info(struct seq_file *m,
 				 struct drm_connector *connector)
 {
+	struct drm_i915_private *i915 = to_i915(connector->dev);
 	struct intel_connector *intel_connector =
 to_intel_connector(connector);
 	struct intel_encoder *intel_encoder = intel_connector->encoder;
 	struct drm_display_mode *mode;
+	enum tc_port tc_port;
 
drivers/gpu/drm/i915/i915_debugfs.c +8 -0
 	seq_printf(m, "connector %d: type %s, status: %s\n",
 		   connector->base.id, connector->name,
@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct
 seq_file *m,
 	if (!intel_encoder)
 		return;
 
+	if (intel_encoder->port != PORT_NONE) {
+		seq_printf(m, "\tport: %c", port_name(intel_encoder-
 >port));
+		tc_port = intel_port_to_tc(i915, intel_encoder->port);
+		if (tc_port != PORT_TC_NONE)
+			seq_printf(m, "/TC#%d", tc_port + 1);
+		seq_printf(m, "\n");
+	}
+
 	switch (connector->connector_type) {
drivers/gpu/drm/i915/i915_debugfs.c +0 -1
 	case DRM_MODE_CONNECTOR_DisplayPort:
 	case DRM_MODE_CONNECTOR_eDP:
--

2.22.1

Quoted 4 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel