PCI: tegra: Enable PCIe C5 controller of Tegra194 in p2972-0000 platform
Subsystems (5)
v3 cover PCI: tegra: Enable PCIe C5 controller of Tegra194 in p2972-0000 platform
This patch series enables Tegra194's C5 controller which owns x16 slot in p2972-0000 platform. C5 controller's PERST# and CLKREQ# are not configured as output and bi-directional signals by default and hence they need to be configured explicitly. Also, x16 slot's 3.3V and 12V supplies are controlled through GPIOs and hence they need to be enabled through regulator framework. This patch series adds required infrastructural support to address both the aforementioned requirements.
Testing done on p2972-0000 platform
- Able to enumerate devices connected to x16 slot (owned by C5 controller)
- Enumerated device's functionality verified
- Suspend-Resume sequence is verified with device connected to x16 slot
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1567013340; bh=TvQY7ZhhxcvoKbpcEAh6qHqIQEasISWH+/X/STdQQk0=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=gVtBiB2IR+pKYaZJQ+f6BYQX23e2leD7q8vdf+vr0+12GlPQc/30oFhIDgzGmLr3W 81mgV2Pp3bLNf9oNOB7tnv+yjoJK+qPGAB0bQ+VPMKGOkpvVfFtN4K3D+TkNjEQnQc eBs35Pzc7zQ3jso4y80hoeIGegqfu4qLvORCW3qsy7OuPxjELUpGKvJTozekRSZVw3 voa570Uvaiotu9UgYqdAyJe0S4iuNUmJ8eWJDZLb9zkj1gfWhuQaDxt6bOMK8pyr7e SVhNP0p2cTOaV0ALtd16tvi7+vRmcV4uQeArl0l1XPwxwHkR6ShLYbyji3Zb+JxJGN vrTsP917B385w==
V3:
* Addressed some more review comments from Andrew Murray and Thierry Reding
V2:
* Changed the order of patches in the series for easy merging
* Addressed review comments from Thierry Reding and Andrew Murray
Vidya Sagar (6):
dt-bindings: PCI: tegra: Add sideband pins configuration entries
dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
PCI: tegra: Add support to configure sideband pins
PCI: tegra: Add support to enable slot regulators
arm64: tegra: Add configuration for PCIe C5 sideband signals
arm64: tegra: Add PCIe slot supply information in p2972-0000 platform
.../bindings/pci/nvidia,tegra194-pcie.txt | 16 ++++ .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 24 +++++ .../boot/dts/nvidia/tegra194-p2972-0000.dts | 4 +- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 38 +++++++- drivers/pci/controller/dwc/pcie-tegra194.c | 94 ++++++++++++++++++- 5 files changed, 172 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
PATCH v3 1/6 dt-bindings: PCI: tegra: Add sideband pins configuration entries
Add optional bindings "pinctrl-names" and "pinctrl-0" to describe pin configuration information of a particular PCIe controller.
---
V3:
* None
V2:
* None
.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +8 -0
@@ -83,6 +83,11 @@ Required properties: - vddio-pex-ctl-supply: Regulator supply for PCIe side band signals Optional properties: +- pinctrl-names: A list of pinctrl state names. + It is mandatory for C5 controller and optional for other controllers. + - "default": Configures PCIe I/O for proper operation. +- pinctrl-0: phandle for the 'default' state of pin configuration. + It is mandatory for C5 controller and optional for other controllers. - supports-clkreq: Refer to Documentation/devicetree/bindings/pci/pci.txt - nvidia,update-fc-fixup: This is a boolean property and needs to be present to improve performance when a platform is designed in such a way that it
@@ -120,6 +125,9 @@ Tegra194: num-lanes = <8>; linux,pci-domain = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; + clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; clock-names = "core";
Signature · 1 line
2.17.1
Re: [PATCH V3 1/6] dt-bindings: PCI: tegra: Add sideband pins configuration entries
Quoted 4 lines · Vidya Sagar
Add optional bindings "pinctrl-names" and "pinctrl-0" to describe pin configuration information of a particular PCIe controller.
Signed-off-by Vidya Sagar <[email protected]>
Quoted 39 lines
---
V3:
* NoneV2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +8
-0@@ -83,6 +83,11 @@ Required properties: - vddio-pex-ctl-supply: Regulator supply for PCIe side band signals Optional properties: +- pinctrl-names: A list of pinctrl state names. + It is mandatory for C5 controller and optional for other controllers. + - "default": Configures PCIe I/O for proper operation. +- pinctrl-0: phandle for the 'default' state of pin configuration. + It is mandatory for C5 controller and optional for other controllers. - supports-clkreq: Refer to Documentation/devicetree/bindings/pci/pci.txt - nvidia,update-fc-fixup: This is a boolean property and needs to be present to improve performance when a platform is designed in such a way that it@@ -120,6 +125,9 @@ Tegra194: num-lanes = <8>; linux,pci-domain = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; + clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; clock-names = "core";Signature · 1 line
2.17.1
Re: [PATCH V3 1/6] dt-bindings: PCI: tegra: Add sideband pins configuration entries
In reply to Vidya SagarQuoted 8 lines · Vidya Sagar
Add optional bindings "pinctrl-names" and "pinctrl-0" to describe pin configuration information of a particular PCIe controller.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* None
Quoted 5 lines
V2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
Re: [PATCH V3 1/6] dt-bindings: PCI: tegra: Add sideband pins configuration entries
In reply to Vidya SagarQuoted 8 lines · Vidya Sagar
Add optional bindings "pinctrl-names" and "pinctrl-0" to describe pin configuration information of a particular PCIe controller.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* None
Quoted 6 lines
V2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
PATCH v3 2/6 dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
In reply to Vidya SagarAdd optional bindings "vpcie3v3-supply" and "vpcie12v-supply" to describe regulators of a PCIe slot's supplies 3.3V and 12V provided the platform is designed to have regulator controlled slot supplies.
---
V3:
* None
V2:
* None
.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +8 -0
@@ -104,6 +104,12 @@ Optional properties: specified in microseconds - nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be specified in microseconds +- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller + in p2972-0000 platform). +- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller + in p2972-0000 platform). Examples: =========
@@ -156,6 +162,8 @@ Tegra194: 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ vddio-pex-ctl-supply = <&vdd_1v8ao>; + vpcie3v3-supply = <&vdd_3v3_pcie>; + vpcie12v-supply = <&vdd_12v_pcie>; phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, <&p2u_hsio_5>;
Signature · 1 line
2.17.1
Re: [PATCH V3 2/6] dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
Quoted 20 lines · Vidya Sagar
Add optional bindings "vpcie3v3-supply" and "vpcie12v-supply" to describe regulators of a PCIe slot's supplies 3.3V and 12V provided the platform is designed to have regulator controlled slot supplies.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* NoneV2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +0
-0
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt Optional properties: · line 112
Quoted 9 lines
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +6
-0@@ -104,6 +104,12 @@ Optional properties: specified in microseconds - nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be specified in microseconds +- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller + in p2972-0000 platform). +- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller + in p2972-0000 platform).
There's an ongoing discussion regarding the use of optional power supplies and I'm wondering if we're not abusing this here. Why exactly are these regulators optional?
The distinction is somewhat subtle, but the other way to look at modelling this in DT is that the supplies are in fact required, but may be connected to an always-on regulator with a fixed voltage. Or in some cases they may also be shorted to ground. In both cases the PCI controller, or rather the slot that the controller connects to, actually "requires" the supplies, it's just that we can get away without describing them because they can't be controlled anyway.
Looking at the PCI connector pinout for PCI Express, I do see a bunch of +3.3 V and +12 V pins. To me that indicates that the 3.3 V and 12 V supplies are indeed required for PCI slots. I'm not sure about devices that are directly connected to the PCI controller, though. I'll need to go look at some schematics to get a better understanding of these.
Bottom line: I'm wondering if we shouldn't really make these supplies mandatory and in case where we don't care either just leave them away (the regulator framework will supply a dummy regulator in that case) or hook them up to a fixed regulator if that matches the hardware design.
Any thoughts?
Thierry
Quoted 15 lines
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +2
-0Examples: =========@@ -156,6 +162,8 @@ Tegra194: 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ vddio-pex-ctl-supply = <&vdd_1v8ao>; + vpcie3v3-supply = <&vdd_3v3_pcie>; + vpcie12v-supply = <&vdd_12v_pcie>; phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, <&p2u_hsio_5>;Signature · 1 line
2.17.1
Re: [PATCH V3 2/6] dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
Quoted 26 lines · Thierry Reding
Quoted 25 lines · Vidya Sagar
Add optional bindings "vpcie3v3-supply" and "vpcie12v-supply" to describe regulators of a PCIe slot's supplies 3.3V and 12V provided the platform is designed to have regulator controlled slot supplies.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* NoneV2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +2
-0@@ -104,6 +104,12 @@ Optional properties: specified in microseconds - nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be specified in microseconds +- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller
Quoted 8 lines
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt Optional properties: · line 112
Quoted 4 lines
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +4
-0+ in p2972-0000 platform). +- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller + in p2972-0000 platform).There's an ongoing discussion regarding the use of optional power supplies and I'm wondering if we're not abusing this here. Why exactly are these regulators optional?
I made them optional because, the number and type of supplies typically depend on the kind of slot the controller is owning. If it is a CEM slot, then, it needs 3.3V & 12V supplies and if it is an M.2 Key-E/M slot, it needs only 3.3V supply. Also, if there are on-board PCIe endpoint devices, supplies may vary again from vendor to vendor. Considering all these, I made them optional instead of mandatory.
Also, I agree that regulator framework supplies a dummy regulator if we make them mandatory but doesn't supply one, but it does so with a warning print in the log which I feel is an unwanted alert and to avoid that one has to supply dummy/fixed regulators which again seems an overkill when all of this can be addressed by making slot regulators optional.
Quoted 39 lines
The distinction is somewhat subtle, but the other way to look at modelling this in DT is that the supplies are in fact required, but may be connected to an always-on regulator with a fixed voltage. Or in some cases they may also be shorted to ground. In both cases the PCI controller, or rather the slot that the controller connects to, actually "requires" the supplies, it's just that we can get away without describing them because they can't be controlled anyway.
Looking at the PCI connector pinout for PCI Express, I do see a bunch of +3.3 V and +12 V pins. To me that indicates that the 3.3 V and 12 V supplies are indeed required for PCI slots. I'm not sure about devices that are directly connected to the PCI controller, though. I'll need to go look at some schematics to get a better understanding of these.
Bottom line: I'm wondering if we shouldn't really make these supplies mandatory and in case where we don't care either just leave them away (the regulator framework will supply a dummy regulator in that case) or hook them up to a fixed regulator if that matches the hardware design.
Any thoughts?
Thierry
Quoted 15 lines
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +2
-0Examples: =========@@ -156,6 +162,8 @@ Tegra194: 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ vddio-pex-ctl-supply = <&vdd_1v8ao>; + vpcie3v3-supply = <&vdd_3v3_pcie>; + vpcie12v-supply = <&vdd_12v_pcie>; phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, <&p2u_hsio_5>;Signature · 1 line
2.17.1
Re: [PATCH V3 2/6] dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
Quoted 35 lines · Vidya Sagar
Quoted 26 lines · Thierry Reding
Quoted 25 lines · Vidya Sagar
Add optional bindings "vpcie3v3-supply" and "vpcie12v-supply" to describe regulators of a PCIe slot's supplies 3.3V and 12V provided the platform is designed to have regulator controlled slot supplies.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* NoneV2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +2
-0@@ -104,6 +104,12 @@ Optional properties: specified in microseconds - nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be specified in microseconds +- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controllerQuoted 8 lines
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt Optional properties: · line 112
Quoted 4 lines
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +4
-0+ in p2972-0000 platform). +- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller + in p2972-0000 platform).There's an ongoing discussion regarding the use of optional power supplies and I'm wondering if we're not abusing this here. Why exactly are these regulators optional?
Quoted 9 lines
I made them optional because, the number and type of supplies typically depend on the kind of slot the controller is owning. If it is a CEM slot, then, it needs 3.3V & 12V supplies and if it is an M.2 Key-E/M slot, it needs only 3.3V supply. Also, if there are on-board PCIe endpoint devices, supplies may vary again from vendor to vendor. Considering all these, I made them optional instead of mandatory.
Also, I agree that regulator framework supplies a dummy regulator if we make them mandatory but doesn't supply one, but it does so with a warning print in the log which I feel is an unwanted alert and to avoid that one has to supply dummy/fixed regulators which again seems an overkill when all of this can be addressed by making slot regulators optional.
Okay. That sounds like a good reason to make these optional indeed. There is no way for the PCI controller to know exactly which regulators will be needed. The only case where it is known is that of the regular PCIe slot where the 3.3 V and 12 V are mandatory. But since it isn't always a standard PCIe slot that the controller drives, I think optional is okay in this case.
Thierry
Quoted 36 lines
Quoted 35 lines
The distinction is somewhat subtle, but the other way to look at modelling this in DT is that the supplies are in fact required, but may be connected to an always-on regulator with a fixed voltage. Or in some cases they may also be shorted to ground. In both cases the PCI controller, or rather the slot that the controller connects to, actually "requires" the supplies, it's just that we can get away without describing them because they can't be controlled anyway.
Looking at the PCI connector pinout for PCI Express, I do see a bunch of +3.3 V and +12 V pins. To me that indicates that the 3.3 V and 12 V supplies are indeed required for PCI slots. I'm not sure about devices that are directly connected to the PCI controller, though. I'll need to go look at some schematics to get a better understanding of these.
Bottom line: I'm wondering if we shouldn't really make these supplies mandatory and in case where we don't care either just leave them away (the regulator framework will supply a dummy regulator in that case) or hook them up to a fixed regulator if that matches the hardware design.
Any thoughts?
Thierry
Quoted 12 lines
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +2
-0Examples: =========@@ -156,6 +162,8 @@ Tegra194: 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ vddio-pex-ctl-supply = <&vdd_1v8ao>; + vpcie3v3-supply = <&vdd_3v3_pcie>; + vpcie12v-supply = <&vdd_12v_pcie>; phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, <&p2u_hsio_5>;Signature · 1 line
2.17.1
Re: [PATCH V3 2/6] dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
In reply to Vidya SagarQuoted 5 lines · Vidya Sagar
Add optional bindings "vpcie3v3-supply" and "vpcie12v-supply" to describe regulators of a PCIe slot's supplies 3.3V and 12V provided the platform is designed to have regulator controlled slot supplies.
Signed-off-by Vidya Sagar <[email protected]>
Quoted 39 lines
---
V3:
* NoneV2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +8
-0@@ -104,6 +104,12 @@ Optional properties: specified in microseconds - nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be specified in microseconds +- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller + in p2972-0000 platform). +- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot + if the platform has one such slot. (Ex:- x16 slot owned by C5 controller + in p2972-0000 platform). Examples: =========@@ -156,6 +162,8 @@ Tegra194: 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ vddio-pex-ctl-supply = <&vdd_1v8ao>; + vpcie3v3-supply = <&vdd_3v3_pcie>; + vpcie12v-supply = <&vdd_12v_pcie>; phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, <&p2u_hsio_5>;Signature · 1 line
2.17.1
Re: [PATCH V3 2/6] dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
In reply to Vidya SagarQuoted 9 lines · Vidya Sagar
Add optional bindings "vpcie3v3-supply" and "vpcie12v-supply" to describe regulators of a PCIe slot's supplies 3.3V and 12V provided the platform is designed to have regulator controlled slot supplies.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* None
Quoted 5 lines
V2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
Re: [PATCH V3 2/6] dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
In reply to Vidya SagarQuoted 9 lines · Vidya Sagar
Add optional bindings "vpcie3v3-supply" and "vpcie12v-supply" to describe regulators of a PCIe slot's supplies 3.3V and 12V provided the platform is designed to have regulator controlled slot supplies.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* None
Quoted 6 lines
V2:
* None.../devicetree/bindings/pci/nvidia,tegra194-pcie.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
PATCH v3 3/6 PCI: tegra: Add support to configure sideband pins
In reply to Vidya SagarAdd support to configure sideband signal pins when information is present in respective controller's device-tree node.
---
V3:
* Used 'dev' instead of 'pcie->dev'
V2:
* Addressed review comment from Andrew Murray
* Handled failure case of pinctrl_pm_select_default_state() cleanly
drivers/pci/controller/dwc/pcie-tegra194.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/pci/controller/dwc/pcie-tegra194.c +9 -2
@@ -1304,8 +1304,13 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie)if (ret <0 ) {dev_err (dev,"Failed to get runtime sync for PCIe dev: %d\n" , ret); -pm_runtime_disable (dev); -return ret; + goto fail_pm_get_sync; + } + + ret =pinctrl_pm_select_default_state (dev); +if (ret <0 ) { +dev_err (dev,"Failed to configure sideband pins: %d\n" , ret); + goto fail_pinctrl; }tegra_pcie_init_controller (pcie);
@@ -1332,7 +1337,9 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie) fail_host_init:tegra_pcie_deinit_controller (pcie); +fail_pinctrl:pm_runtime_put_sync (dev); +fail_pm_get_sync:pm_runtime_disable (dev);return ret; }
Signature · 1 line
2.17.1
Re: [PATCH V3 3/6] PCI: tegra: Add support to configure sideband pins
Quoted 4 lines · Vidya Sagar
Add support to configure sideband signal pins when information is present in respective controller's device-tree node.
Signed-off-by Vidya Sagar <[email protected]>
Quoted 44 lines
---
V3:
* Used 'dev' instead of 'pcie->dev'V2:
* Addressed review comment from Andrew Murray
* Handled failure case ofpinctrl_pm_select_default_state()cleanlydrivers/pci/controller/dwc/pcie-tegra194.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)drivers/pci/controller/dwc/pcie-tegra194.c +9
-2@@ -1304,8 +1304,13 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie)if (ret <0 ) {dev_err (dev,"Failed to get runtime sync for PCIe dev: %d\n" , ret); -pm_runtime_disable (dev); -return ret; + goto fail_pm_get_sync; + } + + ret =pinctrl_pm_select_default_state (dev); +if (ret <0 ) { +dev_err (dev,"Failed to configure sideband pins: %d\n" , ret); + goto fail_pinctrl; }tegra_pcie_init_controller (pcie);@@ -1332,7 +1337,9 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie) fail_host_init:tegra_pcie_deinit_controller (pcie); +fail_pinctrl:pm_runtime_put_sync (dev); +fail_pm_get_sync:pm_runtime_disable (dev);return ret; }Signature · 1 line
2.17.1
Re: [PATCH V3 3/6] PCI: tegra: Add support to configure sideband pins
In reply to Vidya SagarQuoted 8 lines · Vidya Sagar
Add support to configure sideband signal pins when information is present in respective controller's device-tree node.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* Used 'dev' instead of 'pcie->dev'
Quoted 6 lines
V2:
* Addressed review comment from Andrew Murray
* Handled failure case ofpinctrl_pm_select_default_state()cleanlydrivers/pci/controller/dwc/pcie-tegra194.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
PATCH v3 4/6 PCI: tegra: Add support to enable slot regulators
In reply to Vidya SagarAdd support to get regulator information of 3.3V and 12V supplies of a PCIe slot from the respective controller's device-tree node and enable those supplies. This is required in platforms like p2972-0000 where the supplies to x16 slot owned by C5 controller need to be enabled before attempting to enumerate the devices.
---
V3:
* Added a dev_err() print for failure case of tegra_pcie_get_slot_regulators() API
* Modified to make 100ms sleep valid only if at least one of the regulator handles exist
V2:
* Addressed review comments from Thierry Reding and Andrew Murray
* Handled failure case of devm_regulator_get_optional() for -ENODEV cleanly
drivers/pci/controller/dwc/pcie-tegra194.c | 83 ++++++++++++++++++++++ 1 file changed, 83 insertions(+)
drivers/pci/controller/dwc/pcie-tegra194.c +83 -0
@@ -278,6 +278,8 @@ struct tegra_pcie_dw {u32 aspm_l0s_enter_lat;struct regulator *pex_ctl_supply; +struct regulator *slot_ctl_3v3; +struct regulator *slot_ctl_12v;unsigned int phy_count;struct phy **phys;
@@ -1047,6 +1049,73 @@ static void tegra_pcie_downstream_dev_to_D0(struct tegra_pcie_dw *pcie) } } +static int tegra_pcie_get_slot_regulators (struct tegra_pcie_dw *pcie) +{ + pcie->slot_ctl_3v3 =devm_regulator_get_optional (pcie->dev,"vpcie3v3" ); +if (IS_ERR (pcie->slot_ctl_3v3)) { +if (PTR_ERR (pcie->slot_ctl_3v3) != -ENODEV ) +return PTR_ERR (pcie->slot_ctl_3v3); + + pcie->slot_ctl_3v3 =NULL ; + } + + pcie->slot_ctl_12v =devm_regulator_get_optional (pcie->dev,"vpcie12v" ); +if (IS_ERR (pcie->slot_ctl_12v)) { +if (PTR_ERR (pcie->slot_ctl_12v) != -ENODEV ) +return PTR_ERR (pcie->slot_ctl_12v); + + pcie->slot_ctl_12v =NULL ; + } + +return 0 ; +} + +static int tegra_pcie_enable_slot_regulators (struct tegra_pcie_dw *pcie) +{ +int ret; + +if (pcie->slot_ctl_3v3) { + ret =regulator_enable (pcie->slot_ctl_3v3); +if (ret <0 ) { +dev_err (pcie->dev, +"Failed to enable 3.3V slot supply: %d\n" , ret); +return ret; + } + } + +if (pcie->slot_ctl_12v) { + ret =regulator_enable (pcie->slot_ctl_12v); +if (ret <0 ) { +dev_err (pcie->dev, +"Failed to enable 12V slot supply: %d\n" , ret); + goto fail_12v_enable; + } + } + +/* +* According to PCI Express Card Electromechanical Specification +* Revision 1.1, Table-2.4, T_PVPERL (Power stable to PERST# inactive) +* should be a minimum of 100ms. +*/ +if (pcie->slot_ctl_3v3 || pcie->slot_ctl_12v) +msleep (100 ); + +return 0 ; + +fail_12v_enable: +if (pcie->slot_ctl_3v3) +regulator_disable (pcie->slot_ctl_3v3); +return ret; +} + +static void tegra_pcie_disable_slot_regulators (struct tegra_pcie_dw *pcie) +{ +if (pcie->slot_ctl_12v) +regulator_disable (pcie->slot_ctl_12v); +if (pcie->slot_ctl_3v3) +regulator_disable (pcie->slot_ctl_3v3); +} +static int tegra_pcie_config_controller (struct tegra_pcie_dw *pcie,bool en_hw_hot_rst) {
@@ -1060,6 +1129,10 @@ static int tegra_pcie_config_controller(struct tegra_pcie_dw *pcie,return ret; } + ret =tegra_pcie_enable_slot_regulators (pcie); +if (ret <0 ) + goto fail_slot_reg_en; + ret =regulator_enable (pcie->pex_ctl_supply);if (ret <0 ) {dev_err (pcie->dev,"Failed to enable regulator: %d\n" , ret);
@@ -1142,6 +1215,8 @@ static int tegra_pcie_config_controller(struct tegra_pcie_dw *pcie, fail_core_clk:regulator_disable (pcie->pex_ctl_supply); fail_reg_en: +tegra_pcie_disable_slot_regulators (pcie); +fail_slot_reg_en:tegra_pcie_bpmp_set_ctrl_state (pcie, false);return ret;
@@ -1174,6 +1249,8 @@ static int __deinit_controller(struct tegra_pcie_dw *pcie)return ret; } +tegra_pcie_disable_slot_regulators (pcie); + ret =tegra_pcie_bpmp_set_ctrl_state (pcie, false);if (ret) { dev_err(pcie->dev, "Failed to disable controller %d: %d\n",
@@ -1373,6 +1450,12 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)return ret; } + ret =tegra_pcie_get_slot_regulators (pcie); +if (ret <0 ) { +dev_err (dev,"Failed to get slot regulators: %d\n" , ret); +return ret; + } + pcie->pex_ctl_supply =devm_regulator_get (dev,"vddio-pex-ctl" );if (IS_ERR (pcie->pex_ctl_supply)) { dev_err(dev, "Failed to get regulator: %ld\n",
Signature · 1 line
2.17.1
Re: [PATCH V3 4/6] PCI: tegra: Add support to enable slot regulators
Quoted 7 lines · Vidya Sagar
Add support to get regulator information of 3.3V and 12V supplies of a PCIe slot from the respective controller's device-tree node and enable those supplies. This is required in platforms like p2972-0000 where the supplies to x16 slot owned by C5 controller need to be enabled before attempting to enumerate the devices.
Signed-off-by Vidya Sagar <[email protected]>
Quoted 144 lines
---
V3:
* Added adev_err()print for failure case oftegra_pcie_get_slot_regulators()API
* Modified to make 100ms sleep valid only if at least one of the regulator handles existV2:
* Addressed review comments from Thierry Reding and Andrew Murray
* Handled failure case ofdevm_regulator_get_optional()for-ENODEVcleanlydrivers/pci/controller/dwc/pcie-tegra194.c | 83 ++++++++++++++++++++++ 1 file changed, 83 insertions(+)drivers/pci/controller/dwc/pcie-tegra194.c +83
-0@@ -278,6 +278,8 @@ struct tegra_pcie_dw {u32 aspm_l0s_enter_lat;struct regulator *pex_ctl_supply; +struct regulator *slot_ctl_3v3; +struct regulator *slot_ctl_12v;unsigned int phy_count;struct phy **phys;@@ -1047,6 +1049,73 @@ static void tegra_pcie_downstream_dev_to_D0(struct tegra_pcie_dw *pcie) } } +static int tegra_pcie_get_slot_regulators (struct tegra_pcie_dw *pcie) +{ + pcie->slot_ctl_3v3 =devm_regulator_get_optional (pcie->dev,"vpcie3v3" ); +if (IS_ERR (pcie->slot_ctl_3v3)) { +if (PTR_ERR (pcie->slot_ctl_3v3) != -ENODEV ) +return PTR_ERR (pcie->slot_ctl_3v3); + + pcie->slot_ctl_3v3 =NULL ; + } + + pcie->slot_ctl_12v =devm_regulator_get_optional (pcie->dev,"vpcie12v" ); +if (IS_ERR (pcie->slot_ctl_12v)) { +if (PTR_ERR (pcie->slot_ctl_12v) != -ENODEV ) +return PTR_ERR (pcie->slot_ctl_12v); + + pcie->slot_ctl_12v =NULL ; + } + +return 0 ; +} + +static int tegra_pcie_enable_slot_regulators (struct tegra_pcie_dw *pcie) +{ +int ret; + +if (pcie->slot_ctl_3v3) { + ret =regulator_enable (pcie->slot_ctl_3v3); +if (ret <0 ) { +dev_err (pcie->dev, +"Failed to enable 3.3V slot supply: %d\n" , ret); +return ret; + } + } + +if (pcie->slot_ctl_12v) { + ret =regulator_enable (pcie->slot_ctl_12v); +if (ret <0 ) { +dev_err (pcie->dev, +"Failed to enable 12V slot supply: %d\n" , ret); + goto fail_12v_enable; + } + } + +/* +* According to PCI Express Card Electromechanical Specification +* Revision 1.1, Table-2.4, T_PVPERL (Power stable to PERST# inactive) +* should be a minimum of 100ms. +*/ +if (pcie->slot_ctl_3v3 || pcie->slot_ctl_12v) +msleep (100 ); + +return 0 ; + +fail_12v_enable: +if (pcie->slot_ctl_3v3) +regulator_disable (pcie->slot_ctl_3v3); +return ret; +} + +static void tegra_pcie_disable_slot_regulators (struct tegra_pcie_dw *pcie) +{ +if (pcie->slot_ctl_12v) +regulator_disable (pcie->slot_ctl_12v); +if (pcie->slot_ctl_3v3) +regulator_disable (pcie->slot_ctl_3v3); +} +static int tegra_pcie_config_controller (struct tegra_pcie_dw *pcie,bool en_hw_hot_rst) {@@ -1060,6 +1129,10 @@ static int tegra_pcie_config_controller(struct tegra_pcie_dw *pcie,return ret; } + ret =tegra_pcie_enable_slot_regulators (pcie); +if (ret <0 ) + goto fail_slot_reg_en; + ret =regulator_enable (pcie->pex_ctl_supply);if (ret <0 ) {dev_err (pcie->dev,"Failed to enable regulator: %d\n" , ret);@@ -1142,6 +1215,8 @@ static int tegra_pcie_config_controller(struct tegra_pcie_dw *pcie, fail_core_clk:regulator_disable (pcie->pex_ctl_supply); fail_reg_en: +tegra_pcie_disable_slot_regulators (pcie); +fail_slot_reg_en:tegra_pcie_bpmp_set_ctrl_state (pcie, false);return ret;@@ -1174,6 +1249,8 @@ static int __deinit_controller(struct tegra_pcie_dw *pcie)return ret; } +tegra_pcie_disable_slot_regulators (pcie); + ret =tegra_pcie_bpmp_set_ctrl_state (pcie, false);if (ret) { dev_err(pcie->dev, "Failed to disable controller %d: %d\n",@@ -1373,6 +1450,12 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)return ret; } + ret =tegra_pcie_get_slot_regulators (pcie); +if (ret <0 ) { +dev_err (dev,"Failed to get slot regulators: %d\n" , ret); +return ret; + } + pcie->pex_ctl_supply =devm_regulator_get (dev,"vddio-pex-ctl" );if (IS_ERR (pcie->pex_ctl_supply)) { dev_err(dev, "Failed to get regulator: %ld\n",Signature · 1 line
2.17.1
Re: [PATCH V3 4/6] PCI: tegra: Add support to enable slot regulators
In reply to Vidya SagarQuoted 12 lines · Vidya Sagar
Add support to get regulator information of 3.3V and 12V supplies of a PCIe slot from the respective controller's device-tree node and enable those supplies. This is required in platforms like p2972-0000 where the supplies to x16 slot owned by C5 controller need to be enabled before attempting to enumerate the devices.
Signed-off-by Vidya Sagar <[email protected]>---
V3:
* Added adev_err()print for failure case oftegra_pcie_get_slot_regulators()API
* Modified to make 100ms sleep valid only if at least one of the regulator handles exist
Quoted 6 lines
V2:
* Addressed review comments from Thierry Reding and Andrew Murray
* Handled failure case ofdevm_regulator_get_optional()for-ENODEVcleanlydrivers/pci/controller/dwc/pcie-tegra194.c | 83 ++++++++++++++++++++++ 1 file changed, 83 insertions(+)
PATCH v3 5/6 arm64: tegra: Add configuration for PCIe C5 sideband signals
In reply to Vidya SagarAdd support to configure PCIe C5's sideband signals PERST# and CLKREQ# as output and bi-directional signals respectively which unlike other PCIe controllers sideband signals are not configured by default.
---
V3:
* None
V2:
* None
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 38 +++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra194.dtsi +37 -1
@@ -3,8 +3,9 @@ #include <dt-bindings/gpio/tegra194-gpio.h> #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/mailbox/tegra186-hsp.h> -#include <dt-bindings/reset/tegra194-reset.h> +#include <dt-bindings/pinctrl/pinctrl-tegra.h> #include <dt-bindings/power/tegra194-powergate.h> +#include <dt-bindings/reset/tegra194-reset.h> #include <dt-bindings/thermal/tegra194-bpmp-thermal.h> / {
@@ -130,6 +131,38 @@ }; }; + pinmux: pinmux@2430000 { + compatible = "nvidia,tegra194-pinmux"; + reg = <0x2430000 0x17000 + 0xc300000 0x4000>; + + status = "okay"; + + pex_rst_c5_out_state: pex_rst_c5_out { + pex_rst { + nvidia,pins = "pex_l5_rst_n_pgg1"; + nvidia,schmitt = <TEGRA_PIN_DISABLE>; + nvidia,lpdr = <TEGRA_PIN_ENABLE>; + nvidia,enable-input = <TEGRA_PIN_DISABLE>; + nvidia,io-high-voltage = <TEGRA_PIN_ENABLE>; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + nvidia,pull = <TEGRA_PIN_PULL_NONE>; + }; + }; + + clkreq_c5_bi_dir_state: clkreq_c5_bi_dir { + clkreq { + nvidia,pins = "pex_l5_clkreq_n_pgg0"; + nvidia,schmitt = <TEGRA_PIN_DISABLE>; + nvidia,lpdr = <TEGRA_PIN_ENABLE>; + nvidia,enable-input = <TEGRA_PIN_ENABLE>; + nvidia,io-high-voltage = <TEGRA_PIN_ENABLE>; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + nvidia,pull = <TEGRA_PIN_PULL_NONE>; + }; + }; + }; + uarta: serial@3100000 { compatible = "nvidia,tegra194-uart", "nvidia,tegra20-uart"; reg = <0x03100000 0x40>;
@@ -1365,6 +1398,9 @@ num-viewport = <8>; linux,pci-domain = <5>; + pinctrl-names = "default"; + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; + clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>, <&bpmp TEGRA194_CLK_PEX1_CORE_5M>; clock-names = "core", "core_m";
Signature · 1 line
2.17.1
Re: [PATCH V3 5/6] arm64: tegra: Add configuration for PCIe C5 sideband signals
Quoted 5 lines · Vidya Sagar
Add support to configure PCIe C5's sideband signals PERST# and CLKREQ# as output and bi-directional signals respectively which unlike other PCIe controllers sideband signals are not configured by default.
Signed-off-by Vidya Sagar <[email protected]>
Quoted 77 lines
---
V3:
* NoneV2:
* Nonearch/arm64/boot/dts/nvidia/tegra194.dtsi | 38 +++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)arch/arm64/boot/dts/nvidia/tegra194.dtsi +37
-1@@ -3,8 +3,9 @@ #include <dt-bindings/gpio/tegra194-gpio.h> #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/mailbox/tegra186-hsp.h> -#include <dt-bindings/reset/tegra194-reset.h> +#include <dt-bindings/pinctrl/pinctrl-tegra.h> #include <dt-bindings/power/tegra194-powergate.h> +#include <dt-bindings/reset/tegra194-reset.h> #include <dt-bindings/thermal/tegra194-bpmp-thermal.h> / {@@ -130,6 +131,38 @@ }; }; + pinmux: pinmux@2430000 { + compatible = "nvidia,tegra194-pinmux"; + reg = <0x2430000 0x17000 + 0xc300000 0x4000>; + + status = "okay"; + + pex_rst_c5_out_state: pex_rst_c5_out { + pex_rst { + nvidia,pins = "pex_l5_rst_n_pgg1"; + nvidia,schmitt = <TEGRA_PIN_DISABLE>; + nvidia,lpdr = <TEGRA_PIN_ENABLE>; + nvidia,enable-input = <TEGRA_PIN_DISABLE>; + nvidia,io-high-voltage = <TEGRA_PIN_ENABLE>; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + nvidia,pull = <TEGRA_PIN_PULL_NONE>; + }; + }; + + clkreq_c5_bi_dir_state: clkreq_c5_bi_dir { + clkreq { + nvidia,pins = "pex_l5_clkreq_n_pgg0"; + nvidia,schmitt = <TEGRA_PIN_DISABLE>; + nvidia,lpdr = <TEGRA_PIN_ENABLE>; + nvidia,enable-input = <TEGRA_PIN_ENABLE>; + nvidia,io-high-voltage = <TEGRA_PIN_ENABLE>; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + nvidia,pull = <TEGRA_PIN_PULL_NONE>; + }; + }; + }; + uarta: serial@3100000 { compatible = "nvidia,tegra194-uart", "nvidia,tegra20-uart"; reg = <0x03100000 0x40>;@@ -1365,6 +1398,9 @@ num-viewport = <8>; linux,pci-domain = <5>; + pinctrl-names = "default"; + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; + clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>, <&bpmp TEGRA194_CLK_PEX1_CORE_5M>; clock-names = "core", "core_m";Signature · 1 line
2.17.1
PATCH v3 6/6 arm64: tegra: Add PCIe slot supply information in p2972-0000 platform
In reply to Vidya SagarAdd 3.3V and 12V supplies regulators information of x16 PCIe slot in p2972-0000 platform which is owned by C5 controller and also enable C5 controller.
---
V3:
* None
V2:
* None
.../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 24 +++++++++++++++++++ .../boot/dts/nvidia/tegra194-p2972-0000.dts | 4 +++- 2 files changed, 27 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi +24 -0
@@ -289,5 +289,29 @@ gpio = <&gpio TEGRA194_MAIN_GPIO(A, 3) GPIO_ACTIVE_HIGH>; enable-active-high; }; + + vdd_3v3_pcie: regulator@2 { + compatible = "regulator-fixed"; + reg = <2>; + + regulator-name = "PEX_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio TEGRA194_MAIN_GPIO(Z, 2) GPIO_ACTIVE_HIGH>; + regulator-boot-on; + enable-active-high; + }; + + vdd_12v_pcie: regulator@3 { + compatible = "regulator-fixed"; + reg = <3>; + + regulator-name = "VDD_12V"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + gpio = <&gpio TEGRA194_MAIN_GPIO(A, 1) GPIO_ACTIVE_LOW>; + regulator-boot-on; + enable-active-low; + }; }; };
arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts +3 -1
@@ -93,9 +93,11 @@ }; pcie@141a0000 { - status = "disabled"; + status = "okay"; vddio-pex-ctl-supply = <&vdd_1v8ao>; + vpcie3v3-supply = <&vdd_3v3_pcie>; + vpcie12v-supply = <&vdd_12v_pcie>; phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>,
Signature · 1 line
2.17.1
Re: [PATCH V3 6/6] arm64: tegra: Add PCIe slot supply information in p2972-0000 platform
Quoted 5 lines · Vidya Sagar
Add 3.3V and 12V supplies regulators information of x16 PCIe slot in p2972-0000 platform which is owned by C5 controller and also enable C5 controller.
Signed-off-by Vidya Sagar <[email protected]>
Quoted 65 lines
---
V3:
* NoneV2:
* None.../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 24 +++++++++++++++++++ .../boot/dts/nvidia/tegra194-p2972-0000.dts | 4 +++- 2 files changed, 27 insertions(+), 1 deletion(-)arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi +24
-0@@ -289,5 +289,29 @@ gpio = <&gpio TEGRA194_MAIN_GPIO(A, 3) GPIO_ACTIVE_HIGH>; enable-active-high; }; + + vdd_3v3_pcie: regulator@2 { + compatible = "regulator-fixed"; + reg = <2>; + + regulator-name = "PEX_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio TEGRA194_MAIN_GPIO(Z, 2) GPIO_ACTIVE_HIGH>; + regulator-boot-on; + enable-active-high; + }; + + vdd_12v_pcie: regulator@3 { + compatible = "regulator-fixed"; + reg = <3>; + + regulator-name = "VDD_12V"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + gpio = <&gpio TEGRA194_MAIN_GPIO(A, 1) GPIO_ACTIVE_LOW>; + regulator-boot-on; + enable-active-low; + }; }; };arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts +3
-1@@ -93,9 +93,11 @@ }; pcie@141a0000 { - status = "disabled"; + status = "okay"; vddio-pex-ctl-supply = <&vdd_1v8ao>; + vpcie3v3-supply = <&vdd_3v3_pcie>; + vpcie12v-supply = <&vdd_12v_pcie>; phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>,Signature · 1 line
2.17.1
Hi Lorenzo / Bjorn,
Can you please review this series?
I have Reviewed-by and Acked-by from Rob, Thierry and Andrew already.
Thanks,
Vidya Sagar
Quoted 34 lines · Vidya Sagar
This patch series enables Tegra194's C5 controller which owns x16 slot in p2972-0000 platform. C5 controller's PERST# and CLKREQ# are not configured as output and bi-directional signals by default and hence they need to be configured explicitly. Also, x16 slot's 3.3V and 12V supplies are controlled through GPIOs and hence they need to be enabled through regulator framework. This patch series adds required infrastructural support to address both the aforementioned requirements.
Testing done on p2972-0000 platform
- Able to enumerate devices connected to x16 slot (owned by C5 controller)
- Enumerated device's functionality verified
- Suspend-Resume sequence is verified with device connected to x16 slotV3:
* Addressed some more review comments from Andrew Murray and Thierry RedingV2:
* Changed the order of patches in the series for easy merging
* Addressed review comments from Thierry Reding and Andrew MurrayVidya Sagar (6):
dt-bindings: PCI: tegra: Add sideband pins configuration entries
dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
PCI: tegra: Add support to configure sideband pins
PCI: tegra: Add support to enable slot regulators
arm64: tegra: Add configuration for PCIe C5 sideband signals
arm64: tegra: Add PCIe slot supply information in p2972-0000 platform.../bindings/pci/nvidia,tegra194-pcie.txt | 16 ++++ .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 24 +++++ .../boot/dts/nvidia/tegra194-p2972-0000.dts | 4 +- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 38 +++++++- drivers/pci/controller/dwc/pcie-tegra194.c | 94 ++++++++++++++++++- 5 files changed, 172 insertions(+), 4 deletions(-)
Quoted 3 lines · Vidya Sagar
Hi Lorenzo / Bjorn,
Can you please review this series?
I have Reviewed-by and Acked-by from Rob, Thierry and Andrew already.
Rebase it on top of my pci/tegra branch (it does not apply), resend it and I will merge it.
Thanks,
Lorenzo
Quoted 39 lines
Thanks,
Vidya SagarQuoted 34 lines · Vidya Sagar
This patch series enables Tegra194's C5 controller which owns x16 slot in p2972-0000 platform. C5 controller's PERST# and CLKREQ# are not configured as output and bi-directional signals by default and hence they need to be configured explicitly. Also, x16 slot's 3.3V and 12V supplies are controlled through GPIOs and hence they need to be enabled through regulator framework. This patch series adds required infrastructural support to address both the aforementioned requirements.
Testing done on p2972-0000 platform
- Able to enumerate devices connected to x16 slot (owned by C5 controller)
- Enumerated device's functionality verified
- Suspend-Resume sequence is verified with device connected to x16 slotV3:
* Addressed some more review comments from Andrew Murray and Thierry RedingV2:
* Changed the order of patches in the series for easy merging
* Addressed review comments from Thierry Reding and Andrew MurrayVidya Sagar (6):
dt-bindings: PCI: tegra: Add sideband pins configuration entries
dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
PCI: tegra: Add support to configure sideband pins
PCI: tegra: Add support to enable slot regulators
arm64: tegra: Add configuration for PCIe C5 sideband signals
arm64: tegra: Add PCIe slot supply information in p2972-0000 platform.../bindings/pci/nvidia,tegra194-pcie.txt | 16 ++++ .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 24 +++++ .../boot/dts/nvidia/tegra194-p2972-0000.dts | 4 +- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 38 +++++++- drivers/pci/controller/dwc/pcie-tegra194.c | 94 ++++++++++++++++++- 5 files changed, 172 insertions(+), 4 deletions(-)
Quoted 7 lines · Lorenzo Pieralisi
Quoted 3 lines · Vidya Sagar
Hi Lorenzo / Bjorn,
Can you please review this series?
I have Reviewed-by and Acked-by from Rob, Thierry and Andrew already.Rebase it on top of my pci/tegra branch (it does not apply), resend it and I will merge it.
I just sent V4 after rebasing the series on top of pci/tegra.
Thanks,
Vidya Sagar
Quoted 43 lines
Thanks,
LorenzoQuoted 39 lines
Thanks,
Vidya SagarQuoted 34 lines · Vidya Sagar
This patch series enables Tegra194's C5 controller which owns x16 slot in p2972-0000 platform. C5 controller's PERST# and CLKREQ# are not configured as output and bi-directional signals by default and hence they need to be configured explicitly. Also, x16 slot's 3.3V and 12V supplies are controlled through GPIOs and hence they need to be enabled through regulator framework. This patch series adds required infrastructural support to address both the aforementioned requirements.
Testing done on p2972-0000 platform
- Able to enumerate devices connected to x16 slot (owned by C5 controller)
- Enumerated device's functionality verified
- Suspend-Resume sequence is verified with device connected to x16 slotV3:
* Addressed some more review comments from Andrew Murray and Thierry RedingV2:
* Changed the order of patches in the series for easy merging
* Addressed review comments from Thierry Reding and Andrew MurrayVidya Sagar (6):
dt-bindings: PCI: tegra: Add sideband pins configuration entries
dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries
PCI: tegra: Add support to configure sideband pins
PCI: tegra: Add support to enable slot regulators
arm64: tegra: Add configuration for PCIe C5 sideband signals
arm64: tegra: Add PCIe slot supply information in p2972-0000 platform.../bindings/pci/nvidia,tegra194-pcie.txt | 16 ++++ .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 24 +++++ .../boot/dts/nvidia/tegra194-p2972-0000.dts | 4 +- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 38 +++++++- drivers/pci/controller/dwc/pcie-tegra194.c | 94 ++++++++++++++++++- 5 files changed, 172 insertions(+), 4 deletions(-)