PCI: rcar: Remove unnecessary header include (../pci.h)
Subsystems (4)
PATCH 1/1 PCI: rcar: Remove unnecessary header include (../pci.h)
Remove unnecessary header include (../pci.h) since it doesn't provide any needed symbols.
--- drivers/pci/controller/pcie-rcar.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pci/controller/pcie-rcar.c +0 -2
@@ -30,8 +30,6 @@#include <linux/pm_runtime.h> #include <linux/slab.h> -#include "../pci.h" -#define PCIECAR 0x000010#define PCIECCTLR 0x000018#define CONFIG_SEND_ENABLE BIT(31)
Signature · 1 line
2.21.0
Quoted 4 lines · Andrew Murray
Remove unnecessary header include (
../pci.h) since it doesn't provide any needed symbols.Signed-off-by Andrew Murray <[email protected]>
Quoted 20 lines
--- drivers/pci/controller/pcie-rcar.c | 2 -- 1 file changed, 2 deletions(-)drivers/pci/controller/pcie-rcar.c +0
-2@@ -30,8 +30,6 @@#include <linux/pm_runtime.h> #include <linux/slab.h> -#include "../pci.h" -#define PCIECAR 0x000010#define PCIECCTLR 0x000018#define CONFIG_SEND_ENABLE BIT(31)Signature · 1 line
2.21.0
Hi Andy!
Quoted 2 lines · Andrew Murray
Remove unnecessary header include (
../pci.h) since it doesn't provide any needed symbols.
This appears to have been added in 9e2aee80c78d ("PCI: Move private DT related functions into private header")
Several other drivers were touched in that commit too.
Have you checked to see if any others can also be cleaned up?
(I only ask, because I only see this single patch on linux-renesas-soc,
my apologies if others are on different lists.)
Regardless of that, this looks fine to me, and passes a cursory compile check.
And I've just tried with pcie-xilinx, and pcie-altera, but both still need this header - so perhaps pcie-rcar was just the odd one out.
Quoted 19 lines
Signed-off-by Andrew Murray <[email protected]>--- drivers/pci/controller/pcie-rcar.c | 2 -- 1 file changed, 2 deletions(-)drivers/pci/controller/pcie-rcar.c +0
-2@@ -30,8 +30,6 @@#include <linux/pm_runtime.h> #include <linux/slab.h> -#include "../pci.h" -#define PCIECAR 0x000010#define PCIECCTLR 0x000018#define CONFIG_SEND_ENABLE BIT(31)
Quoted 8 lines · Kieran Bingham
Hi Andy!
Quoted 2 lines · Andrew Murray
Remove unnecessary header include (
../pci.h) since it doesn't provide any needed symbols.This appears to have been added in
9e2aee80c78d("PCI: Move private DT related functions into private header")
Thanks, I never looked back at the history of this.
Quoted 4 lines
Several other drivers were touched in that commit too.
Have you checked to see if any others can also be cleaned up?
Yes I went through all the current drivers/pci/host/ files, I believe this was the only one.
Quoted 11 lines
(I only ask, because I only see this single patch on linux-renesas-soc,
my apologies if others are on different lists.)Regardless of that, this looks fine to me, and passes a cursory compile check.
And I've just tried with pcie-xilinx, and pcie-altera, but both still need this header - so perhaps pcie-rcar was just the odd one out.
Reviewed-by Kieran Bingham <[email protected]>
Thanks,
Andrew Murray
Quoted 22 lines
Quoted 21 lines
Signed-off-by Andrew Murray <[email protected]>--- drivers/pci/controller/pcie-rcar.c | 2 -- 1 file changed, 2 deletions(-)drivers/pci/controller/pcie-rcar.c +0
-2@@ -30,8 +30,6 @@#include <linux/pm_runtime.h> #include <linux/slab.h> -#include "../pci.h" -#define PCIECAR 0x000010#define PCIECCTLR 0x000018#define CONFIG_SEND_ENABLE BIT(31)
Quoted 4 lines · Andrew Murray
Remove unnecessary header include (
../pci.h) since it doesn't provide any needed symbols.Signed-off-by Andrew Murray <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Lorenzo Pieralisi
AppliedQuoted 7 lines · Andrew Murray
Remove unnecessary header include (
../pci.h) since it doesn't provide any needed symbols.Signed-off-by Andrew Murray <[email protected]>--- drivers/pci/controller/pcie-rcar.c | 2 -- 1 file changed, 2 deletions(-)
Applied to pci/rcar, thanks.
Lorenzo
Quoted 16 lines
drivers/pci/controller/pcie-rcar.c +0
-2@@ -30,8 +30,6 @@#include <linux/pm_runtime.h> #include <linux/slab.h> -#include "../pci.h" -#define PCIECAR 0x000010#define PCIECCTLR 0x000018#define CONFIG_SEND_ENABLE BIT(31)Signature · 1 line
2.21.0