Skip to contentSkip to conversation

PCI: rcar: Remove unnecessary header include (../pci.h)

PATCH Applied Andrew Murray 5 participants 6 messages Sep 5, 2019 – Oct 15, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: rcar: Remove unnecessary header include (../pci.h)

Remove unnecessary header include (../pci.h) since it doesn't provide any needed symbols.

---
 drivers/pci/controller/pcie-rcar.c | 2 --
 1 file changed, 2 deletions(-)
drivers/pci/controller/pcie-rcar.c +0 -2
index f6a669a9af41..ee1c38c2fac9 100644
@@ -30,8 +30,6 @@
 #include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
-#include "../pci.h"
-
 #define PCIECAR			0x000010
 #define PCIECCTLR		0x000018
 #define  CONFIG_SEND_ENABLE	BIT(31)
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andrew Murray

Remove unnecessary header include (../pci.h) since it doesn't provide any needed symbols.

Quoted 20 lines
---
 drivers/pci/controller/pcie-rcar.c | 2 --
 1 file changed, 2 deletions(-)
drivers/pci/controller/pcie-rcar.c +0 -2
index f6a669a9af41..ee1c38c2fac9 100644
@@ -30,8 +30,6 @@
 #include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
-#include "../pci.h"
-
 #define PCIECAR			0x000010
 #define PCIECCTLR		0x000018
 #define  CONFIG_SEND_ENABLE	BIT(31)
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Andrew Murray

Hi Andy!

Quoted 2 lines · Andrew Murray

Remove unnecessary header include (../pci.h) since it doesn't provide any needed symbols.

This appears to have been added in 9e2aee80c78d ("PCI: Move private DT related functions into private header")

Several other drivers were touched in that commit too.

Have you checked to see if any others can also be cleaned up?

(I only ask, because I only see this single patch on linux-renesas-soc,
my apologies if others are on different lists.)

Regardless of that, this looks fine to me, and passes a cursory compile check.

And I've just tried with pcie-xilinx, and pcie-altera, but both still need this header - so perhaps pcie-rcar was just the odd one out.

Quoted 19 lines
---
 drivers/pci/controller/pcie-rcar.c | 2 --
 1 file changed, 2 deletions(-)
drivers/pci/controller/pcie-rcar.c +0 -2
index f6a669a9af41..ee1c38c2fac9 100644
@@ -30,8 +30,6 @@
 #include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
-#include "../pci.h"
-
 #define PCIECAR			0x000010
 #define PCIECCTLR		0x000018
 #define  CONFIG_SEND_ENABLE	BIT(31)
#3 lore raw
Quoted 8 lines · Kieran Bingham

Hi Andy!

Quoted 2 lines · Andrew Murray

Remove unnecessary header include (../pci.h) since it doesn't provide any needed symbols.

This appears to have been added in 9e2aee80c78d ("PCI: Move private DT related functions into private header")

Thanks, I never looked back at the history of this.

Quoted 4 lines

Several other drivers were touched in that commit too.

Have you checked to see if any others can also be cleaned up?

Yes I went through all the current drivers/pci/host/ files, I believe this was the only one.

Quoted 11 lines

(I only ask, because I only see this single patch on linux-renesas-soc,
my apologies if others are on different lists.)

Regardless of that, this looks fine to me, and passes a cursory compile check.

And I've just tried with pcie-xilinx, and pcie-altera, but both still need this header - so perhaps pcie-rcar was just the odd one out.

Thanks,

Andrew Murray

Quoted 22 lines
Quoted 21 lines
---
 drivers/pci/controller/pcie-rcar.c | 2 --
 1 file changed, 2 deletions(-)
drivers/pci/controller/pcie-rcar.c +0 -2
index f6a669a9af41..ee1c38c2fac9 100644
@@ -30,8 +30,6 @@
 #include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
-#include "../pci.h"
-
 #define PCIECAR			0x000010
 #define PCIECCTLR		0x000018
 #define  CONFIG_SEND_ENABLE	BIT(31)
Reviewed-by on v1 1/1
#4 lore raw
In reply to Andrew Murray
Quoted 4 lines · Andrew Murray

Remove unnecessary header include (../pci.h) since it doesn't provide any needed symbols.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#5 lore raw
In reply to Andrew Murray
Quoted 7 lines · Andrew Murray

Remove unnecessary header include (../pci.h) since it doesn't provide any needed symbols.

---
 drivers/pci/controller/pcie-rcar.c | 2 --
 1 file changed, 2 deletions(-)

Applied to pci/rcar, thanks.

Lorenzo

Quoted 16 lines
drivers/pci/controller/pcie-rcar.c +0 -2
index f6a669a9af41..ee1c38c2fac9 100644
@@ -30,8 +30,6 @@
 #include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
-#include "../pci.h"
-
 #define PCIECAR			0x000010
 #define PCIECCTLR		0x000018
 #define  CONFIG_SEND_ENABLE	BIT(31)
Signature · 1 line
2.21.0