Skip to contentSkip to conversation

clk: qcom: gcc-qcs404: Use floor ops for sdcc clks

PATCH Applied Vinod Koul 4 participants 7 messages Sep 6, 2019 – Sep 9, 2019

Subsystems (3)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH 1/1 clk: qcom: gcc-qcs404: Use floor ops for sdcc clks

Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

---
 drivers/clk/qcom/gcc-qcs404.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/qcom/gcc-qcs404.c +2 -2
index e12c04c09a6a..bd32212f37e6 100644
@@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {
 		.name = "sdcc1_apps_clk_src",
 		.parent_names = gcc_parent_names_13,
 		.num_parents = 5,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
@@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = {
 		.name = "sdcc2_apps_clk_src",
 		.parent_names = gcc_parent_names_14,
 		.num_parents = 4,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Vinod Koul

Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

Quoted 30 lines
---
 drivers/clk/qcom/gcc-qcs404.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/qcom/gcc-qcs404.c +2 -2
index e12c04c09a6a..bd32212f37e6 100644
@@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {
 		.name = "sdcc1_apps_clk_src",
 		.parent_names = gcc_parent_names_13,
 		.num_parents = 5,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
@@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = {
 		.name = "sdcc2_apps_clk_src",
 		.parent_names = gcc_parent_names_14,
 		.num_parents = 4,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
Signature · 1 line
2.20.1
maintainer
#2 lore raw
In reply to Vinod Koul

Quoting Vinod Koul (2019-09-05 21:56:59)

Quoted 8 lines

Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

---

Is Taniya writing the rest? Please don't dribble it out over the next few weeks!

Quoted 3 lines
 drivers/clk/qcom/gcc-qcs404.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
author
#3 lore raw
Quoted 5 lines · Stephen Boyd

Quoting Vinod Koul (2019-09-05 21:56:59)

Quoted 4 lines

Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.

Quoted 7 lines
Quoted 4 lines

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

---

Is Taniya writing the rest? Please don't dribble it out over the next few weeks!

Taniya is Cced. Since I upstream qcs404 driver and have a board handy to test, did that :)

Thanks

Signature · 1 line
~Vinod
#4 lore raw
In reply to Stephen Boyd

Hi Stephen, Vinod,

Quoted 5 lines · Stephen Boyd

Quoting Vinod Koul (2019-09-05 21:56:59)

Quoted 4 lines

Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.

Quoted 7 lines
Quoted 4 lines

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

---

Is Taniya writing the rest? Please don't dribble it out over the next few weeks!

I have pushed the patch : https://patchwork.kernel.org/patch/11137393/

Vinod, I have taken care of the QCS404 in the same patch, so as to keep the change in one patch.

Quoted 4 lines
Quoted 4 lines
  drivers/clk/qcom/gcc-qcs404.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--
maintainer
#5 lore raw

Quoting Taniya Das (2019-09-09 00:48:39)

Quoted 13 lines

Hi Stephen, Vinod,

Quoted 10 lines · Stephen Boyd

Quoting Vinod Koul (2019-09-05 21:56:59)

Quoted 8 lines

Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

---

Quoted 8 lines
Quoted 2 lines

Is Taniya writing the rest? Please don't dribble it out over the next few weeks!

I have pushed the patch : https://patchwork.kernel.org/patch/11137393/

Vinod, I have taken care of the QCS404 in the same patch, so as to keep the change in one patch.

Cool thanks.