clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
Subsystems (3)
PATCH 1/1 clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.
[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/
--- drivers/clk/qcom/gcc-qcs404.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/qcom/gcc-qcs404.c +2 -2
@@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = { .name = "sdcc1_apps_clk_src", .parent_names = gcc_parent_names_13, .num_parents = 5, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = { .name = "sdcc2_apps_clk_src", .parent_names = gcc_parent_names_14, .num_parents = 4, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
Signature · 1 line
2.20.1
Quoted 6 lines · Vinod Koul
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.
[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/
Quoted 30 lines
Signed-off-by Vinod Koul <[email protected]>--- drivers/clk/qcom/gcc-qcs404.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/clk/qcom/gcc-qcs404.c +2
-2@@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = { .name = "sdcc1_apps_clk_src", .parent_names = gcc_parent_names_13, .num_parents = 5, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };@@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = { .name = "sdcc2_apps_clk_src", .parent_names = gcc_parent_names_14, .num_parents = 4, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };Signature · 1 line
2.20.1
Stephen Boyd
maintainerQuoting Vinod Koul (2019-09-05 21:56:59)
Quoted 8 lines
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.
[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/
Signed-off-by Vinod Koul <[email protected]>---
Is Taniya writing the rest? Please don't dribble it out over the next few weeks!
Quoted 3 lines
drivers/clk/qcom/gcc-qcs404.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines · Stephen Boyd
Quoting Vinod Koul (2019-09-05 21:56:59)
Quoted 4 lines
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.
Quoted 7 lines
Quoted 4 lines
[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/
Signed-off-by Vinod Koul <[email protected]>---
Is Taniya writing the rest? Please don't dribble it out over the next few weeks!
Taniya is Cced. Since I upstream qcs404 driver and have a board handy to test, did that :)
Thanks
Signature · 1 line
~Vinod
Hi Stephen, Vinod,
Quoted 5 lines · Stephen Boyd
Quoting Vinod Koul (2019-09-05 21:56:59)
Quoted 4 lines
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.
Quoted 7 lines
Quoted 4 lines
[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/
Signed-off-by Vinod Koul <[email protected]>---
Is Taniya writing the rest? Please don't dribble it out over the next few weeks!
I have pushed the patch : https://patchwork.kernel.org/patch/11137393/
Vinod, I have taken care of the QCS404 in the same patch, so as to keep the change in one patch.
Quoted 4 lines
Quoted 4 lines
drivers/clk/qcom/gcc-qcs404.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation. --
Stephen Boyd
maintainerQuoting Taniya Das (2019-09-09 00:48:39)
Quoted 13 lines
Hi Stephen, Vinod,
Quoted 10 lines · Stephen Boyd
Quoting Vinod Koul (2019-09-05 21:56:59)
Quoted 8 lines
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.
[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/
Signed-off-by Vinod Koul <[email protected]>---
Quoted 8 lines
Quoted 2 lines
Is Taniya writing the rest? Please don't dribble it out over the next few weeks!
I have pushed the patch : https://patchwork.kernel.org/patch/11137393/
Vinod, I have taken care of the QCS404 in the same patch, so as to keep the change in one patch.
Cool thanks.
Quoting Vinod Koul (2019-09-05 21:56:59)
Quoted 8 lines
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up.
[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/
Signed-off-by Vinod Koul <[email protected]>---
Applied to clk-next