tests/Makefile: Do not print the name of the check-block.sh shell script
PATCH 1/1 tests/Makefile: Do not print the name of the check-block.sh shell script
The check script is already printing out which iotest is currently running, so printing out the name of the check-block.sh shell script looks superfluous here.
--- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.include +1 -1
@@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \ qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \ $(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS))) - $< + @$< .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y)) $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
Signature · 1 line
2.18.1
Quoted 5 lines · Thomas Huth
The check script is already printing out which iotest is currently running, so printing out the name of the
check-block.shshell script looks superfluous here.Signed-off-by Thomas Huth <[email protected]>
Makes sense.
Quoted 18 lines
--- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/Makefile.include +1
-1@@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \ qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \ $(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS))) - $< + @$< .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y)) $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
Quoted 8 lines · Thomas Huth
The check script is already printing out which iotest is currently running, so printing out the name of the
check-block.shshell script looks superfluous here.Signed-off-by Thomas Huth <[email protected]>--- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(Not sure which tree you’d like this to go through...)
Quoted 5 lines · Max Reitz
Quoted 4 lines · Thomas Huth
The check script is already printing out which iotest is currently running, so printing out the name of the
check-block.shshell script looks superfluous here.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Thomas Huth <[email protected]>--- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Reviewed-by Max Reitz <[email protected]>(Not sure which tree you’d like this to go through...)
I think either your block tree or trivial would be appropriate?
Thomas
Quoted 11 lines · Thomas Huth
Quoted 10 lines · Max Reitz
Quoted 8 lines · Thomas Huth
The check script is already printing out which iotest is currently running, so printing out the name of the
check-block.shshell script looks superfluous here.Signed-off-by Thomas Huth <[email protected]>--- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Quoted 3 lines
Reviewed-by Max Reitz <[email protected]>(Not sure which tree you’d like this to go through...)
I think either your block tree or trivial would be appropriate?
OK then, I’ve taken it. :-)
Max