Skip to contentSkip to conversation

tests/Makefile: Do not print the name of the check-block.sh shell script

PATCH In review Thomas Huth 3 participants 5 messages Sep 6, 2019 – Sep 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/Makefile: Do not print the name of the check-block.sh shell script

The check script is already printing out which iotest is currently running, so printing out the name of the check-block.sh shell script looks superfluous here.

---
 tests/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.include +1 -1
index f5ac09549c..a36317ac87 100644
@@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu
 check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \
 		qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
 		$(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS)))
-	$<
+	@$<
 
 .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
 $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
Signature · 1 line
2.18.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Thomas Huth

The check script is already printing out which iotest is currently running, so printing out the name of the check-block.sh shell script looks superfluous here.

Makes sense.

Quoted 18 lines
---
 tests/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.include +1 -1
index f5ac09549c..a36317ac87 100644
@@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu
 check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \
 		qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
 		$(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS)))
-	$<
+	@$<
 
 .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
 $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
Reviewed-by on v1 1/1
#2 lore raw
In reply to Thomas Huth
Quoted 8 lines · Thomas Huth

The check script is already printing out which iotest is currently running, so printing out the name of the check-block.sh shell script looks superfluous here.

---
 tests/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(Not sure which tree you’d like this to go through...)

#3 lore raw
Quoted 5 lines · Max Reitz
Quoted 4 lines · Thomas Huth

The check script is already printing out which iotest is currently running, so printing out the name of the check-block.sh shell script looks superfluous here.

Quoted 8 lines
Quoted 4 lines
---
 tests/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(Not sure which tree you’d like this to go through...)

I think either your block tree or trivial would be appropriate?

Thomas

#4 lore raw
Quoted 11 lines · Thomas Huth
Quoted 10 lines · Max Reitz
Quoted 8 lines · Thomas Huth

The check script is already printing out which iotest is currently running, so printing out the name of the check-block.sh shell script looks superfluous here.

---
 tests/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Quoted 3 lines

(Not sure which tree you’d like this to go through...)

I think either your block tree or trivial would be appropriate?

OK then, I’ve taken it. :-)

Max