Skip to contentSkip to conversation

drm/tilcdc: include linux/pinctrl/consumer.h again

PATCH In review Arnd Bergmann 2 participants 2 messages Sep 9, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tilcdc: include linux/pinctrl/consumer.h again

This was apparently dropped by accident in a recent cleanup, causing a build failure in some configurations now:

drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration]

Fixes fcb57664172e ("drm/tilcdc: drop use of drmP.h")
---
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c +1 -0
index 525dc1c0f1c1..9edcdd7f2b96 100644
@@ -8,6 +8,7 @@
 #include <linux/mod_devicetable.h>
 #include <linux/of_gpio.h>
 #include <linux/platform_device.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_encoder.h>
Signature · 6 lines
2.20.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

Hi Arnd,

Thank you for the patch.

Quoted 16 lines · Arnd Bergmann

This was apparently dropped by accident in a recent cleanup, causing a build failure in some configurations now:

drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration]

Fixes fcb57664172e ("drm/tilcdc: drop use of drmP.h")
---
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c +0 -0
index 525dc1c0f1c1..9edcdd7f2b96 100644

drivers/gpu/drm/tilcdc/tilcdc_tfp410.c line 11

Quoted 4 lines
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c +1 -0
@@ -8,6 +8,7 @@
 #include <linux/mod_devicetable.h>
 #include <linux/of_gpio.h>
 #include <linux/platform_device.h>
+#include <linux/pinctrl/consumer.h>

I'd put this before platform_device.h to keep the headers alphabetically ordered. Apart from that,

Quoted 2 lines
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c +0 -0
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_encoder.h>
Signature · 3 lines
Regards,

Laurent Pinchart