Skip to contentSkip to conversation

target: minor iSCSI parameter parsing fixes

PATCH Applied David Disseldorp 3 participants 3 messages Sep 12, 2019 – Oct 23, 2019 SCSI target

lore
Share & tools
lore
#0 lore raw

cover target: minor iSCSI parameter parsing fixes

This patchset includes some minor fixes for parsing iSCSI CHAP_A and SendTargets fields. Patch 1/3 was already submitted and reviewed by Lee.
I used the following libiscsi hacks to test for these bugs:
https://github.com/ddiss/libiscsi/commits/bogus_chap_a
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
I'll work on turning these into propper libiscsi regression tests (pending https://github.com/sahlberg/libiscsi/issues/297).

Cheers, David

 drivers/target/iscsi/iscsi_target.c            | 14 ++++++--------
 drivers/target/iscsi/iscsi_target_auth.c       |  2 +-
 drivers/target/iscsi/iscsi_target_parameters.h |  3 ---
 3 files changed, 7 insertions(+), 12 deletions(-)
Reviewed-by on the v1 series
#1 lore raw
Quoted 10 lines · David Disseldorp

This patchset includes some minor fixes for parsing iSCSI CHAP_A and SendTargets fields. Patch 1/3 was already submitted and reviewed by Lee.
I used the following libiscsi hacks to test for these bugs:
https://github.com/ddiss/libiscsi/commits/bogus_chap_a
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
I'll work on turning these into propper libiscsi regression tests (pending https://github.com/sahlberg/libiscsi/issues/297).

Quoted 7 lines

Cheers, David

 drivers/target/iscsi/iscsi_target.c            | 14 ++++++--------
 drivers/target/iscsi/iscsi_target_auth.c       |  2 +-
 drivers/target/iscsi/iscsi_target_parameters.h |  3 ---
 3 files changed, 7 insertions(+), 12 deletions(-)