target: minor iSCSI parameter parsing fixes
Status from this message: Applied to 5.5/scsi-queue, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | target: compare full CHAP_A Algorithm stringsdrivers/ | +1 | 0 replies | |
| 2/3 | target: fix SendTargets=All string comparesdrivers/ | +6 | 2 replies | |
| 3/3 | target: remove unused extension parametersdrivers/ | +0 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Lee Duncan | Mike Christie |
|---|---|---|
| Series | R-b | |
| 1/3 | R-b | |
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] target: minor iSCSI parameter parsing fixes
This patchset includes some minor fixes for parsing iSCSI CHAP_A and SendTargets fields. Patch 1/3 was already submitted and reviewed by Lee.
I used the following libiscsi hacks to test for these bugs:
https://github.com/ddiss/libiscsi/commits/bogus_chap_a
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
I'll work on turning these into propper libiscsi regression tests (pending https://github.com/sahlberg/libiscsi/issues/297).
Cheers, David
drivers/target/iscsi/iscsi_target.c | 14 ++++++-------- drivers/target/iscsi/iscsi_target_auth.c | 2 +- drivers/target/iscsi/iscsi_target_parameters.h | 3 --- 3 files changed, 7 insertions(+), 12 deletions(-)