Skip to content

target: minor iSCSI parameter parsing fixes

David Disseldorp target-devel 1 version Applied

Status from this message: Applied to 5.5/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3target: compare full CHAP_A Algorithm stringsdrivers/target/iscsi/iscsi_target_auth.c+1 -10 replies
2/3target: fix SendTargets=All string comparesdrivers/target/iscsi/iscsi_target.c+6 -82 replies
3/3target: remove unused extension parametersdrivers/target/iscsi/iscsi_target_parameters.h+0 -30 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLee DuncanMike Christie
SeriesR-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] target: minor iSCSI parameter parsing fixes

This patchset includes some minor fixes for parsing iSCSI CHAP_A and SendTargets fields. Patch 1/3 was already submitted and reviewed by Lee.
I used the following libiscsi hacks to test for these bugs:
https://github.com/ddiss/libiscsi/commits/bogus_chap_a
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
I'll work on turning these into propper libiscsi regression tests (pending https://github.com/sahlberg/libiscsi/issues/297).

Cheers, David

 drivers/target/iscsi/iscsi_target.c            | 14 ++++++--------
 drivers/target/iscsi/iscsi_target_auth.c       |  2 +-
 drivers/target/iscsi/iscsi_target_parameters.h |  3 ---
 3 files changed, 7 insertions(+), 12 deletions(-)