DSB enablement.
Subsystems (5)
v9 cover DSB enablement.
Display State Buffer (DSB) is hardware capability which allows driver to batch submit HW programming.
As part of initial enablement common api created which currently used to program gamma lut proramming.
Going forwad DSB support can be added for HDR and flip related operation.
HSDES: 1209978241
BSpec: 32020
v1: Initial version.
v2: Move intel_dsb files under display folder and fixed an issue.
v3: As per review comments from Chris and Jani,
- removed some unwanted code. (Chris)
- Used i915_gem_object_create_internal instead of _shmem. (Chris)
- cmd_buf_tail removed and can be derived through vma object. (Chris)
- Simplified and optimized code few places. (Chris)
- Called dsb-api directly in callsites instead going via I915_WRITE. (Jani)
v4: Addressed review commnets from Shashank.
v5: Addressed review commnets from Shashank and Jani.
v6: Addressed review commnets from Shashank.
v7: Addressed review commnets from Shashank and Jani.
v8: Addressed review commnets from Shashank and Jani.
v9: Addressed review commnets from Jani.
Animesh Manna (10):
drm/i915/dsb: feature flag added for display state buffer. drm/i915/dsb: DSB context creation.
drm/i915/dsb: single register write function for DSB. drm/i915/dsb: Indexed register write function for DSB. drm/i915/dsb: Check DSB engine status. drm/i915/dsb: functions to enable/disable DSB engine. drm/i915/dsb: function to trigger workload execution of DSB. drm/i915/dsb: Enable gamma lut programming using DSB. drm/i915/dsb: Enable DSB for gen12.
drm/i915/dsb: Documentation for DSB.
Documentation/gpu/i915.rst | 9 + drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_color.c | 63 ++-- .../drm/i915/display/intel_display_types.h | 3 + drivers/gpu/drm/i915/display/intel_dsb.c | 337 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 50 +++ drivers/gpu/drm/i915/i915_drv.h | 3 + drivers/gpu/drm/i915/i915_pci.c | 3 +- drivers/gpu/drm/i915/i915_reg.h | 10 + drivers/gpu/drm/i915/intel_device_info.h | 1 + 10 files changed, 457 insertions(+), 23 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dsb.c create mode 100644 drivers/gpu/drm/i915/display/intel_dsb.h
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 1/10 drm/i915/dsb: feature flag added for display state buffer.
Display State Buffer(DSB) is a new hardware capability, introduced in GEN12 display. DSB allows a driver to batch-program display HW registers.
--- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 2 files changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -1863,6 +1863,8 @@ static inline struct drm_i915_private *pdev_to_i915(struct pci_dev *pdev) (BUILD_BUG_ON_ZERO (!__builtin_constant_p (n)) + \ INTEL_INFO(dev_priv)->gen == (n)) +#define HAS_DSB (dev_priv) (INTEL_INFO(dev_priv)->display.has_dsb) +/* * Return true if revision is in range [since,until] inclusive. *
drivers/gpu/drm/i915/intel_device_info.h +1 -0
@@ -135,6 +135,7 @@ enum intel_ppgtt_type {func (has_csr); \func (has_ddi); \func (has_dp_mst); \ +func (has_dsb); \func (has_fbc); \func (has_gmch); \func (has_hotplug); \
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 2/10 drm/i915/dsb: DSB context creation.
In reply to Animesh MannaThis patch adds a function, which will internally get the gem buffer for DSB engine. The GEM buffer is from global GTT, and is mapped into CPU domain, contains the data + opcode to be feed to DSB engine.
v1: Initial version.
v2:
- removed some unwanted code. (Chris)
- Used i915_gem_object_create_internal instead of _shmem. (Chris)
- cmd_buf_tail removed and can be derived through vma object. (Chris)
v3: vma realeased if i915_gem_object_pin_map() failed. (Shashank)
v4: for simplification and based on current usage added single dsb object in intel_crtc. (Shashank)
v5: seting NULL to cmd_buf moved outside of mutex in dsb-put(). (Shashank)
v6:
- refcount machanism added.
- Used atomic_add_return and atomic_dec_and_test instead of atomic_inc and atomic_dec. (Jani)
--- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_display_types.h | 3 + drivers/gpu/drm/i915/display/intel_dsb.c | 80 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 31 +++++++ drivers/gpu/drm/i915/i915_drv.h | 1 + 5 files changed, 116 insertions(+) create mode 100644 drivers/gpu/drm/i915/display/intel_dsb.c create mode 100644 drivers/gpu/drm/i915/display/intel_dsb.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -172,6 +172,7 @@ i915-y += \ display/intel_display_power.o \ display/intel_dpio_phy.o \ display/intel_dpll_mgr.o \ + display/intel_dsb.o \ display/intel_fbc.o \ display/intel_fifo_underrun.o \ display/intel_frontbuffer.o \
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -1033,6 +1033,9 @@ struct intel_crtc {/* scalers available on this crtc */ int num_scalers; + +/* per pipe DSB related info */ +struct intel_dsb dsb; };struct intel_plane {
drivers/gpu/drm/i915/display/intel_dsb.c new file +80 -0
80 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dsb.h new file +31 -0
@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: MIT +* +* Copyright © 2019 Intel Corporation +*/ + +#ifndef _INTEL_DSB_H +#define _INTEL_DSB_H + +struct intel_crtc ; +struct i915_vma ; + +enum dsb_id { +INVALID_DSB =-1 , +DSB1 , +DSB2 , +DSB3 , +MAX_DSB_PER_PIPE +}; + +struct intel_dsb { +atomic_t refcount; +enum dsb_id id; +u32 *cmd_buf; +struct i915_vma *vma; +}; + +struct intel_dsb * +intel_dsb_get (struct intel_crtc *crtc); +void intel_dsb_put (struct intel_dsb *dsb); + +#endif
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -67,6 +67,7 @@#include "display/intel_display.h" #include "display/intel_display_power.h" #include "display/intel_dpll_mgr.h" +#include "display/intel_dsb.h" #include "display/intel_frontbuffer.h" #include "display/intel_gmbus.h" #include "display/intel_opregion.h"
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v9 02/10] drm/i915/dsb: DSB context creation.
Quoted 170 lines · Animesh Manna
This patch adds a function, which will internally get the gem buffer for DSB engine. The GEM buffer is from global GTT, and is mapped into CPU domain, contains the data + opcode to be feed to DSB engine.
v1: Initial version.
v2:
- removed some unwanted code. (Chris)
- Usedi915_gem_object_create_internalinstead of_shmem. (Chris)
-cmd_buf_tailremoved and can be derived through vma object. (Chris)v3: vma realeased if
i915_gem_object_pin_map()failed. (Shashank)v4: for simplification and based on current usage added single dsb object in
intel_crtc. (Shashank)v5: seting NULL to
cmd_bufmoved outside of mutex in dsb-put(). (Shashank)v6:
- refcount machanism added.
- Usedatomic_add_returnandatomic_dec_and_testinstead ofatomic_incandatomic_dec. (Jani)Cc Imre Deak <[email protected]>Cc Michel Thierry <[email protected]>Cc Jani Nikula <[email protected]>Cc Rodrigo Vivi <[email protected]>Cc Shashank Sharma <[email protected]>Signed-off-by Animesh Manna <[email protected]>--- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_display_types.h | 3 + drivers/gpu/drm/i915/display/intel_dsb.c | 80 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 31 +++++++ drivers/gpu/drm/i915/i915_drv.h | 1 + 5 files changed, 116 insertions(+) create mode 100644 drivers/gpu/drm/i915/display/intel_dsb.c create mode 100644 drivers/gpu/drm/i915/display/intel_dsb.hdrivers/gpu/drm/i915/Makefile +1
-0@@ -172,6 +172,7 @@ i915-y += \ display/intel_display_power.o \ display/intel_dpio_phy.o \ display/intel_dpll_mgr.o \ + display/intel_dsb.o \ display/intel_fbc.o \ display/intel_fifo_underrun.o \ display/intel_frontbuffer.o \drivers/gpu/drm/i915/display/intel_display_types.h +3
-0@@ -1033,6 +1033,9 @@ struct intel_crtc {/* scalers available on this crtc */ int num_scalers; + +/* per pipe DSB related info */ +struct intel_dsb dsb; };struct intel_plane {drivers/gpu/drm/i915/display/intel_dsb.c new file +80
-0@@ -0,0 +1,80 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright © 2019 Intel Corporation +* +*/ + +#include "i915_drv.h" +#include "intel_display_types.h" + +#define DSB_BUF_SIZE (2 * PAGE_SIZE) + +struct intel_dsb * +intel_dsb_get (struct intel_crtc *crtc) +{ +struct drm_device *dev = crtc->base.dev; +struct drm_i915_private *i915 =to_i915 (dev); +struct intel_dsb *dsb = &crtc->dsb; +struct drm_i915_gem_object *obj; +struct i915_vma *vma; +intel_wakeref_t wakeref; + +if (!HAS_DSB (i915)) +return dsb; + +if (atomic_add_return (1 , &dsb->refcount) !=1 ) +return dsb; + + dsb->id =DSB1 ; + wakeref =intel_runtime_pm_get (&i915->runtime_pm); + + obj =i915_gem_object_create_internal (i915,DSB_BUF_SIZE ); +if (IS_ERR (obj)) { +DRM_ERROR ("Gem object creation failed\n" ); + goto err; + } + +mutex_lock (&i915->drm.struct_mutex); + vma =i915_gem_object_ggtt_pin (obj,NULL ,0 ,0 ,PIN_MAPPABLE ); +mutex_unlock (&i915->drm.struct_mutex); +if (IS_ERR (vma)) { +DRM_ERROR ("Vma creation failed\n" ); +i915_gem_object_put (obj); +atomic_dec (&dsb->refcount); + goto err; + } + + dsb->cmd_buf =i915_gem_object_pin_map (vma->obj,I915_MAP_WC ); +if (IS_ERR (dsb->cmd_buf)) { +DRM_ERROR ("Command buffer creation failed\n" ); +i915_vma_unpin_and_release (&vma,0 ); + dsb->cmd_buf =NULL ; +atomic_dec (&dsb->refcount); + goto err; + } + dsb->vma = vma; + +err: +intel_runtime_pm_put (&i915->runtime_pm, wakeref); +return dsb; +} + +void intel_dsb_put (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *i915 =to_i915 (crtc->base.dev); + +if (!HAS_DSB (i915)) +return ; + +if (WARN_ON (atomic_read (&dsb->refcount) ==0 )) +return ; + +if (atomic_dec_and_test (&dsb->refcount)) { +mutex_lock (&i915->drm.struct_mutex); +i915_gem_object_unpin_map (dsb->vma->obj); +i915_vma_unpin_and_release (&dsb->vma,0 ); +mutex_unlock (&i915->drm.struct_mutex); + dsb->cmd_buf =NULL ; + } +}drivers/gpu/drm/i915/display/intel_dsb.h new file +13
-0@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: MIT +* +* Copyright © 2019 Intel Corporation +*/ + +#ifndef _INTEL_DSB_H +#define _INTEL_DSB_H + +struct intel_crtc ; +struct i915_vma ; + +enum dsb_id { + INVALID_DSB = -1,
drivers/gpu/drm/i915/display/intel_dsb.h line 23
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dsb.h new file +10
-0+DSB1 , +DSB2 , +DSB3 , +MAX_DSB_PER_PIPE +}; + +struct intel_dsb { +atomic_t refcount; +enum dsb_id id; +u32 *cmd_buf;
atomic_t and u32 required #include <linux/types.h> here, added while applying.
Please consider using DRM_I915_WERROR=y config option while developing.
BR,
Jani.
Quoted 20 lines
drivers/gpu/drm/i915/display/intel_dsb.h new file +8
-0+ struct i915_vma *vma; +}; + +struct intel_dsb * +intel_dsb_get (struct intel_crtc *crtc); +void intel_dsb_put (struct intel_dsb *dsb); + +#endif drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -67,6 +67,7 @@#include "display/intel_display.h" #include "display/intel_display_power.h" #include "display/intel_dpll_mgr.h" +#include "display/intel_dsb.h" #include "display/intel_frontbuffer.h" #include "display/intel_gmbus.h" #include "display/intel_opregion.h"
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 3/10 drm/i915/dsb: single register write function for DSB.
In reply to Animesh MannaDSB support single register write through opcode 0x1. Generic api created which accumulate all single register write in a batch buffer and once DSB is triggered, it will program all the registers at the same time.
v1: Initial version.
v2: Unused macro removed and cosmetic changes done. (Shashank)
v3: set free_pos to zero in dsb-put() instead dsb-get() and a cosmetic change. (Shashank)
v4: macro of indexed-write is moved. (Shashank)
--- drivers/gpu/drm/i915/display/intel_dsb.c | 29 ++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 9 ++++++++ 2 files changed, 38 insertions(+)
drivers/gpu/drm/i915/display/intel_dsb.c +29 -0
@@ -9,6 +9,12 @@#define DSB_BUF_SIZE (2 * PAGE_SIZE) +/* DSB opcodes. */ +#define DSB_OPCODE_SHIFT 24 +#define DSB_OPCODE_MMIO_WRITE 0x1 +#define DSB_BYTE_EN 0xF +#define DSB_BYTE_EN_SHIFT 20 +struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc) {
@@ -76,5 +82,28 @@ void intel_dsb_put(struct intel_dsb *dsb)i915_vma_unpin_and_release (&dsb->vma,0 );mutex_unlock (&i915->drm.struct_mutex); dsb->cmd_buf =NULL ; + dsb->free_pos =0 ; + } +} + +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +u32 *buf = dsb->cmd_buf; + +if (!buf) { +I915_WRITE (reg, val); +return ; + } + +if (WARN_ON (dsb->free_pos >=DSB_BUF_SIZE )) { +DRM_DEBUG_KMS ("DSB buffer overflow\n" ); +return ; } + + buf[dsb->free_pos++] = val; + buf[dsb->free_pos++] = (DSB_OPCODE_MMIO_WRITE <<DSB_OPCODE_SHIFT ) | + (DSB_BYTE_EN <<DSB_BYTE_EN_SHIFT ) | +i915_mmio_reg_offset (reg); }
drivers/gpu/drm/i915/display/intel_dsb.h +9 -0
@@ -6,6 +6,8 @@#ifndef _INTEL_DSB_H#define _INTEL_DSB_H +#include "i915_reg.h" +struct intel_crtc ;struct i915_vma ;
@@ -22,10 +24,17 @@ struct intel_dsb {enum dsb_id id;u32 *cmd_buf;struct i915_vma *vma; + +/* +* free_pos will point the first free entry position +* and help in calculating tail of command buffer. +*/ + int free_pos; };struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc);void intel_dsb_put (struct intel_dsb *dsb); +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val);#endif
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 4/10 drm/i915/dsb: Indexed register write function for DSB.
In reply to Animesh MannaDSB can program large set of data through indexed register write (opcode 0x9) in one shot. DSB feature can be used for bulk register programming e.g. gamma lut programming, HDR meta data programming.
v1: initial version.
v2: simplified code by using ALIGN(). (Chris)
v3: ascii table added as code comment. (Shashank)
v4: cosmetic changes done. (Shashank)
v5: reset ins_start_offset. (Jani)
v6: update ins_start_offset in inel_dsb_reg_write.
--- drivers/gpu/drm/i915/display/intel_dsb.c | 68 ++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 9 ++++ 2 files changed, 77 insertions(+)
drivers/gpu/drm/i915/display/intel_dsb.c +68 -0
@@ -12,8 +12,10 @@/* DSB opcodes. */ #define DSB_OPCODE_SHIFT 24#define DSB_OPCODE_MMIO_WRITE 0x1 +#define DSB_OPCODE_INDEXED_WRITE 0x9#define DSB_BYTE_EN 0xF#define DSB_BYTE_EN_SHIFT 20 +#define DSB_REG_VALUE_MASK 0xfffffstruct intel_dsb *intel_dsb_get (struct intel_crtc *crtc)
@@ -83,9 +85,74 @@ void intel_dsb_put(struct intel_dsb *dsb)mutex_unlock (&i915->drm.struct_mutex); dsb->cmd_buf =NULL ; dsb->free_pos =0 ; + dsb->ins_start_offset =0 ; } } +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +u32 *buf = dsb->cmd_buf; +u32 reg_val; + +if (!buf) { +I915_WRITE (reg, val); +return ; + } + +if (WARN_ON (dsb->free_pos >=DSB_BUF_SIZE )) { +DRM_DEBUG_KMS ("DSB buffer overflow\n" ); +return ; + } + +/* +* For example the buffer will look like below for 3 dwords for auto +* increment register: +* +--------------------------------------------------------+ +* | size = 3 | offset &| value1 | value2 | value3 | zero | +* | | opcode | | | | | +* +--------------------------------------------------------+ +* + + + + + + + +* 0 4 8 12 16 20 24 +* Byte +* +* As every instruction is 8 byte aligned the index of dsb instruction +* will start always from even number while dealing with u32 array. If +* we are writing odd no of dwords, Zeros will be added in the end for +* padding. +*/ + reg_val = buf[dsb->ins_start_offset +1 ] &DSB_REG_VALUE_MASK ; +if (reg_val !=i915_mmio_reg_offset (reg)) { +/* Every instruction should be 8 byte aligned. */ + dsb->free_pos =ALIGN (dsb->free_pos,2 ); + + dsb->ins_start_offset = dsb->free_pos; + +/* Update the size. */ + buf[dsb->free_pos++] =1 ; + +/* Update the opcode and reg. */ + buf[dsb->free_pos++] = (DSB_OPCODE_INDEXED_WRITE << +DSB_OPCODE_SHIFT ) | +i915_mmio_reg_offset (reg); + +/* Update the value. */ + buf[dsb->free_pos++] = val; + }else { +/* Update the new value. */ + buf[dsb->free_pos++] = val; + +/* Update the size. */ + buf[dsb->ins_start_offset]++; + } + +/* if number of data words is odd, then the last dword should be 0.*/ +if (dsb->free_pos &0x1 ) + buf[dsb->free_pos] =0 ; +} +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val) {struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb);
@@ -102,6 +169,7 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val)return ; } + dsb->ins_start_offset = dsb->free_pos; buf[dsb->free_pos++] = val; buf[dsb->free_pos++] = (DSB_OPCODE_MMIO_WRITE <<DSB_OPCODE_SHIFT ) | (DSB_BYTE_EN << DSB_BYTE_EN_SHIFT) |
drivers/gpu/drm/i915/display/intel_dsb.h +9 -0
@@ -30,11 +30,20 @@ struct intel_dsb {* and help in calculating tail of command buffer. */ int free_pos; + +/* +* ins_start_offset will help to store start address of the dsb +* instuction and help in identifying the batch of auto-increment +* register. +*/ + u32 ins_start_offset; };struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc);void intel_dsb_put (struct intel_dsb *dsb);void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val); +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val);#endif
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v9 04/10] drm/i915/dsb: Indexed register write function for DSB.
Quoted 113 lines · Animesh Manna
DSB can program large set of data through indexed register write (opcode
0x9) in one shot. DSB feature can be used for bulk register programming e.g. gamma lut programming, HDR meta data programming.v1: initial version.
v2: simplified code by usingALIGN(). (Chris)
v3: ascii table added as code comment. (Shashank)
v4: cosmetic changes done. (Shashank)
v5: resetins_start_offset. (Jani)
v6: updateins_start_offsetininel_dsb_reg_write.Cc Shashank Sharma <[email protected]>Cc Imre Deak <[email protected]>Cc Jani Nikula <[email protected]>Cc Rodrigo Vivi <[email protected]>Reviewed-by Shashank Sharma <[email protected]>Signed-off-by Animesh Manna <[email protected]>--- drivers/gpu/drm/i915/display/intel_dsb.c | 68 ++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 9 ++++ 2 files changed, 77 insertions(+)drivers/gpu/drm/i915/display/intel_dsb.c +67
-0@@ -12,8 +12,10 @@/* DSB opcodes. */ #define DSB_OPCODE_SHIFT 24#define DSB_OPCODE_MMIO_WRITE 0x1 +#define DSB_OPCODE_INDEXED_WRITE 0x9#define DSB_BYTE_EN 0xF#define DSB_BYTE_EN_SHIFT 20 +#define DSB_REG_VALUE_MASK 0xfffffstruct intel_dsb *intel_dsb_get (struct intel_crtc *crtc)@@ -83,9 +85,74 @@ void intel_dsb_put(struct intel_dsb *dsb)mutex_unlock (&i915->drm.struct_mutex); dsb->cmd_buf =NULL ; dsb->free_pos =0 ; + dsb->ins_start_offset =0 ; } } +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +u32 *buf = dsb->cmd_buf; +u32 reg_val; + +if (!buf) { +I915_WRITE (reg, val); +return ; + } + +if (WARN_ON (dsb->free_pos >=DSB_BUF_SIZE )) { +DRM_DEBUG_KMS ("DSB buffer overflow\n" ); +return ; + } + +/* +* For example the buffer will look like below for 3 dwords for auto +* increment register: +* +--------------------------------------------------------+ +* | size = 3 | offset &| value1 | value2 | value3 | zero | +* | | opcode | | | | | +* +--------------------------------------------------------+ +* + + + + + + + +* 0 4 8 12 16 20 24 +* Byte +* +* As every instruction is 8 byte aligned the index of dsb instruction +* will start always from even number while dealing with u32 array. If +* we are writing odd no of dwords, Zeros will be added in the end for +* padding. +*/ + reg_val = buf[dsb->ins_start_offset +1 ] &DSB_REG_VALUE_MASK ; +if (reg_val !=i915_mmio_reg_offset (reg)) { +/* Every instruction should be 8 byte aligned. */ + dsb->free_pos =ALIGN (dsb->free_pos,2 ); + + dsb->ins_start_offset = dsb->free_pos; + +/* Update the size. */ + buf[dsb->free_pos++] =1 ; + +/* Update the opcode and reg. */ + buf[dsb->free_pos++] = (DSB_OPCODE_INDEXED_WRITE << +DSB_OPCODE_SHIFT ) | +i915_mmio_reg_offset (reg); + +/* Update the value. */ + buf[dsb->free_pos++] = val; + }else { +/* Update the new value. */ + buf[dsb->free_pos++] = val; + +/* Update the size. */ + buf[dsb->ins_start_offset]++; + } + +/* if number of data words is odd, then the last dword should be 0.*/ +if (dsb->free_pos &0x1 ) + buf[dsb->free_pos] =0 ; +} +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val) {struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb);
drivers/gpu/drm/i915/display/intel_dsb.c void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val) · line 172
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dsb.c +1
-0@@ -102,6 +169,7 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val)return ; } + dsb->ins_start_offset = dsb->free_pos;
Okay, I'm being a pedant, but that's kind of part of the job description, I'm afraid.
What if:
intel_dsb_get()intel_dsb_reg_write(dsb, FOO, 0);intel_dsb_indexed_reg_write(dsb, FOO, 0);intel_dsb_commit()intel_dsb_put()
BR,
Jani.
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_dsb.c +0
-0buf[dsb->free_pos++] = val; buf[dsb->free_pos++] = (DSB_OPCODE_MMIO_WRITE <<DSB_OPCODE_SHIFT ) | (DSB_BYTE_EN << DSB_BYTE_EN_SHIFT) |drivers/gpu/drm/i915/display/intel_dsb.h +9
-0@@ -30,11 +30,20 @@ struct intel_dsb {* and help in calculating tail of command buffer. */ int free_pos; + +/* +* ins_start_offset will help to store start address of the dsb +* instuction and help in identifying the batch of auto-increment +* register. +*/ + u32 ins_start_offset; };struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc);void intel_dsb_put (struct intel_dsb *dsb);void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val); +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val);#endif
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v9 04/10] drm/i915/dsb: Indexed register write function for DSB.
Quoted 121 lines · Jani Nikula
Quoted 113 lines · Animesh Manna
DSB can program large set of data through indexed register write (opcode
0x9) in one shot. DSB feature can be used for bulk register programming e.g. gamma lut programming, HDR meta data programming.v1: initial version.
v2: simplified code by usingALIGN(). (Chris)
v3: ascii table added as code comment. (Shashank)
v4: cosmetic changes done. (Shashank)
v5: resetins_start_offset. (Jani)
v6: updateins_start_offsetininel_dsb_reg_write.Cc Shashank Sharma <[email protected]>Cc Imre Deak <[email protected]>Cc Jani Nikula <[email protected]>Cc Rodrigo Vivi <[email protected]>Reviewed-by Shashank Sharma <[email protected]>Signed-off-by Animesh Manna <[email protected]>--- drivers/gpu/drm/i915/display/intel_dsb.c | 68 ++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 9 ++++ 2 files changed, 77 insertions(+)drivers/gpu/drm/i915/display/intel_dsb.c +67
-0@@ -12,8 +12,10 @@/* DSB opcodes. */ #define DSB_OPCODE_SHIFT 24#define DSB_OPCODE_MMIO_WRITE 0x1 +#define DSB_OPCODE_INDEXED_WRITE 0x9#define DSB_BYTE_EN 0xF#define DSB_BYTE_EN_SHIFT 20 +#define DSB_REG_VALUE_MASK 0xfffffstruct intel_dsb *intel_dsb_get (struct intel_crtc *crtc)@@ -83,9 +85,74 @@ void intel_dsb_put(struct intel_dsb *dsb)mutex_unlock (&i915->drm.struct_mutex); dsb->cmd_buf =NULL ; dsb->free_pos =0 ; + dsb->ins_start_offset =0 ; } } +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +u32 *buf = dsb->cmd_buf; +u32 reg_val; + +if (!buf) { +I915_WRITE (reg, val); +return ; + } + +if (WARN_ON (dsb->free_pos >=DSB_BUF_SIZE )) { +DRM_DEBUG_KMS ("DSB buffer overflow\n" ); +return ; + } + +/* +* For example the buffer will look like below for 3 dwords for auto +* increment register: +* +--------------------------------------------------------+ +* | size = 3 | offset &| value1 | value2 | value3 | zero | +* | | opcode | | | | | +* +--------------------------------------------------------+ +* + + + + + + + +* 0 4 8 12 16 20 24 +* Byte +* +* As every instruction is 8 byte aligned the index of dsb instruction +* will start always from even number while dealing with u32 array. If +* we are writing odd no of dwords, Zeros will be added in the end for +* padding. +*/ + reg_val = buf[dsb->ins_start_offset +1 ] &DSB_REG_VALUE_MASK ; +if (reg_val !=i915_mmio_reg_offset (reg)) { +/* Every instruction should be 8 byte aligned. */ + dsb->free_pos =ALIGN (dsb->free_pos,2 ); + + dsb->ins_start_offset = dsb->free_pos; + +/* Update the size. */ + buf[dsb->free_pos++] =1 ; + +/* Update the opcode and reg. */ + buf[dsb->free_pos++] = (DSB_OPCODE_INDEXED_WRITE << +DSB_OPCODE_SHIFT ) | +i915_mmio_reg_offset (reg); + +/* Update the value. */ + buf[dsb->free_pos++] = val; + }else { +/* Update the new value. */ + buf[dsb->free_pos++] = val; + +/* Update the size. */ + buf[dsb->ins_start_offset]++; + } + +/* if number of data words is odd, then the last dword should be 0.*/ +if (dsb->free_pos &0x1 ) + buf[dsb->free_pos] =0 ; +} +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val) {struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb);drivers/gpu/drm/i915/display/intel_dsb.c void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val) · line 172
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dsb.c +1
-0@@ -102,6 +169,7 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val)return ; } + dsb->ins_start_offset = dsb->free_pos;Okay, I'm being a pedant, but that's kind of part of the job description, I'm afraid.
Quoted 7 lines
What if:
intel_dsb_get()intel_dsb_reg_write(dsb, FOO, 0);intel_dsb_indexed_reg_write(dsb, FOO, 0);intel_dsb_commit()intel_dsb_put()
Hi Jani,
I am trying to think a scenario where may write the same register which is having auto-increment capability using both intel_dsb_reg_write and intel_dsb_indexed_reg_write. To set the auto increment mode we may need to write a different register to control auto-increment mode.
If there is any practical scenario, do you want to me to add now?
Currently checking register value only while creating buffer for auto-increment register. If we want to add the above then we might need like below because we are introducing a variability factor regarding dsb-api to write the same register in consequent call.
enum dsb_write_type {
NORMAL,
INDEX
};
struct last_write {
u32 reg_val;
enum dsb_write_type type;
}then, last write can be updated in intel_dsb_reg_write() as NORMAL write and later will check in intel_dsb_indexed_reg_write() to identify above mentioned case. Please let me know your suggestion, will do accordingly.
Regards,
Animesh
Quoted 24 lines
BR,
Jani.Quoted 20 lines
drivers/gpu/drm/i915/display/intel_dsb.c +0
-0buf[dsb->free_pos++] = val; buf[dsb->free_pos++] = (DSB_OPCODE_MMIO_WRITE <<DSB_OPCODE_SHIFT ) | (DSB_BYTE_EN << DSB_BYTE_EN_SHIFT) |drivers/gpu/drm/i915/display/intel_dsb.h +7
-0@@ -30,11 +30,20 @@ struct intel_dsb {* and help in calculating tail of command buffer. */ int free_pos; + +/* +* ins_start_offset will help to store start address of the dsb +* instuction and help in identifying the batch of auto-increment +* register. +*/ +u32 ins_start_offset; };
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dsb.h struct intel_dsb { · line 49
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dsb.h +2
-0struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc);void intel_dsb_put (struct intel_dsb *dsb);void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val); +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val);#endif
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v9 04/10] drm/i915/dsb: Indexed register write function for DSB.
Quoted 130 lines · Animesh Manna
Quoted 121 lines · Jani Nikula
Quoted 113 lines · Animesh Manna
DSB can program large set of data through indexed register write (opcode
0x9) in one shot. DSB feature can be used for bulk register programming e.g. gamma lut programming, HDR meta data programming.v1: initial version.
v2: simplified code by usingALIGN(). (Chris)
v3: ascii table added as code comment. (Shashank)
v4: cosmetic changes done. (Shashank)
v5: resetins_start_offset. (Jani)
v6: updateins_start_offsetininel_dsb_reg_write.Cc Shashank Sharma <[email protected]>Cc Imre Deak <[email protected]>Cc Jani Nikula <[email protected]>Cc Rodrigo Vivi <[email protected]>Reviewed-by Shashank Sharma <[email protected]>Signed-off-by Animesh Manna <[email protected]>--- drivers/gpu/drm/i915/display/intel_dsb.c | 68 ++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 9 ++++ 2 files changed, 77 insertions(+)drivers/gpu/drm/i915/display/intel_dsb.c +67
-0@@ -12,8 +12,10 @@/* DSB opcodes. */ #define DSB_OPCODE_SHIFT 24#define DSB_OPCODE_MMIO_WRITE 0x1 +#define DSB_OPCODE_INDEXED_WRITE 0x9#define DSB_BYTE_EN 0xF#define DSB_BYTE_EN_SHIFT 20 +#define DSB_REG_VALUE_MASK 0xfffffstruct intel_dsb *intel_dsb_get (struct intel_crtc *crtc)@@ -83,9 +85,74 @@ void intel_dsb_put(struct intel_dsb *dsb)mutex_unlock (&i915->drm.struct_mutex); dsb->cmd_buf =NULL ; dsb->free_pos =0 ; + dsb->ins_start_offset =0 ; } } +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +u32 *buf = dsb->cmd_buf; +u32 reg_val; + +if (!buf) { +I915_WRITE (reg, val); +return ; + } + +if (WARN_ON (dsb->free_pos >=DSB_BUF_SIZE )) { +DRM_DEBUG_KMS ("DSB buffer overflow\n" ); +return ; + } + +/* +* For example the buffer will look like below for 3 dwords for auto +* increment register: +* +--------------------------------------------------------+ +* | size = 3 | offset &| value1 | value2 | value3 | zero | +* | | opcode | | | | | +* +--------------------------------------------------------+ +* + + + + + + + +* 0 4 8 12 16 20 24 +* Byte +* +* As every instruction is 8 byte aligned the index of dsb instruction +* will start always from even number while dealing with u32 array. If +* we are writing odd no of dwords, Zeros will be added in the end for +* padding. +*/ + reg_val = buf[dsb->ins_start_offset +1 ] &DSB_REG_VALUE_MASK ; +if (reg_val !=i915_mmio_reg_offset (reg)) { +/* Every instruction should be 8 byte aligned. */ + dsb->free_pos =ALIGN (dsb->free_pos,2 ); + + dsb->ins_start_offset = dsb->free_pos; + +/* Update the size. */ + buf[dsb->free_pos++] =1 ; + +/* Update the opcode and reg. */ + buf[dsb->free_pos++] = (DSB_OPCODE_INDEXED_WRITE << +DSB_OPCODE_SHIFT ) | +i915_mmio_reg_offset (reg); + +/* Update the value. */ + buf[dsb->free_pos++] = val; + }else { +/* Update the new value. */ + buf[dsb->free_pos++] = val; + +/* Update the size. */ + buf[dsb->ins_start_offset]++; + } + +/* if number of data words is odd, then the last dword should be 0.*/ +if (dsb->free_pos &0x1 ) + buf[dsb->free_pos] =0 ; +} +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val) {struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb);drivers/gpu/drm/i915/display/intel_dsb.c void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val) · line 172
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dsb.c +1
-0@@ -102,6 +169,7 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val)return ; } + dsb->ins_start_offset = dsb->free_pos;Okay, I'm being a pedant, but that's kind of part of the job description, I'm afraid.
Quoted 7 lines
What if:
intel_dsb_get()intel_dsb_reg_write(dsb, FOO, 0);intel_dsb_indexed_reg_write(dsb, FOO, 0);intel_dsb_commit()intel_dsb_put()
Quoted 8 lines
Hi Jani,
I am trying to think a scenario where may write the same register which is having auto-increment capability using both
intel_dsb_reg_writeandintel_dsb_indexed_reg_write.
To set the auto increment mode we may need to write a different register to control auto-increment mode.
If there is any practical scenario, do you want to me to add now?
It's not a likely scenario, I've pushed the series, thanks for the patches and review.
I think you should be able to look at the contents of the buffer and decide based on that.
BR,
Jani.
Quoted 61 lines
Currently checking register value only while creating buffer for auto-increment register. If we want to add the above then we might need like below because we are introducing a variability factor regarding dsb-api to write the same register in consequent call.
enum
dsb_write_type{
NORMAL,
INDEX
};struct last_write { u32 reg_val; enum dsb_write_type type; }then, last write can be updated in
intel_dsb_reg_write()as NORMAL write and later will check inintel_dsb_indexed_reg_write()to identify above mentioned case.
Please let me know your suggestion, will do accordingly.Regards,
AnimeshQuoted 24 lines
BR,
Jani.Quoted 20 lines
drivers/gpu/drm/i915/display/intel_dsb.c +0
-0buf[dsb->free_pos++] = val; buf[dsb->free_pos++] = (DSB_OPCODE_MMIO_WRITE <<DSB_OPCODE_SHIFT ) | (DSB_BYTE_EN << DSB_BYTE_EN_SHIFT) |drivers/gpu/drm/i915/display/intel_dsb.h +7
-0@@ -30,11 +30,20 @@ struct intel_dsb {* and help in calculating tail of command buffer. */ int free_pos; + +/* +* ins_start_offset will help to store start address of the dsb +* instuction and help in identifying the batch of auto-increment +* register. +*/ +u32 ins_start_offset; };Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dsb.h struct intel_dsb { · line 49
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dsb.h +2
-0struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc);void intel_dsb_put (struct intel_dsb *dsb);void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val); +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val);#endif _______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v9 04/10] drm/i915/dsb: Indexed register write function for DSB.
Quoted 132 lines · Jani Nikula
Quoted 131 lines · Animesh Manna
Quoted 121 lines · Jani Nikula
Quoted 113 lines · Animesh Manna
DSB can program large set of data through indexed register write (opcode
0x9) in one shot. DSB feature can be used for bulk register programming e.g. gamma lut programming, HDR meta data programming.v1: initial version.
v2: simplified code by usingALIGN(). (Chris)
v3: ascii table added as code comment. (Shashank)
v4: cosmetic changes done. (Shashank)
v5: resetins_start_offset. (Jani)
v6: updateins_start_offsetininel_dsb_reg_write.Cc Shashank Sharma <[email protected]>Cc Imre Deak <[email protected]>Cc Jani Nikula <[email protected]>Cc Rodrigo Vivi <[email protected]>Reviewed-by Shashank Sharma <[email protected]>Signed-off-by Animesh Manna <[email protected]>--- drivers/gpu/drm/i915/display/intel_dsb.c | 68 ++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 9 ++++ 2 files changed, 77 insertions(+)drivers/gpu/drm/i915/display/intel_dsb.c +67
-0@@ -12,8 +12,10 @@/* DSB opcodes. */ #define DSB_OPCODE_SHIFT 24#define DSB_OPCODE_MMIO_WRITE 0x1 +#define DSB_OPCODE_INDEXED_WRITE 0x9#define DSB_BYTE_EN 0xF#define DSB_BYTE_EN_SHIFT 20 +#define DSB_REG_VALUE_MASK 0xfffffstruct intel_dsb *intel_dsb_get (struct intel_crtc *crtc)@@ -83,9 +85,74 @@ void intel_dsb_put(struct intel_dsb *dsb)mutex_unlock (&i915->drm.struct_mutex); dsb->cmd_buf =NULL ; dsb->free_pos =0 ; + dsb->ins_start_offset =0 ; } } +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +u32 *buf = dsb->cmd_buf; +u32 reg_val; + +if (!buf) { +I915_WRITE (reg, val); +return ; + } + +if (WARN_ON (dsb->free_pos >=DSB_BUF_SIZE )) { +DRM_DEBUG_KMS ("DSB buffer overflow\n" ); +return ; + } + +/* +* For example the buffer will look like below for 3 dwords for auto +* increment register: +* +--------------------------------------------------------+ +* | size = 3 | offset &| value1 | value2 | value3 | zero | +* | | opcode | | | | | +* +--------------------------------------------------------+ +* + + + + + + + +* 0 4 8 12 16 20 24 +* Byte +* +* As every instruction is 8 byte aligned the index of dsb instruction +* will start always from even number while dealing with u32 array. If +* we are writing odd no of dwords, Zeros will be added in the end for +* padding. +*/ + reg_val = buf[dsb->ins_start_offset +1 ] &DSB_REG_VALUE_MASK ; +if (reg_val !=i915_mmio_reg_offset (reg)) { +/* Every instruction should be 8 byte aligned. */ + dsb->free_pos =ALIGN (dsb->free_pos,2 ); + + dsb->ins_start_offset = dsb->free_pos; + +/* Update the size. */ + buf[dsb->free_pos++] =1 ; + +/* Update the opcode and reg. */ + buf[dsb->free_pos++] = (DSB_OPCODE_INDEXED_WRITE << +DSB_OPCODE_SHIFT ) | +i915_mmio_reg_offset (reg); + +/* Update the value. */ + buf[dsb->free_pos++] = val; + }else { +/* Update the new value. */ + buf[dsb->free_pos++] = val; + +/* Update the size. */ + buf[dsb->ins_start_offset]++; + } + +/* if number of data words is odd, then the last dword should be 0.*/ +if (dsb->free_pos &0x1 ) + buf[dsb->free_pos] =0 ; +} +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val) {struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb);drivers/gpu/drm/i915/display/intel_dsb.c void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val) · line 172
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dsb.c +1
-0@@ -102,6 +169,7 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val)return ; } + dsb->ins_start_offset = dsb->free_pos;Okay, I'm being a pedant, but that's kind of part of the job description, I'm afraid.
Quoted 7 lines
What if:
intel_dsb_get()intel_dsb_reg_write(dsb, FOO, 0);intel_dsb_indexed_reg_write(dsb, FOO, 0);intel_dsb_commit()intel_dsb_put()Hi Jani,
Quoted 8 lines
Quoted 6 lines
I am trying to think a scenario where may write the same register which is having auto-increment capability using both
intel_dsb_reg_writeandintel_dsb_indexed_reg_write.
To set the auto increment mode we may need to write a different register to control auto-increment mode.
If there is any practical scenario, do you want to me to add now?It's not a likely scenario, I've pushed the series, thanks for the patches and review.
Thanks Jani and everyone who helped in review.
Quoted 3 lines
I think you should be able to look at the contents of the buffer and decide based on that.
Yes, got the idea.
Regards,
Animesh
Quoted 63 lines
BR,
Jani.Quoted 58 lines
Currently checking register value only while creating buffer for auto-increment register. If we want to add the above then we might need like below because we are introducing a variability factor regarding dsb-api to write the same register in consequent call.
enum
dsb_write_type{
NORMAL,
INDEX
};struct last_write { u32 reg_val; enum dsb_write_type type; }then, last write can be updated in
intel_dsb_reg_write()as NORMAL write and later will check inintel_dsb_indexed_reg_write()to identify above mentioned case.
Please let me know your suggestion, will do accordingly.Regards,
AnimeshQuoted 23 lines
BR,
Jani.Quoted 20 lines
drivers/gpu/drm/i915/display/intel_dsb.c +0
-0buf[dsb->free_pos++] = val; buf[dsb->free_pos++] = (DSB_OPCODE_MMIO_WRITE <<DSB_OPCODE_SHIFT ) | (DSB_BYTE_EN << DSB_BYTE_EN_SHIFT) |drivers/gpu/drm/i915/display/intel_dsb.h +7
-0@@ -30,11 +30,20 @@ struct intel_dsb {* and help in calculating tail of command buffer. */ int free_pos; + +/* +* ins_start_offset will help to store start address of the dsb +* instuction and help in identifying the batch of auto-increment +* register. +*/ +u32 ins_start_offset; };Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dsb.h struct intel_dsb { · line 49
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dsb.h +2
-0struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc);void intel_dsb_put (struct intel_dsb *dsb);void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val); +void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val);#endif _______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 5/10 drm/i915/dsb: Check DSB engine status.
In reply to Animesh MannaAs per bspec check for DSB status before programming any of its register. Inline function added to check the dsb status.
--- drivers/gpu/drm/i915/display/intel_dsb.c | 9 +++++++++ drivers/gpu/drm/i915/i915_reg.h | 7 +++++++ 2 files changed, 16 insertions(+)
drivers/gpu/drm/i915/display/intel_dsb.c +9 -0
@@ -17,6 +17,15 @@#define DSB_BYTE_EN_SHIFT 20#define DSB_REG_VALUE_MASK 0xfffff +static inline bool is_dsb_busy (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum pipe pipe = crtc->pipe; + +return DSB_STATUS &I915_READ (DSB_CTRL (pipe, dsb->id)); +} +struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc) {
drivers/gpu/drm/i915/i915_reg.h +7 -0
@@ -11684,4 +11684,11 @@ enum skl_power_gate {#define PORT_TX_DFLEXDPCSSS (fia) _MMIO_FIA((fia), 0x00894)#define DP_PHY_MODE_STATUS_NOT_SAFE (tc_port) (1 << (tc_port)) +/* This register controls the Display State Buffer (DSB) engines. */ +#define _DSBSL_INSTANCE_BASE 0x70B00 +#define DSBSL_INSTANCE (pipe, id) (_DSBSL_INSTANCE_BASE + \ + (pipe) * 0x1000 + (id) * 100) +#define DSB_CTRL (pipe, id) _MMIO(DSBSL_INSTANCE(pipe, id) + 0x8) +#define DSB_STATUS (1 << 0) +#endif /* _I915_REG_H_ */
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 6/10 drm/i915/dsb: functions to enable/disable DSB engine.
In reply to Animesh MannaDSB will be used for performance improvement for some special scenario. DSB engine will be enabled based on need and after completion of its work will be disabled. Api added for enable/disable operation by using DSB_CTRL register.
v1: Initial version.
v2: POSTING_READ added after writing control register. (Shashank)
v3: cosmetic changes done. (Shashank)
--- drivers/gpu/drm/i915/display/intel_dsb.c | 40 ++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 41 insertions(+)
drivers/gpu/drm/i915/display/intel_dsb.c +40 -0
@@ -26,6 +26,46 @@ static inline bool is_dsb_busy(struct intel_dsb *dsb)return DSB_STATUS &I915_READ (DSB_CTRL (pipe, dsb->id)); } +static inline bool intel_dsb_enable_engine (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum pipe pipe = crtc->pipe; +u32 dsb_ctrl; + + dsb_ctrl =I915_READ (DSB_CTRL (pipe, dsb->id)); +if (DSB_STATUS & dsb_ctrl) { +DRM_DEBUG_KMS ("DSB engine is busy.\n" ); +return false; + } + + dsb_ctrl |=DSB_ENABLE ; +I915_WRITE (DSB_CTRL (pipe, dsb->id), dsb_ctrl); + +POSTING_READ (DSB_CTRL (pipe, dsb->id)); +return true; +} + +static inline bool intel_dsb_disable_engine (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum pipe pipe = crtc->pipe; +u32 dsb_ctrl; + + dsb_ctrl =I915_READ (DSB_CTRL (pipe, dsb->id)); +if (DSB_STATUS & dsb_ctrl) { +DRM_DEBUG_KMS ("DSB engine is busy.\n" ); +return false; + } + + dsb_ctrl &= ~DSB_ENABLE ; +I915_WRITE (DSB_CTRL (pipe, dsb->id), dsb_ctrl); + +POSTING_READ (DSB_CTRL (pipe, dsb->id)); +return true; +} +struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc) {
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -11689,6 +11689,7 @@ enum skl_power_gate {#define DSBSL_INSTANCE (pipe, id) (_DSBSL_INSTANCE_BASE + \ (pipe) * 0x1000 + (id) * 100)#define DSB_CTRL (pipe, id) _MMIO(DSBSL_INSTANCE(pipe, id) + 0x8) +#define DSB_ENABLE (1 << 31)#define DSB_STATUS (1 << 0)#endif /* _I915_REG_H_ */
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 7/10 drm/i915/dsb: function to trigger workload execution of DSB.
In reply to Animesh MannaBatch buffer will be created through dsb-reg-write function which can have single/multiple request based on usecase and once the buffer is ready commit function will trigger the execution of the batch buffer. All the registers will be updated simultaneously.
v1: Initial version.
v2: Optimized code few places. (Chris)
v3: USed DRM_ERROR for dsb head/tail programming failure. (Shashank)
v4: reset ins_start_offset after commit. (Jani)
--- drivers/gpu/drm/i915/display/intel_dsb.c | 43 ++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dsb.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 2 ++ 3 files changed, 46 insertions(+)
drivers/gpu/drm/i915/display/intel_dsb.c +43 -0
@@ -224,3 +224,46 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val) (DSB_BYTE_EN <<DSB_BYTE_EN_SHIFT ) |i915_mmio_reg_offset (reg); } + +void intel_dsb_commit (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc =container_of (dsb,typeof (*crtc), dsb); +struct drm_device *dev = crtc->base.dev; +struct drm_i915_private *dev_priv =to_i915 (dev); +enum pipe pipe = crtc->pipe; +u32 tail; + +if (!dsb->free_pos) +return ; + +if (!intel_dsb_enable_engine (dsb)) + goto reset; + +if (is_dsb_busy (dsb)) { +DRM_ERROR ("HEAD_PTR write failed - dsb engine is busy.\n" ); + goto reset; + } +I915_WRITE (DSB_HEAD (pipe, dsb->id),i915_ggtt_offset (dsb->vma)); + + tail =ALIGN (dsb->free_pos *4 ,CACHELINE_BYTES ); +if (tail > dsb->free_pos *4 ) +memset (&dsb->cmd_buf[dsb->free_pos],0 , + (tail - dsb->free_pos *4 )); + +if (is_dsb_busy (dsb)) { +DRM_ERROR ("TAIL_PTR write failed - dsb engine is busy.\n" ); + goto reset; + } +DRM_DEBUG_KMS ("DSB execution started - head 0x%x, tail 0x%x\n" , +i915_ggtt_offset (dsb->vma), tail); +I915_WRITE (DSB_TAIL (pipe, dsb->id),i915_ggtt_offset (dsb->vma) + tail); +if (wait_for (!is_dsb_busy (dsb),1 )) { +DRM_ERROR ("Timed out waiting for DSB workload completion.\n" ); + goto reset; + } + +reset: + dsb->free_pos =0 ; + dsb->ins_start_offset =0 ; +intel_dsb_disable_engine (dsb); +}
drivers/gpu/drm/i915/display/intel_dsb.h +1 -0
@@ -45,5 +45,6 @@ void intel_dsb_put(struct intel_dsb *dsb);void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val);void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val); +void intel_dsb_commit (struct intel_dsb *dsb);#endif
drivers/gpu/drm/i915/i915_reg.h +2 -0
@@ -11688,6 +11688,8 @@ enum skl_power_gate {#define _DSBSL_INSTANCE_BASE 0x70B00#define DSBSL_INSTANCE (pipe, id) (_DSBSL_INSTANCE_BASE + \ (pipe) * 0x1000 + (id) * 100) +#define DSB_HEAD (pipe, id) _MMIO(DSBSL_INSTANCE(pipe, id) + 0x0) +#define DSB_TAIL (pipe, id) _MMIO(DSBSL_INSTANCE(pipe, id) + 0x4)#define DSB_CTRL (pipe, id) _MMIO(DSBSL_INSTANCE(pipe, id) + 0x8)#define DSB_ENABLE (1 << 31)#define DSB_STATUS (1 << 0)
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 8/10 drm/i915/dsb: Enable gamma lut programming using DSB.
In reply to Animesh MannaGamma lut programming can be programmed using DSB where bulk register programming can be done using indexed register write which takes number of data and the mmio offset to be written.
Currently enabled for 12-bit gamma LUT which is enabled by default and later 8-bit/10-bit will be enabled in future based on need.
v1: Initial version.
v2: Directly call dsb-api at callsites. (Jani)
v3:
- modified the code as per single dsb instance per crtc. (Shashank)
- Added dsb get/put call in platform specific load_lut hook. (Jani)
- removed dsb pointer from dev_priv. (Jani)
v4: simplified code by dropping ref-count implementation. (Shashank)
--- drivers/gpu/drm/i915/display/intel_color.c | 63 ++++++++++++++-------- 1 file changed, 41 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +41 -22
@@ -611,12 +611,13 @@ static void bdw_load_lut_10(struct intel_crtc *crtc,static void ivb_load_lut_ext_max (struct intel_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +struct intel_dsb *dsb =intel_dsb_get (crtc);enum pipe pipe = crtc->pipe;/* Program the max register to clamp values > 1.0. */ -I915_WRITE (PREC_PAL_EXT_GC_MAX (pipe,0 ),1 <<16 ); -I915_WRITE (PREC_PAL_EXT_GC_MAX (pipe,1 ),1 <<16 ); -I915_WRITE (PREC_PAL_EXT_GC_MAX (pipe,2 ),1 <<16 ); +intel_dsb_reg_write (dsb,PREC_PAL_EXT_GC_MAX (pipe,0 ),1 <<16 ); +intel_dsb_reg_write (dsb,PREC_PAL_EXT_GC_MAX (pipe,1 ),1 <<16 ); +intel_dsb_reg_write (dsb,PREC_PAL_EXT_GC_MAX (pipe,2 ),1 <<16 );/* * Program the gc max 2 register to clamp values > 1.0.
@@ -624,10 +625,15 @@ static void ivb_load_lut_ext_max(struct intel_crtc *crtc)* from 3.0 to 7.0 */ if (INTEL_GEN (dev_priv) >=10 ||IS_GEMINILAKE (dev_priv)) { -I915_WRITE (PREC_PAL_EXT2_GC_MAX (pipe,0 ),1 <<16 ); -I915_WRITE (PREC_PAL_EXT2_GC_MAX (pipe,1 ),1 <<16 ); -I915_WRITE (PREC_PAL_EXT2_GC_MAX (pipe,2 ),1 <<16 ); +intel_dsb_reg_write (dsb,PREC_PAL_EXT2_GC_MAX (pipe,0 ), +1 <<16 ); +intel_dsb_reg_write (dsb,PREC_PAL_EXT2_GC_MAX (pipe,1 ), +1 <<16 ); +intel_dsb_reg_write (dsb,PREC_PAL_EXT2_GC_MAX (pipe,2 ), +1 <<16 ); } + +intel_dsb_put (dsb); }static void ivb_load_luts (const struct intel_crtc_state *crtc_state)
@@ -787,22 +793,23 @@ icl_load_gcmax(const struct intel_crtc_state *crtc_state, const struct drm_color_lut *color) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); -struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +struct intel_dsb *dsb =intel_dsb_get (crtc);enum pipe pipe = crtc->pipe;/* Fixme: LUT entries are 16 bit only, so we can prog 0xFFFF max */ -I915_WRITE (PREC_PAL_GC_MAX (pipe,0 ), color->red); -I915_WRITE (PREC_PAL_GC_MAX (pipe,1 ), color->green); -I915_WRITE (PREC_PAL_GC_MAX (pipe,2 ), color->blue); +intel_dsb_reg_write (dsb,PREC_PAL_GC_MAX (pipe,0 ), color->red); +intel_dsb_reg_write (dsb,PREC_PAL_GC_MAX (pipe,1 ), color->green); +intel_dsb_reg_write (dsb,PREC_PAL_GC_MAX (pipe,2 ), color->blue); +intel_dsb_put (dsb); }static void icl_program_gamma_superfine_segment (const struct intel_crtc_state *crtc_state) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); -struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);const struct drm_property_blob *blob = crtc_state->base.gamma_lut;const struct drm_color_lut *lut = blob->data; +struct intel_dsb *dsb =intel_dsb_get (crtc);enum pipe pipe = crtc->pipe;u32 i;
@@ -813,26 +820,29 @@ icl_program_gamma_superfine_segment(const struct intel_crtc_state *crtc_state)* Superfine segment has 9 entries, corresponding to values * 0, 1/(8 * 128 * 256), 2/(8 * 128 * 256) .... 8/(8 * 128 * 256). */ -I915_WRITE (PREC_PAL_MULTI_SEG_INDEX (pipe),PAL_PREC_AUTO_INCREMENT ); +intel_dsb_reg_write (dsb,PREC_PAL_MULTI_SEG_INDEX (pipe), +PAL_PREC_AUTO_INCREMENT );for (i =0 ; i <9 ; i++) {const struct drm_color_lut *entry = &lut[i]; -I915_WRITE (PREC_PAL_MULTI_SEG_DATA (pipe), -ilk_lut_12p4_ldw (entry)); -I915_WRITE (PREC_PAL_MULTI_SEG_DATA (pipe), -ilk_lut_12p4_udw (entry)); +intel_dsb_indexed_reg_write (dsb,PREC_PAL_MULTI_SEG_DATA (pipe), +ilk_lut_12p4_ldw (entry)); +intel_dsb_indexed_reg_write (dsb,PREC_PAL_MULTI_SEG_DATA (pipe), +ilk_lut_12p4_udw (entry)); } + +intel_dsb_put (dsb); }static void icl_program_gamma_multi_segment (const struct intel_crtc_state *crtc_state) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); -struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);const struct drm_property_blob *blob = crtc_state->base.gamma_lut;const struct drm_color_lut *lut = blob->data;const struct drm_color_lut *entry; +struct intel_dsb *dsb =intel_dsb_get (crtc);enum pipe pipe = crtc->pipe;u32 i;
@@ -847,11 +857,13 @@ icl_program_gamma_multi_segment(const struct intel_crtc_state *crtc_state)* PAL_PREC_INDEX[0] and PAL_PREC_INDEX[1] map to seg2[1], * with seg2[0] being unused by the hardware. */ -I915_WRITE (PREC_PAL_INDEX (pipe),PAL_PREC_AUTO_INCREMENT ); +intel_dsb_reg_write (dsb,PREC_PAL_INDEX (pipe),PAL_PREC_AUTO_INCREMENT );for (i =1 ; i <257 ; i++) { entry = &lut[i *8 ]; -I915_WRITE (PREC_PAL_DATA (pipe),ilk_lut_12p4_ldw (entry)); -I915_WRITE (PREC_PAL_DATA (pipe),ilk_lut_12p4_udw (entry)); +intel_dsb_indexed_reg_write (dsb,PREC_PAL_DATA (pipe), +ilk_lut_12p4_ldw (entry)); +intel_dsb_indexed_reg_write (dsb,PREC_PAL_DATA (pipe), +ilk_lut_12p4_udw (entry)); }/*
@@ -868,20 +880,24 @@ icl_program_gamma_multi_segment(const struct intel_crtc_state *crtc_state)*/ for (i =0 ; i <256 ; i++) { entry = &lut[i *8 *128 ]; -I915_WRITE (PREC_PAL_DATA (pipe),ilk_lut_12p4_ldw (entry)); -I915_WRITE (PREC_PAL_DATA (pipe),ilk_lut_12p4_udw (entry)); +intel_dsb_indexed_reg_write (dsb,PREC_PAL_DATA (pipe), +ilk_lut_12p4_ldw (entry)); +intel_dsb_indexed_reg_write (dsb,PREC_PAL_DATA (pipe), +ilk_lut_12p4_udw (entry)); }/* The last entry in the LUT is to be programmed in GCMAX */ entry = &lut[256 *8 *128 ];icl_load_gcmax (crtc_state, entry);ivb_load_lut_ext_max (crtc); +intel_dsb_put (dsb); }static void icl_load_luts (const struct intel_crtc_state *crtc_state) {const struct drm_property_blob *gamma_lut = crtc_state->base.gamma_lut;struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); +struct intel_dsb *dsb =intel_dsb_get (crtc);if (crtc_state->base.degamma_lut)glk_load_degamma_lut (crtc_state);
@@ -900,6 +916,9 @@ static void icl_load_luts(const struct intel_crtc_state *crtc_state)bdw_load_lut_10 (crtc, gamma_lut,PAL_PREC_INDEX_VALUE (0 ));ivb_load_lut_ext_max (crtc); } + +intel_dsb_commit (dsb); +intel_dsb_put (dsb); }static u32 chv_cgm_degamma_ldw (const struct drm_color_lut *color)
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 9/10 drm/i915/dsb: Enable DSB for gen12.
In reply to Animesh MannaEnabling DSB by setting 1 to has_dsb flag for gen12.
--- drivers/gpu/drm/i915/i915_pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +2 -1
@@ -787,7 +787,8 @@ static const struct intel_device_info intel_elkhartlake_info = { [TRANSCODER_DSI_0] = TRANSCODER_DSI0_OFFSET, \ [TRANSCODER_DSI_1 ] =TRANSCODER_DSI1_OFFSET , \ }, \ - .has_global_mocs = 1 + .has_global_mocs = 1, \ + .display.has_dsb = 1static const struct intel_device_info intel_tigerlake_12_info = {GEN12_FEATURES ,
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 10/10 drm/i915/dsb: Documentation for DSB.
In reply to Animesh MannaAdded docbook info regarding Display State Buffer(DSB) which is added from gen12 onwards to batch submit display HW programming.
v1: Initial version as RFC.
--- Documentation/gpu/i915.rst | 9 ++++ drivers/gpu/drm/i915/display/intel_dsb.c | 68 ++++++++++++++++++++++++ 2 files changed, 77 insertions(+)
Documentation/gpu/i915.rst +9 -0
@@ -246,6 +246,15 @@ Display PLLs .. kernel-doc:: drivers/gpu/drm/i915/display/intel_dpll_mgr.h :internal: +Display State Buffer +-------------------- + +.. kernel-doc:: drivers/gpu/drm/i915/display/intel_dsb.c + :doc: DSB + +.. kernel-doc:: drivers/gpu/drm/i915/display/intel_dsb.c + :internal: + Memory Management and Command Submission ========================================
drivers/gpu/drm/i915/display/intel_dsb.c +68 -0
104 lines not on this page · raw message
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for DSB enablement. (rev9)
In reply to Animesh Manna== Series Details ==
== Series Details ==
Series: DSB enablement. (rev9)
URL : https://patchwork.freedesktop.org/series/63013/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 396d115d8cc6 drm/i915/dsb: feature flag added for display state buffer. 5a60554c2d5d drm/i915/dsb: DSB context creation. -:63: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #63: new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 134 lines checked 32156cd99f53 drm/i915/dsb: single register write function for DSB. 6cebb40b0c3d drm/i915/dsb: Indexed register write function for DSB. 82006824a268 drm/i915/dsb: Check DSB engine status. c6d05e53a15d drm/i915/dsb: functions to enable/disable DSB engine. f3f9d6a4f641 drm/i915/dsb: function to trigger workload execution of DSB. dc74e0b1bce3 drm/i915/dsb: Enable gamma lut programming using DSB. 6ccd2217aa11 drm/i915/dsb: Enable DSB for gen12.89ca6c89252a drm/i915/dsb: Documentation for DSB.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for DSB enablement. (rev9)
In reply to Animesh Manna== Series Details ==
== Series Details ==
Series: DSB enablement. (rev9)
URL : https://patchwork.freedesktop.org/series/63013/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/dsb: feature flag added for display state buffer. Okay!
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for DSB enablement. (rev9)
In reply to Animesh Manna== Series Details ==
== Series Details ==
Series: DSB enablement. (rev9)
URL : https://patchwork.freedesktop.org/series/63013/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14477
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/
Known issues
------------
Here are the changes found in Patchwork_14477 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@bad-open:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/fi-icl-u3/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([fdo#111407])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/fi-kbl-7500u/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_switch@legacy-render:
- fi-icl-u2: [INCOMPLETE][5] ([fdo#107713] / [fdo#111381]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/fi-icl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/fi-icl-u2/igt@[email protected]
* igt@i915_module_load@reload:
- fi-blb-e6850: [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/fi-blb-e6850/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/fi-blb-e6850/igt@[email protected]
* igt@kms_addfb_basic@addfb25-x-tiled:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/fi-icl-u3/igt@[email protected]
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
Participating hosts (54 -> 48)
------------------------------
Additional (1): fi-hsw-4770r
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6928 -> Patchwork_14477
CI-20190529: 20190529
CI_DRM_6928: 74bb5b031ca11c7036f7be21f42a73a057fc8da8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5194: 531d3d02d5e7a2a84d61b92b28fa01b822afc399 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14477: 89ca6c89252aa3e8b3e3fe65ce0d39cf953e642b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
89ca6c89252a drm/i915/dsb: Documentation for DSB. 6ccd2217aa11 drm/i915/dsb: Enable DSB for gen12.dc74e0b1bce3 drm/i915/dsb: Enable gamma lut programming using DSB. f3f9d6a4f641 drm/i915/dsb: function to trigger workload execution of DSB. c6d05e53a15d drm/i915/dsb: functions to enable/disable DSB engine. 82006824a268 drm/i915/dsb: Check DSB engine status. 6cebb40b0c3d drm/i915/dsb: Indexed register write function for DSB. 32156cd99f53 drm/i915/dsb: single register write function for DSB. 5a60554c2d5d drm/i915/dsb: DSB context creation.396d115d8cc6 drm/i915/dsb: feature flag added for display state buffer.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for DSB enablement. (rev9)
In reply to Animesh Manna== Series Details ==
== Series Details ==
Series: DSB enablement. (rev9)
URL : https://patchwork.freedesktop.org/series/63013/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6928_full -> Patchwork_14477_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14477_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@i915_pm_dc@dc6-psr}:
- shard-iclb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_14477_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +21 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb5/igt@[email protected]
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +7 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb1/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108686])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-kbl6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-kbl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
- shard-apl: [PASS][9] -> [INCOMPLETE][10] ([fdo#103927]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-apl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-apl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-apl1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-apl7/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][13] -> [FAIL][14] ([fdo#105767])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-hsw5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-hsw6/igt@[email protected]
* igt@kms_flip@busy-flip:
- shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([fdo#103540])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-hsw5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-hsw4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-skl5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-skl4/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][23] -> [FAIL][24] ([fdo#99912])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-kbl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-kbl3/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([fdo#108566])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-kbl1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-kbl1/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([fdo#103313])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-kbl7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-kbl6/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][29] ([fdo#111325]) -> [PASS][30] +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb5/igt@[email protected]
* {igt@gem_mmap_gtt@close-race}:
- shard-apl: [INCOMPLETE][31] ([fdo#103927]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-apl3/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-apl7/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [DMESG-WARN][33] ([fdo#108686]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-glk4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-glk3/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36] +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-apl1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [INCOMPLETE][37] ([fdo#110741]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-skl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-skl6/igt@[email protected]
* igt@kms_flip@flip-vs-dpms-interruptible:
- shard-iclb: [INCOMPLETE][39] ([fdo#107713]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [FAIL][41] ([fdo#103167]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][43] ([fdo#104108] / [fdo#106978]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-skl9/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-skl10/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][45] ([fdo#108145] / [fdo#110403]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-skl4/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-skl6/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-primary-size-128:
- shard-kbl: [DMESG-WARN][47] ([fdo#103558] / [fdo#105602]) -> [PASS][48] +37 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-kbl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-kbl4/igt@[email protected]
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][49] ([fdo#109441]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@perf@polling:
- shard-skl: [FAIL][51] ([fdo#110728]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-skl1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-skl9/igt@[email protected]
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][53] ([fdo#109276]) -> [PASS][54] +9 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb3/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb1/igt@[email protected]
#### Warnings ####
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [FAIL][55] ([fdo#111330]) -> [SKIP][56] ([fdo#109276])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb4/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb6/igt@[email protected]
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [SKIP][57] ([fdo#109276]) -> [FAIL][58] ([fdo#111330]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-iclb5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-iclb2/igt@[email protected]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-kbl: [SKIP][59] ([fdo#105602] / [fdo#109271] / [fdo#109278]) -> [SKIP][60] ([fdo#109271] / [fdo#109278]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-kbl6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-kbl4/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-snb: [DMESG-WARN][61] ([fdo#102365]) -> [INCOMPLETE][62] ([fdo#105411])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-snb4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-snb1/igt@[email protected]
* igt@kms_panel_fitting@legacy:
- shard-kbl: [SKIP][63] ([fdo#105602] / [fdo#109271]) -> [SKIP][64] ([fdo#109271]) +30 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6928/shard-kbl6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/shard-kbl4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6928 -> Patchwork_14477
CI-20190529: 20190529
CI_DRM_6928: 74bb5b031ca11c7036f7be21f42a73a057fc8da8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5194: 531d3d02d5e7a2a84d61b92b28fa01b822afc399 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14477: 89ca6c89252aa3e8b3e3fe65ce0d39cf953e642b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14477/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx