Skip to content

DSB enablement.

Animesh Manna intel-gfx 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest10 patches 5 repliesIn review
  2. v810 patches 1 replySuperseded
  3. v710 patches 4 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v610 patches20 repliesSuperseded
v511 patches13 repliesSuperseded
v410 patches11 repliesSuperseded
v311 patches16 repliesSuperseded
v215 patches20 repliesSuperseded
v115 patches2 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/i915/dsb: feature flag added for display state buffer.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_device_info.h+3 -00 replies
2/10drm/i915/dsb: DSB context creation.drivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dsb.c +2 more+116 -01 reply
3/10drm/i915/dsb: single register write function for DSB.drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/display/intel_dsb.h+38 -00 replies
4/10drm/i915/dsb: Indexed register write function for DSB.drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/display/intel_dsb.h+77 -04 replies
5/10drm/i915/dsb: Check DSB engine status.drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/i915_reg.h+16 -00 replies
6/10drm/i915/dsb: functions to enable/disable DSB engine.drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/i915_reg.h+41 -00 replies
7/10drm/i915/dsb: function to trigger workload execution of DSB.drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/display/intel_dsb.h drivers/gpu/drm/i915/i915_reg.h+46 -00 replies
8/10drm/i915/dsb: Enable gamma lut programming using DSB.drivers/gpu/drm/i915/display/intel_color.c+41 -220 replies
9/10drm/i915/dsb: Enable DSB for gen12.drivers/gpu/drm/i915/i915_pci.c+2 -10 replies
10/10drm/i915/dsb: Documentation for DSB.Documentation/gpu/i915.rst drivers/gpu/drm/i915/display/intel_dsb.c+77 -00 replies

Reviews trailers per patch

8 of 10 patches have a Reviewed-by or Acked-by.

PatchShashank Sharma
1/10R-b
2/10
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 00/10] DSB enablement.

Display State Buffer (DSB) is hardware capability which allows driver to batch submit HW programming.

As part of initial enablement common api created which currently used to program gamma lut proramming.

Going forwad DSB support can be added for HDR and flip related operation.

HSDES: 1209978241
BSpec: 32020

v1: Initial version.

v2: Move intel_dsb files under display folder and fixed an issue.

v3: As per review comments from Chris and Jani,
- removed some unwanted code. (Chris)
- Used i915_gem_object_create_internal instead of _shmem. (Chris)
- cmd_buf_tail removed and can be derived through vma object. (Chris)
- Simplified and optimized code few places. (Chris)
- Called dsb-api directly in callsites instead going via I915_WRITE. (Jani)

v4: Addressed review commnets from Shashank.

v5: Addressed review commnets from Shashank and Jani.

v6: Addressed review commnets from Shashank.

v7: Addressed review commnets from Shashank and Jani.

v8: Addressed review commnets from Shashank and Jani.

v9: Addressed review commnets from Jani.

Animesh Manna (10):
drm/i915/dsb: feature flag added for display state buffer. drm/i915/dsb: DSB context creation.
drm/i915/dsb: single register write function for DSB. drm/i915/dsb: Indexed register write function for DSB. drm/i915/dsb: Check DSB engine status. drm/i915/dsb: functions to enable/disable DSB engine. drm/i915/dsb: function to trigger workload execution of DSB. drm/i915/dsb: Enable gamma lut programming using DSB. drm/i915/dsb: Enable DSB for gen12.
drm/i915/dsb: Documentation for DSB.

 Documentation/gpu/i915.rst                    |   9 +
 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/display/intel_color.c    |  63 ++--
 .../drm/i915/display/intel_display_types.h    |   3 +
 drivers/gpu/drm/i915/display/intel_dsb.c      | 337 ++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dsb.h      |  50 +++
 drivers/gpu/drm/i915/i915_drv.h               |   3 +
 drivers/gpu/drm/i915/i915_pci.c               |   3 +-
 drivers/gpu/drm/i915/i915_reg.h               |  10 +
 drivers/gpu/drm/i915/intel_device_info.h      |   1 +
 10 files changed, 457 insertions(+), 23 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_dsb.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_dsb.h
Signature · 6 lines
2.22.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx