scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()
Subsystems (2)
PATCH v2 1/1 scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware.
called from the completion path")
---
changes v2:
- add Fixes and Reviewed-by tags
drivers/scsi/qla2xxx/qla_isr.c | 2 -- 1 file changed, 2 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +0 -2
@@ -2858,8 +2858,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)if (sense_len ==0 ) { rsp->status_srb =NULL ; sp->done (sp, cp->result); - }else { -WARN_ON_ONCE (true); } }
Signature · 1 line
2.16.4
Martin K. Petersen
AppliedDaniel,
Quoted 6 lines
Commit
88263208dd23("scsi: qla2xxx: Complain ifsp->done()is not called from the completion path") introduced theWARN_ON_ONCEinqla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware.
Applied to 5.4/scsi-fixes. Thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering