Skip to contentSkip to conversation

scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

PATCH Superseded Daniel Wagner 3 participants 4 messages Sep 26, 2019 – Sep 27, 2019

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware.

Cc Bart Van Assche <[email protected]>
---
 drivers/scsi/qla2xxx/qla_isr.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +0 -2
index 4c26630c1c3e..009fd5a33fcd 100644
@@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)
 	if (sense_len == 0) {
 		rsp->status_srb = NULL;
 		sp->done(sp, cp->result);
-	} else {
-		WARN_ON_ONCE(true);
 	}
 }
 
Signature · 1 line
2.16.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Daniel Wagner

Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware.

Cc Bart Van Assche <[email protected]>
---
 drivers/scsi/qla2xxx/qla_isr.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +0 -0
index 4c26630c1c3e..009fd5a33fcd 100644

drivers/scsi/qla2xxx/qla_isr.c qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) · line 2842

Quoted 8 lines
drivers/scsi/qla2xxx/qla_isr.c +0 -2
@@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)
 	if (sense_len == 0) {
 		rsp->status_srb = NULL;
 		sp->done(sp, cp->result);
-	} else {
-		WARN_ON_ONCE(true);
 	}
 }
 

Not that I can speak for firmware documentation, but:

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		      Teamlead Storage & Networking
[email protected]			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
Reviewed-by on v1 1/1
#2 lore raw
In reply to Daniel Wagner
Quoted 18 lines · Daniel Wagner

Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware.

Cc Bart Van Assche <[email protected]>
---
 drivers/scsi/qla2xxx/qla_isr.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +0 -0
index 4c26630c1c3e..009fd5a33fcd 100644

drivers/scsi/qla2xxx/qla_isr.c qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) · line 2841

Quoted 7 lines
drivers/scsi/qla2xxx/qla_isr.c +0 -2
@@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)
 	if (sense_len == 0) {
 		rsp->status_srb = NULL;
 		sp->done(sp, cp->result);
-	} else {
-		WARN_ON_ONCE(true);
 	}
 }

Should the following be added?

Fixes 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not

called from the completion path")

Anyway:

#3 lore raw

Hi,

Quoted 4 lines

Should the following be added?

Fixes 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not

called from the completion path")

Good point. Just send out and updated version

Quoted 3 lines

Anyway:

Thanks!
Daniel