scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()
Subsystems (2)
PATCH 1/1 scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware.
--- drivers/scsi/qla2xxx/qla_isr.c | 2 -- 1 file changed, 2 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +0 -2
@@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)if (sense_len ==0 ) { rsp->status_srb =NULL ; sp->done (sp, cp->result); - }else { -WARN_ON_ONCE (true); } }
Signature · 1 line
2.16.4
Quoted 19 lines · Daniel Wagner
Commit
88263208dd23("scsi: qla2xxx: Complain ifsp->done()is not called from the completion path") introduced theWARN_ON_ONCEinqla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware.Cc Bart Van Assche <[email protected]>Signed-off-by Daniel Wagner <[email protected]>--- drivers/scsi/qla2xxx/qla_isr.c | 2 -- 1 file changed, 2 deletions(-)drivers/scsi/qla2xxx/qla_isr.c +0
-0
drivers/scsi/qla2xxx/qla_isr.c qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) · line 2842
Quoted 8 lines
drivers/scsi/qla2xxx/qla_isr.c +0
-2@@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)if (sense_len ==0 ) { rsp->status_srb =NULL ; sp->done (sp, cp->result); - }else { -WARN_ON_ONCE (true); } }
Not that I can speak for firmware documentation, but:
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 247165 (AG München), GF: Felix Imendörffer
Quoted 18 lines · Daniel Wagner
Commit
88263208dd23("scsi: qla2xxx: Complain ifsp->done()is not called from the completion path") introduced theWARN_ON_ONCEinqla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware.Cc Bart Van Assche <[email protected]>Signed-off-by Daniel Wagner <[email protected]>--- drivers/scsi/qla2xxx/qla_isr.c | 2 -- 1 file changed, 2 deletions(-)drivers/scsi/qla2xxx/qla_isr.c +0
-0
drivers/scsi/qla2xxx/qla_isr.c qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) · line 2841
Quoted 7 lines
drivers/scsi/qla2xxx/qla_isr.c +0
-2@@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)if (sense_len ==0 ) { rsp->status_srb =NULL ; sp->done (sp, cp->result); - }else { -WARN_ON_ONCE (true); } }
Should the following be added?
called from the completion path")
Anyway:
Hi,
Quoted 4 lines
Should the following be added?
Fixes 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is notcalled from the completion path")
Good point. Just send out and updated version
Quoted 3 lines
Anyway:
Reviewed-by Bart Van Assche <[email protected]>
Thanks!
Daniel