Skip to contentSkip to conversation

powerpc/pseries: Remove confusing warning message.

PATCH Applied Laurent Dufour 3 participants 4 messages Oct 1, 2019 – Oct 11, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/pseries: Remove confusing warning message.

Since the commit 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics"), a warning message is displayed when booting a guest on top of KVM:

lpar: arch/powerpc/platforms/pseries/lpar.c pseries_lpar_read_hblkrm_characteristics Error calling get-system-parameter (0xfffffffd)

This message is displayed because this hypervisor is not supporting the H_BLOCK_REMOVE hcall and thus is not exposing the corresponding feature.

Reading the TLB Block Invalidate Characteristics should not be done if the feature is not exposed.

Fixes 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics")
---
 arch/powerpc/platforms/pseries/lpar.c | 3 +++
 1 file changed, 3 insertions(+)
arch/powerpc/platforms/pseries/lpar.c +3 -0
index b53359258d99..f87a5c64e24d 100644
@@ -1419,6 +1419,9 @@ void __init pseries_lpar_read_hblkrm_characteristics(void)
 	unsigned char local_buffer[SPLPAR_TLB_BIC_MAXLENGTH];
 	int call_status, len, idx, bpsize;
 
+	if (!firmware_has_feature(FW_FEATURE_BLOCK_REMOVE))
+		return;
+
 	spin_lock(&rtas_data_buf_lock);
 	memset(rtas_data_buf, 0, RTAS_DATA_BUF_SIZE);
 	call_status = rtas_call(rtas_token("ibm,get-system-parameter"), 3, 1,
Signature · 1 line
2.23.0
#2 lore raw
In reply to Laurent Dufour
Quoted 9 lines · Laurent Dufour

Since the commit 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics"), a warning message is displayed when booting a guest on top of KVM:

lpar: arch/powerpc/platforms/pseries/lpar.c pseries_lpar_read_hblkrm_characteristics Error calling get-system-parameter (0xfffffffd)

This message is displayed because this hypervisor is not supporting the H_BLOCK_REMOVE hcall and thus is not exposing the corresponding feature.

Quoted 6 lines

Reading the TLB Block Invalidate Characteristics should not be done if the feature is not exposed.

Fixes 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics")

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/9123b7914823a7d81dd0e5d8ae40bc6f1ee869c8

cheers

#3 lore raw
In reply to Laurent Dufour
Quoted 9 lines · Laurent Dufour

Since the commit 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics"), a warning message is displayed when booting a guest on top of KVM:

lpar: arch/powerpc/platforms/pseries/lpar.c pseries_lpar_read_hblkrm_characteristics Error calling get-system-parameter (0xfffffffd)

This message is displayed because this hypervisor is not supporting the H_BLOCK_REMOVE hcall and thus is not exposing the corresponding feature.

Quoted 6 lines

Reading the TLB Block Invalidate Characteristics should not be done if the feature is not exposed.

Fixes 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics")

Reapplied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/4ab8a485f7bc69e04e3e8d75f62bdcac5f4ed02e

cheers