powerpc/pseries: Remove confusing warning message.
Subsystems (2)
PATCH 1/1 powerpc/pseries: Remove confusing warning message.
Since the commit 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics"), a warning message is displayed when booting a guest on top of KVM:
lpar: arch/powerpc/platforms/pseries/lpar.c pseries_lpar_read_hblkrm_characteristics Error calling get-system-parameter (0xfffffffd)
This message is displayed because this hypervisor is not supporting the H_BLOCK_REMOVE hcall and thus is not exposing the corresponding feature.
Reading the TLB Block Invalidate Characteristics should not be done if the feature is not exposed.
--- arch/powerpc/platforms/pseries/lpar.c | 3 +++ 1 file changed, 3 insertions(+)
arch/powerpc/platforms/pseries/lpar.c +3 -0
@@ -1419,6 +1419,9 @@ void __init pseries_lpar_read_hblkrm_characteristics(void)unsigned char local_buffer[SPLPAR_TLB_BIC_MAXLENGTH ];int call_status, len, idx, bpsize; +if (!firmware_has_feature (FW_FEATURE_BLOCK_REMOVE )) +return ; +spin_lock (&rtas_data_buf_lock);memset (rtas_data_buf,0 ,RTAS_DATA_BUF_SIZE ); call_status = rtas_call(rtas_token("ibm,get-system-parameter"), 3, 1,
Signature · 1 line
2.23.0
Hi Laurent,
Quoted 3 lines · On Tue, 1 Oct 2019 15:29:28 +0200 Laurent Dufour <[email protected]> wrote:
Fixes 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics")Reported-by Stephen Rothwell <[email protected]>
Please use my external email address <[email protected]>, thanks.
Signature · 2 lines
Cheers, Stephen Rothwell
Michael Ellerman
AppliedQuoted 9 lines · Laurent Dufour
Since the commit
1211ee61b4a8("powerpc/pseries: Read TLB Block Invalidate Characteristics"), a warning message is displayed when booting a guest on top of KVM:lpar:
arch/powerpc/platforms/pseries/lpar.cpseries_lpar_read_hblkrm_characteristicsError calling get-system-parameter (0xfffffffd)This message is displayed because this hypervisor is not supporting the
H_BLOCK_REMOVEhcall and thus is not exposing the corresponding feature.
Quoted 6 lines
Reading the TLB Block Invalidate Characteristics should not be done if the feature is not exposed.
Fixes 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Laurent Dufour <[email protected]>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/9123b7914823a7d81dd0e5d8ae40bc6f1ee869c8
cheers
Quoted 9 lines · Laurent Dufour
Since the commit
1211ee61b4a8("powerpc/pseries: Read TLB Block Invalidate Characteristics"), a warning message is displayed when booting a guest on top of KVM:lpar:
arch/powerpc/platforms/pseries/lpar.cpseries_lpar_read_hblkrm_characteristicsError calling get-system-parameter (0xfffffffd)This message is displayed because this hypervisor is not supporting the
H_BLOCK_REMOVEhcall and thus is not exposing the corresponding feature.
Quoted 6 lines
Reading the TLB Block Invalidate Characteristics should not be done if the feature is not exposed.
Fixes 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Laurent Dufour <[email protected]>
Reapplied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/4ab8a485f7bc69e04e3e8d75f62bdcac5f4ed02e
cheers