Skip to contentSkip to conversation

peci: aspeed: Add AST2600 compatible

PATCH In review Chia-Wei, Wang 4 participants 10 messages Oct 2, 2019 – Oct 15, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover peci: aspeed: Add AST2600 compatible

Update the Aspeed PECI driver with the AST2600 compatible string. A new comptabile string is needed for the extended HW feature of AST2600.

Chia-Wei, Wang (2):
peci: aspeed: Add AST2600 compatible string
dt-bindings: peci: aspeed: Add AST2600 compatible

 Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
 drivers/peci/peci-aspeed.c                             | 1 +
 2 files changed, 2 insertions(+)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 peci: aspeed: Add AST2600 compatible string

The AST2600 SoC contains the same register set as AST25xx.

---
 drivers/peci/peci-aspeed.c | 1 +
 1 file changed, 1 insertion(+)
drivers/peci/peci-aspeed.c +1 -0
index 51cb2563ceb6..4eed119dc83b 100644
@@ -485,6 +485,7 @@ static int aspeed_peci_remove(struct platform_device *pdev)
 static const struct of_device_id aspeed_peci_of_table[] = {
 	{ .compatible = "aspeed,ast2400-peci", },
 	{ .compatible = "aspeed,ast2500-peci", },
+	{ .compatible = "aspeed,ast2600-peci", },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, aspeed_peci_of_table);
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 dt-bindings: peci: aspeed: Add AST2600 compatible

In reply to Chia-Wei, Wang

Document the AST2600 PECI controller compatible string.

---
 Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/peci/peci-aspeed.txt +1 -0
index cdca73a3b7d8..cddd2d2aa58f 100644
@@ -4,6 +4,7 @@ Required properties:
 - compatible        : Should be one of:
 			"aspeed,ast2400-peci"
 			"aspeed,ast2500-peci"
+			"aspeed,ast2600-peci"
 - reg               : Should contain PECI controller registers location and
 		      length.
 - #address-cells    : Should be <1> required to define a client address.
Signature · 1 line
2.17.1
#4 lore raw
In reply to Chia-Wei, Wang

Hi Chia-Wei,

Quoted 4 lines · Wang

Update the Aspeed PECI driver with the AST2600 compatible string. A new comptabile string is needed for the extended HW feature of AST2600.

Quoted 8 lines

Chia-Wei, Wang (2):
peci: aspeed: Add AST2600 compatible string
dt-bindings: peci: aspeed: Add AST2600 compatible

  Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
  drivers/peci/peci-aspeed.c                             | 1 +
  2 files changed, 2 insertions(+)

PECI subsystem isn't in linux upstream yet so you should submit it into OpenBMC dev-5.3 tree only.

Cheers,

Jae

maintainer
#5 lore raw
Quoted 12 lines · Jae Hyun Yoo

Hi Chia-Wei,

Quoted 8 lines · Wang

Update the Aspeed PECI driver with the AST2600 compatible string. A new comptabile string is needed for the extended HW feature of AST2600.

Chia-Wei, Wang (2):
peci: aspeed: Add AST2600 compatible string
dt-bindings: peci: aspeed: Add AST2600 compatible

Quoted 7 lines
Quoted 4 lines
  Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
  drivers/peci/peci-aspeed.c                             | 1 +
  2 files changed, 2 insertions(+)

PECI subsystem isn't in linux upstream yet so you should submit it into OpenBMC dev-5.3 tree only.

OpenBMC has been carrying the out of tree patches for some time now. I haven't seen a new version posted for a while. Do you have a timeline for when you plan to submit it upstream?

#6 lore raw
Quoted 18 lines · Joel Stanley
Quoted 17 lines · Jae Hyun Yoo

Hi Chia-Wei,

Quoted 12 lines · Wang

Update the Aspeed PECI driver with the AST2600 compatible string. A new comptabile string is needed for the extended HW feature of AST2600.

Chia-Wei, Wang (2):
peci: aspeed: Add AST2600 compatible string
dt-bindings: peci: aspeed: Add AST2600 compatible

   Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
   drivers/peci/peci-aspeed.c                             | 1 +
   2 files changed, 2 insertions(+)
Quoted 6 lines
Quoted 2 lines

PECI subsystem isn't in linux upstream yet so you should submit it into OpenBMC dev-5.3 tree only.

OpenBMC has been carrying the out of tree patches for some time now. I haven't seen a new version posted for a while. Do you have a timeline for when you plan to submit it upstream?

Thanks for your effort for carrying the out of tree patches in OpenBMC. I don't have a exact timeline but I'm gonna upstream it as soon as it gets ready.

Thanks,

Jae

#7 lore raw

Hi Jae Hyun,

Thanks for the feedback.
For now should I use GitHub pull-request to submit the patches of PECI-related change to OpenBMC dev-5.3 tree only?

Regards,
Chiawei

************* Email Confidentiality Notice ********************
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.

-----Original Message-----
From: Jae Hyun Yoo [mailto:jae.hyun.yoo at linux.intel.com]
Sent: Thursday, October 3, 2019 7:43 AM
To: Joel Stanley <[email protected]>
Cc: ChiaWei Wang <[email protected]>; Jason M Biils <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Andrew Jeffery <[email protected]>; linux-aspeed <[email protected]>; OpenBMC Maillist <[email protected]>; devicetree <[email protected]>; Linux ARM <[email protected]>; Linux Kernel Mailing List <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH 0/2] peci: aspeed: Add AST2600 compatible

Quoted 18 lines · Joel Stanley
Quoted 17 lines · Jae Hyun Yoo

Hi Chia-Wei,

Quoted 12 lines · Wang

Update the Aspeed PECI driver with the AST2600 compatible string. A new comptabile string is needed for the extended HW feature of AST2600.

Chia-Wei, Wang (2):
peci: aspeed: Add AST2600 compatible string
dt-bindings: peci: aspeed: Add AST2600 compatible

   Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
   drivers/peci/peci-aspeed.c                             | 1 +
   2 files changed, 2 insertions(+)
Quoted 6 lines
Quoted 2 lines

PECI subsystem isn't in linux upstream yet so you should submit it into OpenBMC dev-5.3 tree only.

OpenBMC has been carrying the out of tree patches for some time now. I haven't seen a new version posted for a while. Do you have a timeline for when you plan to submit it upstream?

Thanks for your effort for carrying the out of tree patches in OpenBMC. I don't have a exact timeline but I'm gonna upstream it as soon as it gets ready.

Thanks,

Jae

#8 lore raw
Quoted 4 lines · ChiaWei Wang

Hi Jae Hyun,

Thanks for the feedback.
For now should I use GitHub pull-request to submit the patches of PECI-related change to OpenBMC dev-5.3 tree only?

You could submit this patch series to OpenBMC mailing list with [PATCH linux dev-5.3] prefix.

Thanks,

Jae

#9 lore raw

Sure. We will re-submit the patches with the revision suggested. Thanks.

Regards,
Chiawei

************* Email Confidentiality Notice ********************
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.

-----Original Message-----
From: Jae Hyun Yoo [mailto:jae.hyun.yoo at linux.intel.com]
Sent: Friday, October 4, 2019 12:20 AM
To: ChiaWei Wang <[email protected]>; Joel Stanley <[email protected]>
Cc: Jason M Biils <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Andrew Jeffery <[email protected]>; linux-aspeed <[email protected]>; OpenBMC Maillist <[email protected]>; devicetree <[email protected]>; Linux ARM <[email protected]>; Linux Kernel Mailing List <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH 0/2] peci: aspeed: Add AST2600 compatible

Quoted 4 lines · ChiaWei Wang

Hi Jae Hyun,

Thanks for the feedback.
For now should I use GitHub pull-request to submit the patches of PECI-related change to OpenBMC dev-5.3 tree only?

You could submit this patch series to OpenBMC mailing list with [PATCH linux dev-5.3] prefix.

Thanks,

Jae