Patch "soundwire: fix regmap dependencies and align with other serial links" has been added to the 5.2-stable tree
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 91 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
soundwire: fix regmap dependencies and align with other serial links
to the 5.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summaryThe filename of the patch is:
soundwire-fix-regmap-dependencies-and-align-with-oth.patch
and it can be found in the queue-5.2 subdirectory.If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit
3287dff699a585506096287541cc4414600899c7Author: Pierre-Louis Bossart <[email protected]> Date: Thu Jul 18 18:02:15 2019 -0500soundwire: fix regmap dependencies and align with other serial links
[ Upstream commit
8676b3ca4673517650fd509d7fa586aff87b3c28]The existing code has a mixed select/depend usage which makes no sense.
config
SOUNDWIRE_BUS
tristate
selectREGMAP_SOUNDWIREconfig
REGMAP_SOUNDWIRE
tristate
depends onSOUNDWIRE_BUSLet's remove one layer of
Kconfigdefinitions and align with the solutions used by all other serial links.Signed-off-by Pierre-Louis Bossart <[email protected]>Signed-off-by Vinod Koul <[email protected]>Signed-off-by Sasha Levin <[email protected]>drivers/base/regmap/Kconfig +1
-1@@ -44,7 +44,7 @@ config REGMAP_IRQ config REGMAP_SOUNDWIRE tristate - depends on SOUNDWIRE_BUS + depends on SOUNDWIRE config REGMAP_SCCB tristatedrivers/soundwire/Kconfig +1
-6@@ -4,7 +4,7 @@ # menuconfig SOUNDWIRE - bool "SoundWire support" + tristate "SoundWire support" help SoundWire is a 2-Pin interface with data and clock line ratified by the MIPI Alliance. SoundWire is used for transporting data@@ -17,17 +17,12 @@ if SOUNDWIRE comment "SoundWire Devices" -config SOUNDWIRE_BUS - tristate - select REGMAP_SOUNDWIRE - config SOUNDWIRE_CADENCE tristate config SOUNDWIRE_INTEL tristate "Intel SoundWire Master driver" select SOUNDWIRE_CADENCE - select SOUNDWIRE_BUS depends on X86 && ACPI && SND_SOC help SoundWire Intel Master driver.drivers/soundwire/Makefile +0
-0
drivers/soundwire/Makefile line 11
Quoted 8 lines
drivers/soundwire/Makefile +1
-1@@ -5,7 +5,7 @@ #Bus Objs soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o -obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o +obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o #Cadence Objs soundwire-cadence-objs := cadence_master.o
Do any of these Kconfig changes actually fix any real issue? It looks like they are all just "cleanups" to me. What problem are they solving?
thanks,
greg k-h