Skip to contentSkip to conversation

Patch "soundwire: fix regmap dependencies and align with other serial links" has been added to the 5.2-stable tree

DISCUSSION Greg KH 1 participant 1 message Oct 6, 2019 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author
#1 lore raw
Quoted 91 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

soundwire: fix regmap dependencies and align with other serial links

to the 5.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
soundwire-fix-regmap-dependencies-and-align-with-oth.patch
and it can be found in the queue-5.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

commit 3287dff699a585506096287541cc4414600899c7

Author: Pierre-Louis Bossart <[email protected]>
Date:   Thu Jul 18 18:02:15 2019 -0500

soundwire: fix regmap dependencies and align with other serial links

[ Upstream commit 8676b3ca4673517650fd509d7fa586aff87b3c28 ]

The existing code has a mixed select/depend usage which makes no sense.

config SOUNDWIRE_BUS
tristate
select REGMAP_SOUNDWIRE

config REGMAP_SOUNDWIRE
tristate
depends on SOUNDWIRE_BUS

Let's remove one layer of Kconfig definitions and align with the solutions used by all other serial links.

drivers/base/regmap/Kconfig +1 -1
index 6ad5ef48b61ee..8cd2ac650b505 100644
@@ -44,7 +44,7 @@ config REGMAP_IRQ
 
 config REGMAP_SOUNDWIRE
 	tristate
-	depends on SOUNDWIRE_BUS
+	depends on SOUNDWIRE
 
 config REGMAP_SCCB
 	tristate
drivers/soundwire/Kconfig +1 -6
index 3a01cfd70fdcd..f518273cfbe3c 100644
@@ -4,7 +4,7 @@
 #
 
 menuconfig SOUNDWIRE
-	bool "SoundWire support"
+	tristate "SoundWire support"
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
@@ -17,17 +17,12 @@ if SOUNDWIRE
 
 comment "SoundWire Devices"
 
-config SOUNDWIRE_BUS
-	tristate
-	select REGMAP_SOUNDWIRE
-
 config SOUNDWIRE_CADENCE
 	tristate
 
 config SOUNDWIRE_INTEL
 	tristate "Intel SoundWire Master driver"
 	select SOUNDWIRE_CADENCE
-	select SOUNDWIRE_BUS
 	depends on X86 && ACPI && SND_SOC
 	help
 	  SoundWire Intel Master driver.
drivers/soundwire/Makefile +0 -0
index fd99a831b92a0..45b7e50016539 100644

drivers/soundwire/Makefile line 11

Quoted 8 lines
drivers/soundwire/Makefile +1 -1
@@ -5,7 +5,7 @@
 
 #Bus Objs
 soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o
-obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o
+obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o
 
 #Cadence Objs
 soundwire-cadence-objs := cadence_master.o

Do any of these Kconfig changes actually fix any real issue? It looks like they are all just "cleanups" to me. What problem are they solving?

thanks,

greg k-h