Skip to contentSkip to conversation

ptp: fix typo of "mechanism" in Kconfig help text

PATCH Applied Antonio Borneo 5 participants 18 messages Oct 7, 2019 – Nov 25, 2020

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ptp: fix typo of "mechanism" in Kconfig help text

Fix typo s/mechansim/mechanism/

---
 drivers/ptp/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ptp/Kconfig +2 -2
index 960961fb0d7c..0517272a268e 100644
@@ -97,8 +97,8 @@ config PTP_1588_CLOCK_PCH
 	help
 	  This driver adds support for using the PCH EG20T as a PTP
 	  clock. The hardware supports time stamping of PTP packets
-	  when using the end-to-end delay (E2E) mechansim. The peer
-	  delay mechansim (P2P) is not supported.
+	  when using the end-to-end delay (E2E) mechanism. The peer
+	  delay mechanism (P2P) is not supported.
 
 	  This clock is only useful if your PTP programs are getting
 	  hardware time stamps on the PTP Ethernet packets using the
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 staging: rtl8723bs: fix typo of "mechanism" in comment

Fix typo s/mechansim/mechanism/

---
 drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/hal_btcoex.c +1 -1
index 6e4a1fcb8790..d5793e4614bf 100644
@@ -1315,7 +1315,7 @@ void EXhalbtcoutsrc_DisplayBtCoexInfo(PBTC_COEXIST pBtCoexist)
 
 /*
  * Description:
- *Run BT-Coexist mechansim or not
+ *Run BT-Coexist mechanism or not
  *
  */
 void hal_btcoex_SetBTCoexist(struct adapter *padapter, u8 bBtExist)
Signature · 1 line
2.23.0
#2 lore raw

PATCH 1/1 net: stmmac: add flexible PPS to dwmac 4.10a

In reply to Antonio Borneo

All the registers and the functionalities used in the callback dwmac5_flex_pps_config() are common between dwmac 4.10a [1] and 5.00a [2].

Reuse the same callback for dwmac 4.10a too.

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

---
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +1 -0
index 2cb9c53f93b8..3006047213ea 100644
@@ -864,6 +864,7 @@ const struct stmmac_ops dwmac410_ops = {
 	.pcs_get_adv_lp = dwmac4_get_adv_lp,
 	.debug = dwmac4_debug,
 	.set_filter = dwmac4_set_filter,
+	.flex_pps_config = dwmac5_flex_pps_config,
 	.set_mac_loopback = dwmac4_set_mac_loopback,
 	.update_vlan_hash = dwmac4_update_vlan_hash,
 	.sarc_configure = dwmac4_sarc_configure,
Signature · 1 line
2.23.0
#3 lore raw

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

Quoted 4 lines · Antonio Borneo

All the registers and the functionalities used in the callback dwmac5_flex_pps_config() are common between dwmac 4.10a [1] and 5.00a [2].

Quoted 8 lines

Reuse the same callback for dwmac 4.10a too.

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Applied to net-next.

#4 lore raw

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

Hello Jakub,

Quoted 7 lines · Jakub Kicinski
Quoted 6 lines · Antonio Borneo

All the registers and the functionalities used in the callback dwmac5_flex_pps_config() are common between dwmac 4.10a [1] and 5.00a [2].

Reuse the same callback for dwmac 4.10a too.

Quoted 8 lines
Quoted 6 lines

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Applied to net-next.

This patch seems to have been fuzzily applied at the wrong location. The diff describes extension of dwmac 4.10a and so does the @@ line:

  @@ -864,6 +864,7 @@ const struct stmmac_ops dwmac410_ops = {

The patch was applied mainline as 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a"), but it extends dwmac4_ops instead:

  @@ -938,6 +938,7 @@ const struct stmmac_ops dwmac4_ops = {

I don't know if dwmac4 actually supports FlexPPS, so I think it's better to be on the safe side and revert 757926247836 and add the change for the correct variant.

Cheers,
Ahmad

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#5 lore raw

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

Quoted 24 lines · Ahmad Fatoum

Hello Jakub,

Quoted 7 lines · Jakub Kicinski
Quoted 6 lines · Antonio Borneo

All the registers and the functionalities used in the callback dwmac5_flex_pps_config() are common between dwmac 4.10a [1] and 5.00a [2].

Reuse the same callback for dwmac 4.10a too.

Quoted 8 lines
Quoted 6 lines

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Applied to net-next.

This patch seems to have been fuzzily applied at the wrong location. The diff describes extension of dwmac 4.10a and so does the @@ line:

  @@ -864,6 +864,7 @@ const struct stmmac_ops dwmac410_ops = {

Quoted 8 lines

The patch was applied mainline as 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a"), but it extends dwmac4_ops instead:

  @@ -938,6 +938,7 @@ const struct stmmac_ops dwmac4_ops = {

I don't know if dwmac4 actually supports FlexPPS, so I think it's better to be on the safe side and revert 757926247836 and add the change for the correct variant.

Agree,
the patch get applied to the wrong place!

Antonio

Quoted 5 lines

Cheers,
Ahmad

maintainer
#6 lore raw

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

Quoted 26 lines · On Tue, 24 Nov 2020 15:23:27 +0100 Antonio Borneo wrote:
Quoted 25 lines · Ahmad Fatoum
Quoted 7 lines · Jakub Kicinski
Quoted 6 lines · Antonio Borneo

All the registers and the functionalities used in the callback dwmac5_flex_pps_config() are common between dwmac 4.10a [1] and 5.00a [2].

Reuse the same callback for dwmac 4.10a too.

Quoted 8 lines
Quoted 6 lines

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Applied to net-next.

This patch seems to have been fuzzily applied at the wrong location. The diff describes extension of dwmac 4.10a and so does the @@ line:

  @@ -864,6 +864,7 @@ const struct stmmac_ops dwmac410_ops = {

The patch was applied mainline as 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a"), but it extends dwmac4_ops instead:

Quoted 8 lines
Quoted 5 lines

  @@ -938,6 +938,7 @@ const struct stmmac_ops dwmac4_ops = {

I don't know if dwmac4 actually supports FlexPPS, so I think it's better to be on the safe side and revert 757926247836 and add the change for the correct variant.

Agree,
the patch get applied to the wrong place!

:-o

This happens sometimes with stable backports but I've never seen it happen working on "current" branches.

Sorry about that!

Would you mind sending the appropriate patches? I can do the revert if you prefer, but since you need to send the fix anyway..

#7 lore raw

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

Quoted 38 lines · Jakub Kicinski
Quoted 26 lines · On Tue, 24 Nov 2020 15:23:27 +0100 Antonio Borneo wrote:
Quoted 25 lines · Ahmad Fatoum
Quoted 7 lines · Jakub Kicinski
Quoted 6 lines · Antonio Borneo

All the registers and the functionalities used in the callback dwmac5_flex_pps_config() are common between dwmac 4.10a [1] and 5.00a [2].

Reuse the same callback for dwmac 4.10a too.

Quoted 8 lines
Quoted 6 lines

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Applied to net-next.

This patch seems to have been fuzzily applied at the wrong location. The diff describes extension of dwmac 4.10a and so does the @@ line:

  @@ -864,6 +864,7 @@ const struct stmmac_ops dwmac410_ops = {

The patch was applied mainline as 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a"), but it extends dwmac4_ops instead:

Quoted 8 lines
Quoted 5 lines

  @@ -938,6 +938,7 @@ const struct stmmac_ops dwmac4_ops = {

I don't know if dwmac4 actually supports FlexPPS, so I think it's better to be on the safe side and revert 757926247836 and add the change for the correct variant.

Agree,
the patch get applied to the wrong place!

:-o

Quoted 7 lines

This happens sometimes with stable backports but I've never seen it happen working on "current" branches.

Sorry about that!

Would you mind sending the appropriate patches? I can do the revert if you prefer, but since you need to send the fix anyway..

You mean sending two patches one for revert and one to re-apply the code? Or a single patch for the fix?

Antonio

maintainer
#8 lore raw

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

Quoted 42 lines · On Tue, 24 Nov 2020 19:27:03 +0100 Antonio Borneo wrote:
Quoted 41 lines · Jakub Kicinski
Quoted 26 lines · On Tue, 24 Nov 2020 15:23:27 +0100 Antonio Borneo wrote:
Quoted 25 lines · Ahmad Fatoum
Quoted 7 lines · Jakub Kicinski
Quoted 6 lines · Antonio Borneo

All the registers and the functionalities used in the callback dwmac5_flex_pps_config() are common between dwmac 4.10a [1] and 5.00a [2].

Reuse the same callback for dwmac 4.10a too.

Quoted 8 lines
Quoted 6 lines

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Applied to net-next.

This patch seems to have been fuzzily applied at the wrong location. The diff describes extension of dwmac 4.10a and so does the @@ line:

  @@ -864,6 +864,7 @@ const struct stmmac_ops dwmac410_ops = {

The patch was applied mainline as 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a"), but it extends dwmac4_ops instead:

Quoted 8 lines
Quoted 5 lines

  @@ -938,6 +938,7 @@ const struct stmmac_ops dwmac4_ops = {

I don't know if dwmac4 actually supports FlexPPS, so I think it's better to be on the safe side and revert 757926247836 and add the change for the correct variant.

Agree,
the patch get applied to the wrong place!

:-o

This happens sometimes with stable backports but I've never seen it happen working on "current" branches.

Quoted 7 lines
Quoted 4 lines

Sorry about that!

Would you mind sending the appropriate patches? I can do the revert if you prefer, but since you need to send the fix anyway..

You mean sending two patches one for revert and one to re-apply the code? Or a single patch for the fix?

Either way is fine by me. If I was doing it - I'd probably send just one patch, but if you prefer to revert first - nothing wrong with that.

#9 lore raw

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

In reply to Ahmad Fatoum

To += Jakub's new address

Quoted 37 lines · Ahmad Fatoum

Hello Jakub,

Quoted 7 lines · Jakub Kicinski
Quoted 6 lines · Antonio Borneo

All the registers and the functionalities used in the callback dwmac5_flex_pps_config() are common between dwmac 4.10a [1] and 5.00a [2].

Reuse the same callback for dwmac 4.10a too.

Quoted 8 lines
Quoted 6 lines

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Applied to net-next.

This patch seems to have been fuzzily applied at the wrong location. The diff describes extension of dwmac 4.10a and so does the @@ line:

  @@ -864,6 +864,7 @@ const struct stmmac_ops dwmac410_ops = {

The patch was applied mainline as 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a"), but it extends dwmac4_ops instead:

  @@ -938,6 +938,7 @@ const struct stmmac_ops dwmac4_ops = {

I don't know if dwmac4 actually supports FlexPPS, so I think it's better to be on the safe side and revert 757926247836 and add the change for the correct variant.

Cheers,
Ahmad

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#10 lore raw

PATCH 1/1 net: stmmac: fix incorrect merge of patch upstream

In reply to Ahmad Fatoum

Commit 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a") was intended to modify the struct dwmac410_ops, but it got somehow badly merged and modified the struct dwmac4_ops.

Revert the modification in struct dwmac4_ops and re-apply it properly in struct dwmac410_ops.

Fixes 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a")

---
To: Alexandre Torgue <[email protected]>
To: Jose Abreu <[email protected]>
To: "David S. Miller" <[email protected]>
To: Jakub Kicinski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
In-Reply-To: <[email protected]>

---
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +1 -1
index 002791b77356..ced6d76a0d85 100644
@@ -1171,7 +1171,6 @@ const struct stmmac_ops dwmac4_ops = {
 	.pcs_get_adv_lp = dwmac4_get_adv_lp,
 	.debug = dwmac4_debug,
 	.set_filter = dwmac4_set_filter,
-	.flex_pps_config = dwmac5_flex_pps_config,
 	.set_mac_loopback = dwmac4_set_mac_loopback,
 	.update_vlan_hash = dwmac4_update_vlan_hash,
 	.sarc_configure = dwmac4_sarc_configure,
@@ -1213,6 +1212,7 @@ const struct stmmac_ops dwmac410_ops = {
 	.pcs_get_adv_lp = dwmac4_get_adv_lp,
 	.debug = dwmac4_debug,
 	.set_filter = dwmac4_set_filter,
+	.flex_pps_config = dwmac5_flex_pps_config,
 	.set_mac_loopback = dwmac4_set_mac_loopback,
 	.update_vlan_hash = dwmac4_update_vlan_hash,
 	.sarc_configure = dwmac4_sarc_configure,

base-commit: 9bd2702d292cb7b565b09e949d30288ab7a26d51

Signature · 1 line
2.29.2
#11 lore raw

Re: [PATCH] net: stmmac: fix incorrect merge of patch upstream

Hello,

Quoted 9 lines · Antonio Borneo

Commit 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a") was intended to modify the struct dwmac410_ops, but it got somehow badly merged and modified the struct dwmac4_ops.

Revert the modification in struct dwmac4_ops and re-apply it properly in struct dwmac410_ops.

Fixes 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a")

I don't think extension of dwmac410_ops should be backported to stable. It's a new feature and should go into net-next like any other. The fix that could be backported is reverting the unintentional change of dwmac4.

Cheers,
Ahmad

Quoted 40 lines

---
To: Alexandre Torgue <[email protected]>
To: Jose Abreu <[email protected]>
To: "David S. Miller" <[email protected]>
To: Jakub Kicinski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
In-Reply-To: <[email protected]>

---
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +1 -1
index 002791b77356..ced6d76a0d85 100644
@@ -1171,7 +1171,6 @@ const struct stmmac_ops dwmac4_ops = {
 	.pcs_get_adv_lp = dwmac4_get_adv_lp,
 	.debug = dwmac4_debug,
 	.set_filter = dwmac4_set_filter,
-	.flex_pps_config = dwmac5_flex_pps_config,
 	.set_mac_loopback = dwmac4_set_mac_loopback,
 	.update_vlan_hash = dwmac4_update_vlan_hash,
 	.sarc_configure = dwmac4_sarc_configure,
@@ -1213,6 +1212,7 @@ const struct stmmac_ops dwmac410_ops = {
 	.pcs_get_adv_lp = dwmac4_get_adv_lp,
 	.debug = dwmac4_debug,
 	.set_filter = dwmac4_set_filter,
+	.flex_pps_config = dwmac5_flex_pps_config,
 	.set_mac_loopback = dwmac4_set_mac_loopback,
 	.update_vlan_hash = dwmac4_update_vlan_hash,
 	.sarc_configure = dwmac4_sarc_configure,

base-commit: 9bd2702d292cb7b565b09e949d30288ab7a26d51

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
maintainer Applied
#12 lore raw

Re: [PATCH] net: stmmac: fix incorrect merge of patch upstream

In reply to Antonio Borneo
Quoted 11 lines · On Tue, 24 Nov 2020 23:37:29 +0100 Antonio Borneo wrote:

Commit 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a") was intended to modify the struct dwmac410_ops, but it got somehow badly merged and modified the struct dwmac4_ops.

Revert the modification in struct dwmac4_ops and re-apply it properly in struct dwmac410_ops.

Fixes 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a")

Applied, and queued for 5.9 (all other 5.5+ branches are EOL by now).

Thanks!

#13 lore raw

PATCH 1/1 net: stmmac: fix length of PTP clock's name string

In reply to Antonio Borneo

The field "name" in struct ptp_clock_info has a fixed size of 16 chars and is used as zero terminated string by clock_name_show() in drivers/ptp/ptp_sysfs.c
The current initialization value requires 17 chars to fit also the null termination, and this causes overflow to the next bytes in the struct when the string is read as null terminated:

	hexdump -C /sys/class/ptp/ptp0/clock_name
	00000000  73 74 6d 6d 61 63 5f 70  74 70 5f 63 6c 6f 63 6b  |stmmac_ptp_clock|
	00000010  a0 ac b9 03 0a                                    |.....|

where the extra 4 bytes (excluding the newline) after the string represent the integer 0x03b9aca0 = 62500000 assigned to the field "max_adj" that follows "name" in the same struct.

There is no strict requirement for the "name" content and in the comment in ptp_clock_kernel.h it's reported it should just be 'A short "friendly name" to identify the clock'.
Replace it with "stmmac ptp".

Fixes 92ba6888510c ("stmmac: add the support for PTP hw clock driver")
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c +1 -1
index 173493db038c..df638b18b72c 100644
@@ -164,7 +164,7 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
 /* structure describing a PTP hardware clock */
 static struct ptp_clock_info stmmac_ptp_clock_ops = {
 	.owner = THIS_MODULE,
-	.name = "stmmac_ptp_clock",
+	.name = "stmmac ptp",
 	.max_adj = 62500000,
 	.n_alarm = 0,
 	.n_ext_ts = 0,
Signature · 1 line
2.23.0
#14 lore raw

Re: [PATCH] net: stmmac: fix length of PTP clock's name string

Quoted 13 lines · Antonio Borneo

The field "name" in struct ptp_clock_info has a fixed size of 16 chars and is used as zero terminated string by clock_name_show() in drivers/ptp/ptp_sysfs.c
The current initialization value requires 17 chars to fit also the null termination, and this causes overflow to the next bytes in the struct when the string is read as null terminated:

	hexdump -C /sys/class/ptp/ptp0/clock_name
	00000000  73 74 6d 6d 61 63 5f 70  74 70 5f 63 6c 6f 63 6b  |stmmac_ptp_clock|
	00000010  a0 ac b9 03 0a                                    |.....|

where the extra 4 bytes (excluding the newline) after the string represent the integer 0x03b9aca0 = 62500000 assigned to the field "max_adj" that follows "name" in the same struct.

Quoted 7 lines

There is no strict requirement for the "name" content and in the comment in ptp_clock_kernel.h it's reported it should just be 'A short "friendly name" to identify the clock'.
Replace it with "stmmac ptp".

Fixes 92ba6888510c ("stmmac: add the support for PTP hw clock driver")

Applied to net, queued for stable.

For future submissions please indicate the target tree. Networking fixes should go to the net tree and have [PATCH net] in the subject, while normal patches such as new features and clean ups should be tagged as [PATCH net-next].

#15 lore raw

PATCH 1/1 net: stmmac: fix disabling flexible PPS output

In reply to Antonio Borneo

Accordingly to Synopsys documentation [1] and [2], when bit PPSEN0 in register MAC_PPS_CONTROL is set it selects the functionality command in the same register, otherwise selects the functionality control.
Command functionality is required to either enable (command 0x2) and disable (command 0x5) the flexible PPS output, but the bit PPSEN0 is currently set only for enabling.

Set the bit PPSEN0 to properly disable flexible PPS output.

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Fixes 9a8a02c9d46d ("net: stmmac: Add Flexible PPS support")
---
 drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/stmicro/stmmac/dwmac5.c +1 -0
index 3f4f3132e16b..e436fa160c7d 100644
@@ -515,6 +515,7 @@ int dwmac5_flex_pps_config(void __iomem *ioaddr, int index,
 
 	if (!enable) {
 		val |= PPSCMDx(index, 0x5);
+		val |= PPSEN0;
 		writel(val, ioaddr + MAC_PPS_CONTROL);
 		return 0;
 	}
Signature · 1 line
2.23.0
#16 lore raw

Re: [PATCH] net: stmmac: fix disabling flexible PPS output

Quoted 10 lines · Antonio Borneo

Accordingly to Synopsys documentation [1] and [2], when bit PPSEN0 in register MAC_PPS_CONTROL is set it selects the functionality command in the same register, otherwise selects the functionality control.
Command functionality is required to either enable (command 0x2) and disable (command 0x5) the flexible PPS output, but the bit PPSEN0 is currently set only for enabling.

Set the bit PPSEN0 to properly disable flexible PPS output.

Quoted 7 lines

Tested on STM32MP15x, based on dwmac 4.10a.

[1] DWC Ethernet QoS Databook 4.10a October 2014
[2] DWC Ethernet QoS Databook 5.00a September 2017

Fixes 9a8a02c9d46d ("net: stmmac: Add Flexible PPS support")

Applied to net, queued for stable.