Skip to contentSkip to conversation

drm: panels: fix spi aliases of former omap panels

PATCH In review Andreas Kemnade 3 participants 4 messages Oct 7, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: panels: fix spi aliases of former omap panels

When the panels were moved from omap/displays/ to panel/ omapdss prefix was stripped, which cause spi modalias to not contain the vendor-prefix anymore.

so we had e.g. in former times:
compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1 now:
compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1

This is consistent with other drivers. Tested the td028ttec.c only, but the pattern looks the same for the other ones.

Fixes 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers")
---
 drivers/gpu/drm/panel/panel-lg-lb035q02.c       | 2 +-
 drivers/gpu/drm/panel/panel-nec-nl8048hl11.c    | 2 +-
 drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c | 2 +-
 drivers/gpu/drm/panel/panel-sony-acx565akm.c    | 2 +-
 drivers/gpu/drm/panel/panel-tpo-td028ttec1.c    | 3 +--
 drivers/gpu/drm/panel/panel-tpo-td043mtea1.c    | 2 +-
 6 files changed, 6 insertions(+), 7 deletions(-)
drivers/gpu/drm/panel/panel-lg-lb035q02.c +1 -1
index fc82a525b071b..8423684a0557e 100644
@@ -231,7 +231,7 @@ static struct spi_driver lb035q02_driver = {
 
 module_spi_driver(lb035q02_driver);
 
-MODULE_ALIAS("spi:lgphilips,lb035q02");
+MODULE_ALIAS("spi:lb035q02");
 MODULE_AUTHOR("Tomi Valkeinen <[email protected]>");
 MODULE_DESCRIPTION("LG.Philips LB035Q02 LCD Panel driver");
 MODULE_LICENSE("GPL");
drivers/gpu/drm/panel/panel-nec-nl8048hl11.c +1 -1
index 299b217c83e18..71b07ef2a62dd 100644
@@ -242,7 +242,7 @@ static struct spi_driver nl8048_driver = {
 
 module_spi_driver(nl8048_driver);
 
-MODULE_ALIAS("spi:nec,nl8048hl11");
+MODULE_ALIAS("spi:nl8048hl11");
 MODULE_AUTHOR("Erik Gilling <[email protected]>");
 MODULE_DESCRIPTION("NEC-NL8048HL11 Driver");
 MODULE_LICENSE("GPL");
drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c +1 -1
index 46cd9a2501298..838d39a263f53 100644
@@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device *pdev)
 }
 
 static const struct of_device_id ls037v7dw01_of_match[] = {
-	{ .compatible = "sharp,ls037v7dw01", },
+	{ .compatible = "ls037v7dw01", },
 	{ /* sentinel */ },
 };
 
drivers/gpu/drm/panel/panel-sony-acx565akm.c +1 -1
index 305259b587670..a8af9340f89ee 100644
@@ -695,7 +695,7 @@ static struct spi_driver acx565akm_driver = {
 
 module_spi_driver(acx565akm_driver);
 
-MODULE_ALIAS("spi:sony,acx565akm");
+MODULE_ALIAS("spi:acx565akm");
 MODULE_AUTHOR("Nokia Corporation");
 MODULE_DESCRIPTION("Sony ACX565AKM LCD Panel Driver");
 MODULE_LICENSE("GPL");
drivers/gpu/drm/panel/panel-tpo-td028ttec1.c +1 -2
index d7b2e34626efe..3ab66b4d3ea27 100644
@@ -375,8 +375,7 @@ static const struct of_device_id td028ttec1_of_match[] = {
 MODULE_DEVICE_TABLE(of, td028ttec1_of_match);
 
 static const struct spi_device_id td028ttec1_ids[] = {
-	{ "tpo,td028ttec1", 0},
-	{ "toppoly,td028ttec1", 0 },
+	{ "td028ttec1", 0},
 	{ /* sentinel */ }
 };
 
drivers/gpu/drm/panel/panel-tpo-td043mtea1.c +1 -1
index 84370562910ff..7e6cf0890600c 100644
@@ -503,7 +503,7 @@ static struct spi_driver td043mtea1_driver = {
 
 module_spi_driver(td043mtea1_driver);
 
-MODULE_ALIAS("spi:tpo,td043mtea1");
+MODULE_ALIAS("spi:td043mtea1");
 MODULE_AUTHOR("Gražvydas Ignotas <[email protected]>");
 MODULE_DESCRIPTION("TPO TD043MTEA1 Panel Driver");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.20.1
#1 lore raw

Hi,

Quoted 9 lines · Andreas Kemnade

When the panels were moved from omap/displays/ to panel/ omapdss prefix was stripped, which cause spi modalias to not contain the vendor-prefix anymore.

so we had e.g. in former times:
compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1 now:
compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1

Quoted 6 lines

This is consistent with other drivers. Tested the td028ttec.c only, but the pattern looks the same for the other ones.

Fixes 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers")

---

Patch looks good to me, but you have one false positive.

Quoted 7 lines

[...]

drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c +0 -0
index 46cd9a2501298..838d39a263f53 100644

drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c static int ls037v7dw01_remove(struct platform_device *pdev) · line 210

Quoted 8 lines
drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c +1 -1
@@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device *pdev)
 }
 
 static const struct of_device_id ls037v7dw01_of_match[] = {
-	{ .compatible = "sharp,ls037v7dw01", },
+	{ .compatible = "ls037v7dw01", },
 	{ /* sentinel */ },
 };
 

The DT compatible should have a vendor prefix.

Quoted 1 line

[...]

-- Sebastian

#2 lore raw
Quoted 30 lines · On Mon, 7 Oct 2019 19:04:46 +0200 Sebastian Reichel <[email protected]> wrote:

Hi,

Quoted 9 lines · Andreas Kemnade

When the panels were moved from omap/displays/ to panel/ omapdss prefix was stripped, which cause spi modalias to not contain the vendor-prefix anymore.

so we had e.g. in former times:
compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1 now:
compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1

Quoted 6 lines

This is consistent with other drivers. Tested the td028ttec.c only, but the pattern looks the same for the other ones.

Fixes 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers")

---

Patch looks good to me, but you have one false positive.

Quoted 9 lines

[...]

drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c +0 -0
index 46cd9a2501298..838d39a263f53 100644
@@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device *pdev)
 }
 
Quoted 9 lines

drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c static int ls037v7dw01_remove(struct platform_device *pdev) · line 210

Quoted 6 lines
drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c +1 -1
 static const struct of_device_id ls037v7dw01_of_match[] = {
-	{ .compatible = "sharp,ls037v7dw01", },
+	{ .compatible = "ls037v7dw01", },
 	{ /* sentinel */ },
 };
 

The DT compatible should have a vendor prefix.

oops, sorry, but I it seems that Laurent already has submitted a fix.

Regards,
Andreas

#3 lore raw

Hi Andreas,

Quoted 37 lines · Andreas Kemnade
Quoted 28 lines · On Mon, 7 Oct 2019 19:04:46 +0200 Sebastian Reichel wrote:
Quoted 9 lines · Andreas Kemnade

When the panels were moved from omap/displays/ to panel/ omapdss prefix was stripped, which cause spi modalias to not contain the vendor-prefix anymore.

so we had e.g. in former times:
compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1 now:
compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1

Quoted 6 lines

This is consistent with other drivers. Tested the td028ttec.c only, but the pattern looks the same for the other ones.

Fixes 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers")

---

Patch looks good to me, but you have one false positive.

Quoted 9 lines

[...]

drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c +0 -0
index 46cd9a2501298..838d39a263f53 100644
@@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device *pdev)
 }
 
Quoted 7 lines

drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c static int ls037v7dw01_remove(struct platform_device *pdev) · line 209

Quoted 5 lines
drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c +1 -1
 static const struct of_device_id ls037v7dw01_of_match[] = {
-	{ .compatible = "sharp,ls037v7dw01", },
+	{ .compatible = "ls037v7dw01", },
 	{ /* sentinel */ },
 };

The DT compatible should have a vendor prefix.

Quoted 1 line

oops, sorry, but I it seems that Laurent already has submitted a fix.

Seems we've been racing each other :-S Feel free to submit a v2 of this patch if you think it's better than my series. As long as the problem gets fixed, I'll be happy :-)

Signature · 3 lines
Regards,

Laurent Pinchart