Skip to contentSkip to conversation

package/python-pysnmp-apps: remove package

PATCH Superseded Asaf Kahlon 2 participants 6 messages Oct 8, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/python-pysnmp-apps: remove package

The package was renamed to snmpclient and is no longer maintained.

---
 package/Config.in                                 |  1 -
 package/python-pysnmp-apps/Config.in              | 12 ------------
 .../python-pysnmp-apps/python-pysnmp-apps.hash    |  5 -----
 package/python-pysnmp-apps/python-pysnmp-apps.mk  | 15 ---------------
 4 files changed, 33 deletions(-)
 delete mode 100644 package/python-pysnmp-apps/Config.in
 delete mode 100644 package/python-pysnmp-apps/python-pysnmp-apps.hash
 delete mode 100644 package/python-pysnmp-apps/python-pysnmp-apps.mk
package/Config.in +0 -1
index 47b602c547..d8d0824c71 100644
@@ -1037,7 +1037,6 @@ menu "External python modules"
 	source "package/python-pysmb/Config.in"
 	source "package/python-pysmi/Config.in"
 	source "package/python-pysnmp/Config.in"
-	source "package/python-pysnmp-apps/Config.in"
 	source "package/python-pysnmp-mibs/Config.in"
 	source "package/python-pysocks/Config.in"
 	source "package/python-pytablereader/Config.in"
package/python-pysnmp-apps/Config.in deleted +0 -12
deleted file mode 100644
index 32e3269946..0000000000
@@ -1,12 +0,0 @@
-config BR2_PACKAGE_PYTHON_PYSNMP_APPS
-	bool "python-pysnmp-apps"
-	depends on BR2_INSTALL_LIBSTDCPP # pysnmp -> pyasn
-	select BR2_PACKAGE_PYTHON_PYSNMP
-	help
-	  A collection of command-line tools for SNMP management
-	  purposes built on top of the PySNMP package.
-
-	  http://pysnmp.sf.net
-
-comment "python-pysnmp-apps needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
package/python-pysnmp-apps/python-pysnmp-apps.hash deleted +0 -5
deleted file mode 100644
index 42120486d9..0000000000
@@ -1,5 +0,0 @@
-# md5, sha256 from https://pypi.org/pypi/pysnmp-apps/json
-md5	ed3e4d421bb0e1806298120313efccc2  pysnmp-apps-0.5.3.tar.gz
-sha256	bf4ea6f3054a25b05e255d29e0b57a8aa8102f509048e3a9c0d93ddc86aff570  pysnmp-apps-0.5.3.tar.gz
-# Locally computed sha256 checksums
-sha256	f82128f64d567c333936a12b99a21d0e8cd66ce628d51ce0a7770cc38dc7fe43  LICENSE.txt
package/python-pysnmp-apps/python-pysnmp-apps.mk deleted +0 -15
deleted file mode 100644
index ee494eba0f..0000000000
@@ -1,15 +0,0 @@
-################################################################################
-#
-# python-pysnmp-apps
-#
-################################################################################
-
-PYTHON_PYSNMP_APPS_VERSION = 0.5.3
-PYTHON_PYSNMP_APPS_SOURCE = pysnmp-apps-$(PYTHON_PYSNMP_APPS_VERSION).tar.gz
-PYTHON_PYSNMP_APPS_SITE = https://files.pythonhosted.org/packages/c2/1a/26f5f3732df2c7d34663a7f2fa6534b5b4ffae73a4a440b75864ec826ba6
-PYTHON_PYSNMP_APPS_SETUP_TYPE = setuptools
-PYTHON_PYSNMP_APPS_LICENSE = BSD-3-Clause
-PYTHON_PYSNMP_APPS_LICENSE_FILES = LICENSE.txt
-PYTHON_PYSNMP_APPS_DEPENDENCIES = python-pysnmp
-
-$(eval $(python-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/python-pytz: bump to version 2019.3

---
 package/python-pytz/python-pytz.hash | 4 ++--
 package/python-pytz/python-pytz.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
package/python-pytz/python-pytz.hash +2 -2
index 9e0dfe0289..d1ce81e590 100644
@@ -1,5 +1,5 @@
 # md5, sha256 from https://pypi.org/pypi/pytz/json
-md5	8c21963449c3a793aa61ef122e171516  pytz-2019.2.tar.gz
-sha256	26c0b32e437e54a18161324a2fca3c4b9846b74a8dccddd843113109e1116b32  pytz-2019.2.tar.gz
+md5	c3d84a465fc56a4edd52cca8873ac0df  pytz-2019.3.tar.gz
+sha256	b02c06db6cf09c12dd25137e563b31700d3b80fcc4ad23abb7a315f2789819be  pytz-2019.3.tar.gz
 # Locally computed sha256 checksums
 sha256	39f07c72a1bfda349cbd27bac9bcb1e6f8c5b4e5cc3fadf56900406e8cc0b792  LICENSE.txt
package/python-pytz/python-pytz.mk +2 -2
index 217d4850f2..888f3c4556 100644
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-PYTHON_PYTZ_VERSION = 2019.2
+PYTHON_PYTZ_VERSION = 2019.3
 PYTHON_PYTZ_SOURCE = pytz-$(PYTHON_PYTZ_VERSION).tar.gz
-PYTHON_PYTZ_SITE = https://files.pythonhosted.org/packages/27/c0/fbd352ca76050952a03db776d241959d5a2ee1abddfeb9e2a53fdb489be4
+PYTHON_PYTZ_SITE = https://files.pythonhosted.org/packages/82/c3/534ddba230bd4fbbd3b7a3d35f3341d014cca213f369a9940925e7e5f691
 PYTHON_PYTZ_SETUP_TYPE = setuptools
 PYTHON_PYTZ_LICENSE = MIT
 PYTHON_PYTZ_LICENSE_FILES = LICENSE.txt
Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/1 package/python-pytz: bump to version 2019.3

Quoted 5 lines · On Tue, 8 Oct 2019 10:28:00 +0300 Asaf Kahlon <[email protected]> wrote:
---
 package/python-pytz/python-pytz.hash | 4 ++--
 package/python-pytz/python-pytz.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 2/2 package/python-snmpclitools: new package

In reply to Asaf Kahlon

For now, we use PKG-INFO as license file, since LICENSE.rst isn't provided with the tarball.
A pull request was sent upstream:
https://github.com/etingof/snmpclitools/pull/11

---
 package/Config.in                                  |  1 +
 package/python-snmpclitools/Config.in              |  8 ++++++++
 .../python-snmpclitools/python-snmpclitools.hash   |  5 +++++
 package/python-snmpclitools/python-snmpclitools.mk | 14 ++++++++++++++
 4 files changed, 28 insertions(+)
 create mode 100644 package/python-snmpclitools/Config.in
 create mode 100644 package/python-snmpclitools/python-snmpclitools.hash
 create mode 100644 package/python-snmpclitools/python-snmpclitools.mk
package/Config.in +1 -0
index d8d0824c71..676c8b9352 100644
@@ -1085,6 +1085,7 @@ menu "External python modules"
 	source "package/python-six/Config.in"
 	source "package/python-slob/Config.in"
 	source "package/python-smbus-cffi/Config.in"
+	source "package/python-snmpclitools/Config.in"
 	source "package/python-socketio/Config.in"
 	source "package/python-sortedcontainers/Config.in"
 	source "package/python-spidev/Config.in"
package/python-snmpclitools/Config.in new file +8 -0
new file mode 100644
index 0000000000..945aece84d
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PYTHON_SNMPCLITOOLS
+	bool "python-snmpclitools"
+	select BR2_PACKAGE_PYTHON_PYSMI # runtime
+	select BR2_PACKAGE_PYTHON_PYSNMP # runtime
+	help
+	  SNMP command-line tools.
+
+	  https://github.com/etingof/snmpclitools
package/python-snmpclitools/python-snmpclitools.hash new file +5 -0
new file mode 100644
index 0000000000..4dcbdcb6e0
@@ -0,0 +1,5 @@
+# md5, sha256 from https://pypi.org/pypi/snmpclitools/json
+md5	132b100f5e7b80715e6c1d424e89687c  snmpclitools-0.6.4.tar.gz
+sha256	820c45de419bf355c845a96610a395ec18a15176ac0362d388da7740266ea1ac  snmpclitools-0.6.4.tar.gz
+# Locally computed sha256 checksums
+sha256	ed5561a0f5b75e93aa026c1b9fdef58e7ccbf6b2e9a2458be732afc288209d23  PKG-INFO
package/python-snmpclitools/python-snmpclitools.mk new file +14 -0
new file mode 100644
index 0000000000..0794e8ecf3
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-snmpclitools
+#
+################################################################################
+
+PYTHON_SNMPCLITOOLS_VERSION = 0.6.4
+PYTHON_SNMPCLITOOLS_SOURCE = snmpclitools-$(PYTHON_SNMPCLITOOLS_VERSION).tar.gz
+PYTHON_SNMPCLITOOLS_SITE = https://files.pythonhosted.org/packages/03/2a/8488828e92a82c5416e33fba6089283162937b0f73e5b15205fb6ec3bbea
+PYTHON_SNMPCLITOOLS_SETUP_TYPE = setuptools
+PYTHON_SNMPCLITOOLS_LICENSE = BSD-2-Clause
+PYTHON_SNMPCLITOOLS_LICENSE_FILES = PKG-INFO
+
+$(eval $(python-package))
Signature · 1 line
2.20.1
#4 lore raw

PATCH 2/2 package/python-snmpclitools: new package

Quoted 6 lines · On Tue, 8 Oct 2019 10:28:01 +0300 Asaf Kahlon <[email protected]> wrote:

For now, we use PKG-INFO as license file, since LICENSE.rst isn't provided with the tarball.
A pull request was sent upstream:
https://github.com/etingof/snmpclitools/pull/11

I am wondering if this package shouldn't be named just "snmpclitools", like upstream. In fact, contrary to the Python modules named python-<something>, here the fact that it is Python is just an implementation detail. Look at package/circus or package/crudini for example.

And then of course, instead of being in the Python modules section, it should be in the Networking tools section. And have a proper depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 (depending on which one is applicable, or both).

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/2 package/python-pysnmp-apps: remove package

In reply to Asaf Kahlon

Hello,

Quoted 9 lines · On Tue, 8 Oct 2019 10:27:59 +0300 Asaf Kahlon <[email protected]> wrote:

The package was renamed to snmpclient and is no longer maintained.

---
 package/Config.in                                 |  1 -
 package/python-pysnmp-apps/Config.in              | 12 ------------
 .../python-pysnmp-apps/python-pysnmp-apps.hash    |  5 -----
 package/python-pysnmp-apps/python-pysnmp-apps.mk  | 15 ---------------
 4 files changed, 33 deletions(-)

You're missing the Config.in.legacy handling. The help text of the Config.in.legacy entry should mention what is the replacement package, and the legacy option should select it.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com