Skip to contentSkip to conversation

dts: Disable DMA support on the BK4 vf610 device's fsl_lpuart driver

PATCH In review Lukasz Majewski 2 participants 3 messages Oct 10, 2019 – Oct 25, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dts: Disable DMA support on the BK4 vf610 device's fsl_lpuart driver

This change disables the DMA support (RX/TX) on the NXP's fsl_lpuart driver - the PIO mode is used instead. This change is necessary for better robustness of BK4's device use cases with many potentially interrupted short serial transfers.

Without it the driver hangs when some distortion happens on UART lines.

---
Changes for v2:
- Use /delete-property/dma-names; instead of dma-names = "","";

---
 arch/arm/boot/dts/vf610-bk4.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/vf610-bk4.dts +4 -0
index 0f3870d3b099..830c85476b3d 100644
@@ -259,24 +259,28 @@
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart0>;
+	/delete-property/dma-names;
 	status = "okay";
 };
 
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;
+	/delete-property/dma-names;
 	status = "okay";
 };
 
 &uart2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart2>;
+	/delete-property/dma-names;
 	status = "okay";
 };
 
 &uart3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart3>;
+	/delete-property/dma-names;
 	status = "okay";
 };
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 9 lines · Lukasz Majewski

This change disables the DMA support (RX/TX) on the NXP's fsl_lpuart driver - the PIO mode is used instead. This change is necessary for better robustness of BK4's device use cases with many potentially interrupted short serial transfers.

Without it the driver hangs when some distortion happens on UART lines.

Subject prefix should be 'ARM: dts: ...'. I fixed it up and applied the patch.

Shawn

#2 lore raw

Hi Shawn,

Quoted 9 lines · Lukasz Majewski
Quoted 8 lines

This change disables the DMA support (RX/TX) on the NXP's fsl_lpuart driver - the PIO mode is used instead. This change is necessary for better robustness of BK4's device use cases with many potentially interrupted short serial transfers.

Without it the driver hangs when some distortion happens on UART lines.

Quoted 7 lines
Quoted 2 lines

Subject prefix should be 'ARM: dts: ...'. I fixed it up and applied the patch.

Shawn

Thanks :-)

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]